mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-08 20:42:43 +00:00
The admin "Delete all data" action carried its delete list inline. That list named nine tables, which was most of the schema on the day it was written, and it stayed at nine while the schema grew to a hundred and twenty-two models. Laboratory results, documents, cycle logs, journals, mood, workouts, sleep and Coach conversations all survived the wipe an operator runs before handing a box on, and the toast said it was done. The per-account wipe had the same defect and grew a derived plan for it. The admin route now reads that plan: ADMIN_WIPE_MODELS is WIPE_MODELS minus a single documented subtraction, so a model added to the schema lands in both wipes at once. - AccountGrant is the one difference, with its reason in the plan: it is the only access path to a managed profile, and this action preserves accounts by definition. Deleting every grant would leave records nobody can open, administer or delete. - The audit history now goes with everything else. It is a record of who did what from where, which is exactly what clearing a box is for; the receipt written after the transaction commits replaces it. - One transaction with the same budget as the account wipe. A half-applied wipe is worse than none, because the person is told it succeeded either way. - The result line reports rows and tables instead of nine fixed names, which is how nobody noticed: it read the same whether the wipe had cleared nine tables or ninety. Guards, both watched red before landing: admin-data-wipe-completeness.test.ts fails when a user-scoped model reaches neither the wipe nor a written exemption, and when the route names a table inline again. The integration guard seeds every table in the schema for two accounts, runs the route, and asks the database what is left — drop one model from the plan and it names the surviving table.
266 lines
9.0 KiB
TypeScript
266 lines
9.0 KiB
TypeScript
/**
|
|
* Schema-driven seeding + counting for the two wipe integration guards.
|
|
*
|
|
* The whole defect class here is about rows that SURVIVE, so a mocked Prisma
|
|
* proves nothing: it can only show that the calls a route makes were made.
|
|
* Both guards therefore seed a row into every table in the schema, run their
|
|
* wipe against real Postgres, and then ask the database what is left.
|
|
*
|
|
* The seeding is driven by `information_schema` and `pg_constraint` rather
|
|
* than a hand-written fixture, for the same reason the wipe list is derived
|
|
* rather than hand-written: a fixture written today covers the schema of
|
|
* today. A table added next year is seeded automatically and therefore
|
|
* asserted automatically.
|
|
*
|
|
* It lives here rather than in either test file because the account wipe and
|
|
* the admin wipe have to be measured with the same ruler. Two copies would
|
|
* drift, and the copy that drifted would be the one whose route was wrong.
|
|
*/
|
|
import { readFileSync } from "node:fs";
|
|
import { join } from "node:path";
|
|
|
|
import type { PrismaClient } from "@/generated/prisma/client";
|
|
import { WIPE_OWNER_FIELDS } from "@/lib/data-wipe/wipe-plan";
|
|
|
|
// ── schema.prisma model → table name ────────────────────────────────────────
|
|
|
|
export function modelTableMap(): Map<string, string> {
|
|
const schema = readFileSync(
|
|
join(process.cwd(), "prisma", "schema.prisma"),
|
|
"utf8",
|
|
);
|
|
const map = new Map<string, string>();
|
|
for (const block of schema.matchAll(/^model\s+(\w+)\s*\{([\s\S]*?)^\}/gm)) {
|
|
const mapped = /@@map\("([^"]+)"\)/.exec(block[2]);
|
|
map.set(block[1], mapped ? mapped[1] : block[1]);
|
|
}
|
|
return map;
|
|
}
|
|
|
|
// ── generic seeder ──────────────────────────────────────────────────────────
|
|
|
|
interface ColumnRow {
|
|
table_name: string;
|
|
column_name: string;
|
|
is_nullable: string;
|
|
column_default: string | null;
|
|
udt_name: string;
|
|
}
|
|
|
|
interface ForeignKeyRow {
|
|
table_name: string;
|
|
column_name: string;
|
|
ref_table: string;
|
|
ref_column: string;
|
|
cascades: boolean;
|
|
}
|
|
|
|
/** Tables the seeder never writes: Prisma's own ledger, and the account row. */
|
|
const SEED_SKIP = new Set(["_prisma_migrations", "users"]);
|
|
|
|
function synthesise(udt: string, enums: Map<string, string>, tag: string) {
|
|
if (udt.startsWith("_")) return `'{}'::${udt.slice(1)}[]`;
|
|
switch (udt) {
|
|
case "text":
|
|
case "varchar":
|
|
case "bpchar":
|
|
return `'${tag}'`;
|
|
case "int2":
|
|
case "int4":
|
|
case "int8":
|
|
case "numeric":
|
|
case "float4":
|
|
case "float8":
|
|
return "1";
|
|
case "bool":
|
|
return "false";
|
|
case "timestamp":
|
|
case "timestamptz":
|
|
case "date":
|
|
return "now()";
|
|
case "bytea":
|
|
return "'\\x00'::bytea";
|
|
case "json":
|
|
case "jsonb":
|
|
return `'{}'::${udt}`;
|
|
case "uuid":
|
|
return "gen_random_uuid()";
|
|
default: {
|
|
const label = enums.get(udt);
|
|
if (label) return `'${label}'::"${udt}"`;
|
|
throw new Error(`seeder has no value for column type "${udt}"`);
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Insert one row into every table in `public`, parents first, wiring every
|
|
* foreign key to the row already created for its target and every `user_id` to
|
|
* the account under test.
|
|
*/
|
|
export async function seedEveryTable(
|
|
prisma: PrismaClient,
|
|
userId: string,
|
|
): Promise<string[]> {
|
|
const columns = await prisma.$queryRaw<ColumnRow[]>`
|
|
SELECT table_name, column_name, is_nullable, column_default, udt_name
|
|
FROM information_schema.columns
|
|
WHERE table_schema = 'public'`;
|
|
|
|
const foreignKeys = await prisma.$queryRaw<ForeignKeyRow[]>`
|
|
SELECT con.conrelid::regclass::text AS table_name,
|
|
att.attname AS column_name,
|
|
con.confrelid::regclass::text AS ref_table,
|
|
ratt.attname AS ref_column,
|
|
con.confdeltype = 'c' AS cascades
|
|
FROM pg_constraint con
|
|
JOIN LATERAL unnest(con.conkey) WITH ORDINALITY AS ck(attnum, ord) ON true
|
|
JOIN LATERAL unnest(con.confkey) WITH ORDINALITY AS rk(attnum, ord)
|
|
ON rk.ord = ck.ord
|
|
JOIN pg_attribute att ON att.attrelid = con.conrelid AND att.attnum = ck.attnum
|
|
JOIN pg_attribute ratt ON ratt.attrelid = con.confrelid AND ratt.attnum = rk.attnum
|
|
WHERE con.contype = 'f' AND con.connamespace = 'public'::regnamespace`;
|
|
|
|
const enumRows = await prisma.$queryRaw<
|
|
Array<{ typname: string; enumlabel: string }>
|
|
>`
|
|
SELECT t.typname, e.enumlabel
|
|
FROM pg_type t
|
|
JOIN pg_enum e ON e.enumtypid = t.oid
|
|
ORDER BY t.typname, e.enumsortorder`;
|
|
const enums = new Map<string, string>();
|
|
for (const row of enumRows) {
|
|
if (!enums.has(row.typname)) enums.set(row.typname, row.enumlabel);
|
|
}
|
|
|
|
const byTable = new Map<string, ColumnRow[]>();
|
|
for (const column of columns) {
|
|
if (SEED_SKIP.has(column.table_name)) continue;
|
|
const bucket = byTable.get(column.table_name) ?? [];
|
|
bucket.push(column);
|
|
byTable.set(column.table_name, bucket);
|
|
}
|
|
|
|
const fkByTable = new Map<string, ForeignKeyRow[]>();
|
|
for (const fk of foreignKeys) {
|
|
const bucket = fkByTable.get(fk.table_name) ?? [];
|
|
bucket.push(fk);
|
|
fkByTable.set(fk.table_name, bucket);
|
|
}
|
|
|
|
// Parents before children. A self-reference or an optional cycle is skipped
|
|
// by only ordering on the columns the insert actually fills.
|
|
const pending = new Set(byTable.keys());
|
|
const ordered: string[] = [];
|
|
while (pending.size > 0) {
|
|
let progressed = false;
|
|
for (const table of [...pending]) {
|
|
const blocked = (fkByTable.get(table) ?? []).some(
|
|
(fk) => fk.ref_table !== table && pending.has(fk.ref_table),
|
|
);
|
|
if (blocked) continue;
|
|
ordered.push(table);
|
|
pending.delete(table);
|
|
progressed = true;
|
|
}
|
|
if (!progressed) {
|
|
throw new Error(
|
|
`foreign-key cycle among: ${[...pending].sort().join(", ")}`,
|
|
);
|
|
}
|
|
}
|
|
|
|
const insertedId = new Map<string, string>();
|
|
let tag = 0;
|
|
|
|
for (const table of ordered) {
|
|
const tableColumns = byTable.get(table)!;
|
|
const fks = fkByTable.get(table) ?? [];
|
|
const names: string[] = [];
|
|
const values: string[] = [];
|
|
|
|
for (const column of tableColumns) {
|
|
const fk = fks.find((f) => f.column_name === column.column_name);
|
|
const required =
|
|
column.is_nullable === "NO" && column.column_default === null;
|
|
const isUserColumn = column.column_name === "user_id";
|
|
|
|
if (fk?.ref_table === "users") {
|
|
// Always bind to the account under test, nullable or not — a NULL
|
|
// owner would put the row outside the wipe and make the assertion
|
|
// vacuous.
|
|
names.push(column.column_name);
|
|
values.push(`'${userId}'`);
|
|
continue;
|
|
}
|
|
if (!required && !isUserColumn) continue;
|
|
if (fk) {
|
|
const parent = insertedId.get(fk.ref_table);
|
|
if (!parent) {
|
|
throw new Error(
|
|
`${table}.${column.column_name} references ${fk.ref_table}, which was not seeded`,
|
|
);
|
|
}
|
|
names.push(column.column_name);
|
|
values.push(`'${parent}'`);
|
|
continue;
|
|
}
|
|
names.push(column.column_name);
|
|
values.push(synthesise(column.udt_name, enums, `seed-${tag++}`));
|
|
}
|
|
|
|
const sql =
|
|
names.length === 0
|
|
? `INSERT INTO "${table}" DEFAULT VALUES ON CONFLICT DO NOTHING`
|
|
: `INSERT INTO "${table}" (${names.map((n) => `"${n}"`).join(", ")}) VALUES (${values.join(", ")}) ON CONFLICT DO NOTHING`;
|
|
await prisma.$executeRawUnsafe(sql);
|
|
|
|
const hasId = tableColumns.some((c) => c.column_name === "id");
|
|
if (hasId) {
|
|
const rows = await prisma.$queryRawUnsafe<Array<{ id: string }>>(
|
|
`SELECT id FROM "${table}" LIMIT 1`,
|
|
);
|
|
if (rows[0]) insertedId.set(table, rows[0].id);
|
|
}
|
|
}
|
|
|
|
return ordered;
|
|
}
|
|
|
|
/**
|
|
* The columns that bind a row of `model` to an account, as SQL identifiers.
|
|
*
|
|
* `user_id` is the convention. A model that relates two accounts cannot use
|
|
* it, and the wipe plan already declares its columns — read them from there
|
|
* rather than keeping a second list here, or the two would answer differently
|
|
* and this file would be asserting against its own idea of ownership instead
|
|
* of the one the route uses.
|
|
*/
|
|
export function ownerColumns(model: string | undefined): string[] {
|
|
const declared = model ? WIPE_OWNER_FIELDS[model] : undefined;
|
|
if (!declared) return ["user_id"];
|
|
return declared.map((field) =>
|
|
field.replace(/[A-Z]/g, (c) => `_${c.toLowerCase()}`),
|
|
);
|
|
}
|
|
|
|
export async function countRows(
|
|
prisma: PrismaClient,
|
|
table: string,
|
|
userId?: string,
|
|
model?: string,
|
|
): Promise<number> {
|
|
const predicate = ownerColumns(model)
|
|
.map((column) => `"${column}" = $1`)
|
|
.join(" OR ");
|
|
const rows = userId
|
|
? await prisma.$queryRawUnsafe<Array<{ n: bigint }>>(
|
|
`SELECT count(*)::bigint AS n FROM "${table}" WHERE ${predicate}`,
|
|
userId,
|
|
)
|
|
: await prisma.$queryRawUnsafe<Array<{ n: bigint }>>(
|
|
`SELECT count(*)::bigint AS n FROM "${table}"`,
|
|
);
|
|
return Number(rows[0].n);
|
|
}
|