mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-08 12:32:43 +00:00
Marc-André Bombeck
a402eaaf15
A Coach retrieval tool that read the window and found nothing returned `reason: "no_data"` — the same code for two situations that have nothing in common: the record holds nothing for that metric, and the record holds a substantial history for it, all of it older than the window that was searched. Nothing downstream could tell them apart, so the Coach said the honest-sounding sentence for the wrong case, and then, having been told there was nothing there, changed the subject. Someone with a year of imported glucose readings was told the readings did not exist, on the same account whose glucose page was showing them. The window cap stays. It exists because a multi-year history does not fit a prompt budget, and widening it would only move the same failure. What was missing is the ability to say a different true sentence. - `tools/availability.ts` — one grouped aggregate per miss, no rows materialised, resolving four states: `no_data` (probe confirmed empty), `outside_window` (rows exist, older than the searched window; carries the count, the date range in the user's own timezone, and a bounded per-series mean/min/max), `unavailable_in_scope` (rows exist inside the window and the domain still produced none — a module is off), and `no_data_unconfirmed` (the probe itself failed; absence was never established, so it is not asserted). - Every empty read in the executor routes through it. A bare `no_data` can no longer be returned without the record having been checked. - The DATA INVENTORY carries the same distinction, so a domain the window cannot reach is advertised with what it holds instead of as absent — the model no longer skips the fetch, and a vague follow-up keeps the subject. - Both instructions that told the model to report absence and move on now branch on the reason code, and forbid answering about one metric by reporting another. - The out-of-window aggregate joins the authoritative set for the prose verifier, so the sentence the fix exists to make sayable is not elided. - A cross-cutting narration block that throws is now counted rather than vanishing into a `null` that looks like honest absence. - The medication-compliance page tells a failed read apart from an account with no medications, instead of inviting someone to re-enter what it already holds. Refs #648
src/lib/
The server and runtime toolkit. Everything that is not a page, component, or route handler lives here: the API kit, auth, crypto, the rollup tier, AI providers, notifications, background jobs, and the integration clients. Route handlers and RSC pages compose these modules; the modules never reach back into app/.
Core request kit
api-handler.ts— theapiHandlerwrapper every route uses. Auth resolver (cookie OR Bearer),requireAuth/requireAdmin(admin is cookie-only by construction), idempotency plumbing, Wide-Event builder, GlitchTip forwarder.api-response.ts— the{ data, error, meta? }envelope:apiSuccess/apiError,safeJson, trusted-proxy IP resolver,returnAllZodIssues+sanitiseZodIssues.rate-limit.ts— Postgres-backed sliding-window limiter (single atomic upsert); multi-instance correct.idempotency.ts— user-scoped idempotency keys that refuse to cache secret-shaped responses.query-keys/— the only legal source of TanStack QueryqueryKey/mutationKeyarrays (enforced by an ESLint rule); per-feature files behind theindex.tsbarrel.safe-fetch.ts— the one documented outbound-egress entry (redirect: "manual"+ timeout; optional connect-time DNS-rebinding pin). Rawfetch(underlib/+app/is banned by ESLint.db.ts— the Prisma client singleton.crypto.ts— AES-256-GCM at rest with versioned key ids, fail-closed loader, rotation primitives.
Subsystems
auth/— Postgres sessions, secure-cookie flag policy, passkey (WebAuthn) + Argon2id password, per-device refresh-token rotation, HMAC Bearer tokens.ai/— multi-provider insight + Coach engine:provider-chain.ts, hand-rolled{openai,anthropic,local,codex,mock}-client.ts,coach/,prompts/, citation + confidence helpers.rollups/— DAY/WEEK/MONTH/YEAR pre-aggregations for measurements, mood, and medication compliance. Read-swap pattern: probe the rollup, fall back to live SQL on a coverage miss.notifications/— the dispatcher cascade (APNs → Telegram → ntfy → Web Push), per-channelsenders/, retry policy, VAPID config.jobs/— pg-boss workers: reminders, insight pre-generation, backups, retention sweeps, integration backfills. Recurring work belongs here, not inscripts/.integrations/,withings/,whoop/,fitbit/— OAuth clients and sync services for the device providers;sync/holds the shared delta-feed plumbing.analytics/— trend calculations, cadence-aware medicationcompliance.ts, correlations.insights/,fhir/,doctor-report-*.ts— insight pipeline, FHIR R4 export, client-side doctor-report PDF.openapi/— Zod registry that is the source of truth fordocs/api/openapi.yaml.logging/,observability/,monitoring/— Wide-Event transports and the central redaction denylists (redact at the egress boundary, not the call site).validations/— shared Zod schemas, including the SSRFisPublicUrlfloor.i18n/,tz/+timezone.ts,format*.ts— translations, timezone helpers (Berlin for display, UTC in DB), locale formatting.
Conventions
Kebab-case filenames. See ../../CLAUDE.md "Code conventions" and "Security-relevant patterns"; the critical-files map there cites the exact entry points. Most modules carry tests in a sibling __tests__/.