Marc-André Bombeck
4aaed5c312
Three pieces of code answered "what hour is it" for the salutation. The snapshot builder computed a `greetingHour` in the user's zone and put it on the payload so clients would not have to; no client ever read it. The insights hero derived one through the shared `hourInTz`. The dashboard header derived one through a local helper that fell back to the DEVICE clock whenever the runtime could not resolve the configured zone, which is what happens to an IANA entry the browser's data does not yet carry. At one instant, for one account, those three returned 20, 21 and 05. Keep the client end and drop the server one. The hour is a clock reading, not a fact about the record, and the snapshot body serves stale for up to an hour past its fresh TTL, so a stored hour can name a salutation the clock has left behind. What the server IS authoritative for is the zone, and that already travels on the same payload and is already what both surfaces read. Both greetings now share `hourInTz`, so an unresolvable zone falls back to the same default the rest of the app uses instead of to the device. The header's private helper is gone; it had no other caller. Two tests pinned the old shape by asserting the payload carried an hour. Inverted rather than deleted: the payload must now be shown NOT to carry one, which is the property that was missing when the field went unread for months. `greetingHour` leaves the response contract, so a native client decoding it as required needs the field made optional or dropped.
e2e/
End-to-end browser tests. Playwright 1.60 drives a production build of the app against a real PostgreSQL, with @axe-core/playwright for accessibility assertions. This is the heaviest test tier; CI runs it on every PR, and locally it is worth running when a change touches a UI flow.
Running
pnpm e2e
The Playwright config (../playwright.config.ts) builds the app (next build) and brings up Postgres before the specs run; setup/global-setup.ts seeds the auth + fixture state. The suite is not part of the fast local gate (typecheck / lint / test) — it surfaces at PR CI, so expect responsive/wizard/nav reworks to flag here first.
Layout
setup/—test.ts(the suite'stest+expectentry point),global-setup.ts(auth + DB seeding),test-helpers.ts(shared login + navigation helpers).utils/— fixtures such asmock-dashboard-snapshot.ts.*.spec.ts— one spec per flow: auth/login/redirect, dashboard, charts, the medication-wizard cadences (medications-wizard-*), insights generation + scroll restoration, doctor report, settings, mobile-viewport consistency, locale switch, accessibility (a11y.spec.ts), and thev1427-*regression set.
Conventions
Import test and expect from ./setup/test, never from @playwright/test — types (Page, Route, …) still come from the package. The entry point extends Playwright's test with an automatic fixture that drops route handlers and page listeners after every test, so a handler left in flight cannot fail the test it belonged to once the context closes. src/__tests__/e2e-route-cleanup-guard.test.ts enforces the import boundary.
Assert against stable data-* attributes (data-slot, data-display-step, root display attrs), not viewport-dependent visible text. Responsive sm:hidden UI changes break getByText on desktop while the underlying element is still present — anchoring on data attributes keeps the specs stable across breakpoints. See ../CLAUDE.md.