Files
HealthLog/src/lib
Marc-André Bombeck cbc3b3118d fix(measurements): recompute a stored fold mean only where all its samples remain
The fold repair and the regular folds rewrote an existing daily or hourly
stats: mean from the samples still in the table. Fold tombstones are purged
75 days after they were written, so for an older window those samples can
be a fragment: a re-upload after an anchor reset, the rows of one later
fold run. A mean over them replaced a stored mean that had been taken from
the whole day, and on old days it moved a lot.

A stored mean is now recomputed only for a day that starts at or after the
tombstone horizon (foldConstituentHorizon): every fold tombstone of such a
day was written after dayStart + the fold threshold and is still inside the
retention, so the live samples plus the fold leftovers are the whole day.
That is the last 75 days for daily means and, since dense days fold 90 days
late, the 75 days before the raw window for hourly means. A window also
needs at least one fold leftover; without one the rows in hand are not
known to be all of it.

Beyond the horizon:
- The repair leaves the day as it is and counts it per type as
  windowsSkippedBeyondHorizon.
- The daily-mean consolidation and the dense hourly fold leave a day or
  hour that already has a live stats: row exactly as it is, the stored
  mean and its live samples alike (daysLeftAsStored, hoursLeftAsStored).
  Up to v1.41 the fold overwrote such a row with the mean of the live rows
  alone, and the first v1.42 cut with the mean of those plus whatever
  tombstones were left; both are a mean of part of a day. Dropping the
  live rows instead would lose samples that may not be in the stored
  mean, so they stay as synced. They are few, the folded_window guard
  refuses new ones, and the nightly pass walks over them without writing.
  A day or hour without a stored mean still folds as before.

Inside the horizon, a pass that recomputes a stored mean soft-deletes the
live samples it took in as fold leftovers instead of deleting them, so a
second pass computes the same mean from the same samples. Before, a fold
that deleted them left the repair a fragment, and the repair then rewrote
the mean from the tombstones alone.

The repair, the mean consolidation and the dense fold now take a per-account
advisory lock after the restore lock in every day transaction, and the
repair reads the day's samples inside it, so the two never compute the
same window from two views of its samples or write the same row at once.
The repair also stops at the fold boundary: a day the fold has not
finished is the fold's to complete.
2026-10-09 01:03:02 +02:00
..
…
…
…
…
2026-10-08 20:20:03 +02:00
…
…
…

src/lib/

The server and runtime toolkit. Everything that is not a page, component, or route handler lives here: the API kit, auth, crypto, the rollup tier, AI providers, notifications, background jobs, and the integration clients. Route handlers and RSC pages compose these modules; the modules never reach back into app/.

Core request kit

  • api-handler.ts — the apiHandler wrapper every route uses. Auth resolver (cookie OR Bearer), requireAuth / requireAdmin (admin is cookie-only by construction), idempotency plumbing, Wide-Event builder, GlitchTip forwarder.
  • api-response.ts — the { data, error, meta? } envelope: apiSuccess / apiError, safeJson, trusted-proxy IP resolver, returnAllZodIssues + sanitiseZodIssues.
  • rate-limit.ts — Postgres-backed sliding-window limiter (single atomic upsert); multi-instance correct.
  • idempotency.ts — user-scoped idempotency keys that refuse to cache secret-shaped responses.
  • query-keys/ — the only legal source of TanStack Query queryKey / mutationKey arrays (enforced by an ESLint rule); per-feature files behind the index.ts barrel.
  • safe-fetch.ts — the one documented outbound-egress entry (redirect: "manual" + timeout; optional connect-time DNS-rebinding pin). Raw fetch( under lib/ + app/ is banned by ESLint.
  • db.ts — the Prisma client singleton.
  • crypto.ts — AES-256-GCM at rest with versioned key ids, fail-closed loader, rotation primitives.

Subsystems

  • auth/ — Postgres sessions, secure-cookie flag policy, passkey (WebAuthn) + Argon2id password, per-device refresh-token rotation, HMAC Bearer tokens.
  • ai/ — multi-provider insight + Coach engine: provider-chain.ts, hand-rolled {openai,anthropic,local,codex,mock}-client.ts, coach/, prompts/, citation + confidence helpers.
  • rollups/ — DAY/WEEK/MONTH/YEAR pre-aggregations for measurements, mood, and medication compliance. Read-swap pattern: probe the rollup, fall back to live SQL on a coverage miss.
  • notifications/ — the dispatcher cascade (APNs → Telegram → ntfy → Web Push), per-channel senders/, retry policy, VAPID config.
  • jobs/ — pg-boss workers: reminders, insight pre-generation, backups, retention sweeps, integration backfills. Recurring work belongs here, not in scripts/.
  • integrations/, withings/, whoop/, fitbit/ — OAuth clients and sync services for the device providers; sync/ holds the shared delta-feed plumbing.
  • analytics/ — trend calculations, cadence-aware medication compliance.ts, correlations.
  • insights/, fhir/, doctor-report-*.ts — insight pipeline, FHIR R4 export, client-side doctor-report PDF.
  • openapi/ — Zod registry that is the source of truth for docs/api/openapi.yaml.
  • logging/, observability/, monitoring/ — Wide-Event transports and the central redaction denylists (redact at the egress boundary, not the call site).
  • validations/ — shared Zod schemas, including the SSRF isPublicUrl floor.
  • i18n/, tz/ + timezone.ts, format*.ts — translations, timezone helpers (Berlin for display, UTC in DB), locale formatting.

Conventions

Kebab-case filenames. See ../../CLAUDE.md "Code conventions" and "Security-relevant patterns"; the critical-files map there cites the exact entry points. Most modules carry tests in a sibling __tests__/.