mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-09 21:10:59 +00:00
Mathew Sims
08e535a0d9
The 15-minute reminder tick computed windowDuration ONCE per schedule as windowEnd - windowStart, then applied that SAME span to every timeOfDay slot in the schedule. For a single-dose schedule that span genuinely is the one slot's window, but for a multi-dose schedule (e.g. windowStart=08:00/windowEnd=18:00 with timesOfDay=[08:00,18:00]) it silently gave the 08:00 slot a 600-minute grace before even entering ORANGE phase — ten hours nobody configured — while an identically-intended single-dose schedule with a narrow legacy span (08:00-09:00) correctly escalated on schedule but then had only a 30-minute radius for a logged-but-late dose to suppress its reminder. Same misapplied field, opposite-looking symptoms: one medication silently never reminded, the other kept escalating despite being logged as taken. resolveSlotWindowDurationMinutes resolves each slot's duration independently, checked in priority order: an explicit per-dose doseWindows entry for that exact timeOfDay (the actual per-dose rule set in the dose-window editor) > the schedule's reminderGraceMinutes (documented for exactly this purpose but never actually read by the reminder tick until now — the write path already reads it via graceToleranceMs) > the same default an unconfigured "point" dose gets everywhere else in the app, bounded by the gap to the nearest sibling slot so two doses can never share a window. A single-dose schedule with neither override keeps the exact legacy windowEnd - windowStart behaviour, unchanged, for backward compatibility with schedules that predate the per-dose doseWindows system. The core property this restores: a dose's resolved window never depends on how many sibling doses share its schedule. Two identically-configured doses now resolve identically regardless of whether one of them happens to have a second dose elsewhere in the day. Full suite (18k+ tests) passes with no regressions; 13 new tests cover both real-world cases that surfaced this (a single 08:00-09:00 schedule and a twice-daily 08:00/18:00 one) plus the sibling- independence property directly.
src/lib/
The server and runtime toolkit. Everything that is not a page, component, or route handler lives here: the API kit, auth, crypto, the rollup tier, AI providers, notifications, background jobs, and the integration clients. Route handlers and RSC pages compose these modules; the modules never reach back into app/.
Core request kit
api-handler.ts— theapiHandlerwrapper every route uses. Auth resolver (cookie OR Bearer),requireAuth/requireAdmin(admin is cookie-only by construction), idempotency plumbing, Wide-Event builder, GlitchTip forwarder.api-response.ts— the{ data, error, meta? }envelope:apiSuccess/apiError,safeJson, trusted-proxy IP resolver,returnAllZodIssues+sanitiseZodIssues.rate-limit.ts— Postgres-backed sliding-window limiter (single atomic upsert); multi-instance correct.idempotency.ts— user-scoped idempotency keys that refuse to cache secret-shaped responses.query-keys/— the only legal source of TanStack QueryqueryKey/mutationKeyarrays (enforced by an ESLint rule); per-feature files behind theindex.tsbarrel.safe-fetch.ts— the one documented outbound-egress entry (redirect: "manual"+ timeout; optional connect-time DNS-rebinding pin). Rawfetch(underlib/+app/is banned by ESLint.db.ts— the Prisma client singleton.crypto.ts— AES-256-GCM at rest with versioned key ids, fail-closed loader, rotation primitives.
Subsystems
auth/— Postgres sessions, secure-cookie flag policy, passkey (WebAuthn) + Argon2id password, per-device refresh-token rotation, HMAC Bearer tokens.ai/— multi-provider insight + Coach engine:provider-chain.ts, hand-rolled{openai,anthropic,local,codex,mock}-client.ts,coach/,prompts/, citation + confidence helpers.rollups/— DAY/WEEK/MONTH/YEAR pre-aggregations for measurements, mood, and medication compliance. Read-swap pattern: probe the rollup, fall back to live SQL on a coverage miss.notifications/— the dispatcher cascade (APNs → Telegram → ntfy → Web Push), per-channelsenders/, retry policy, VAPID config.jobs/— pg-boss workers: reminders, insight pre-generation, backups, retention sweeps, integration backfills. Recurring work belongs here, not inscripts/.integrations/,withings/,whoop/,fitbit/— OAuth clients and sync services for the device providers;sync/holds the shared delta-feed plumbing.analytics/— trend calculations, cadence-aware medicationcompliance.ts, correlations.insights/,fhir/,doctor-report-*.ts— insight pipeline, FHIR R4 export, client-side doctor-report PDF.openapi/— Zod registry that is the source of truth fordocs/api/openapi.yaml.logging/,observability/,monitoring/— Wide-Event transports and the central redaction denylists (redact at the egress boundary, not the call site).validations/— shared Zod schemas, including the SSRFisPublicUrlfloor.i18n/,tz/+timezone.ts,format*.ts— translations, timezone helpers (Berlin for display, UTC in DB), locale formatting.
Conventions
Kebab-case filenames. See ../../CLAUDE.md "Code conventions" and "Security-relevant patterns"; the critical-files map there cites the exact entry points. Most modules carry tests in a sibling __tests__/.