fix(audit): fall back to city/country when ASN lookup misses

The carrier chip on the admin login-overview audit table was empty
whenever the offline GeoLite2-ASN MMDB had no entry for the IP. In
practice this is every IP behind a non-DACH or cloud-NAT range — the
free-tier MMDB carries DACH carriers densely but thins out
elsewhere — and the chip went blank even though the city + country
were already populated from the parallel location lookup.

When `entry.carrier` is null but `entry.location` is non-null,
render the chip with the city/country string and a "carrier
unavailable" qualifier. Private/loopback IPs still hide the chip
entirely (both columns null).
This commit is contained in:
Marc-André Bombeck committed 2026-05-17 12:41:34 +02:00
1 parent 0738ef50b0
commit fa0f544e3f
7 files changed
+33 -13

No files matched your search

+2 -1
View File
@@ -2445,7 +2445,8 @@
}
},
"carrier": "Anbieter",
"carrierUnknown": "Unbekannter Anbieter"
"carrierUnknown": "Unbekannter Anbieter",
"carrierUnavailableGeoFallback": "{location} — Anbieter nicht verfügbar"
},
"achievements": {
"title": "Erfolge",
+2 -1
View File
@@ -2445,7 +2445,8 @@
}
},
"carrier": "Carrier",
"carrierUnknown": "Unknown carrier"
"carrierUnknown": "Unknown carrier",
"carrierUnavailableGeoFallback": "{location} — carrier unavailable"
},
"achievements": {
"title": "Achievements",
+2 -1
View File
@@ -2445,7 +2445,8 @@
}
},
"carrier": "Operador",
"carrierUnknown": "Operador desconocido"
"carrierUnknown": "Operador desconocido",
"carrierUnavailableGeoFallback": "{location} — carrier unavailable"
},
"achievements": {
"title": "Achievements",
+2 -1
View File
@@ -2445,7 +2445,8 @@
}
},
"carrier": "Opérateur",
"carrierUnknown": "Opérateur inconnu"
"carrierUnknown": "Opérateur inconnu",
"carrierUnavailableGeoFallback": "{location} — carrier unavailable"
},
"achievements": {
"title": "Achievements",
+2 -1
View File
@@ -2445,7 +2445,8 @@
}
},
"carrier": "Operatore",
"carrierUnknown": "Operatore sconosciuto"
"carrierUnknown": "Operatore sconosciuto",
"carrierUnavailableGeoFallback": "{location} — carrier unavailable"
},
"achievements": {
"title": "Achievements",
+2 -1
View File
@@ -2445,7 +2445,8 @@
}
},
"carrier": "Operator",
"carrierUnknown": "Nieznany operator"
"carrierUnknown": "Nieznany operator",
"carrierUnavailableGeoFallback": "{location} — carrier unavailable"
},
"achievements": {
"title": "Achievements",
@@ -452,13 +452,17 @@ export function LoginOverviewSection() {
</span>
{/*
v1.4.27 B3 — carrier chip below the auth-provider
chip. Only renders when the GeoLite2-ASN lookup
found an organisation string for the audit-row's
IP; private/loopback IPs and offline-miss rows
keep the original single-chip layout. The chip
carries the short DACH label ("Telekom",
"Vodafone", "1&1", "O2"); unknown organisations
fall through to the raw GeoLite2 string.
chip. v1.4.36 W4g — fall back to the city + country
string with a "carrier unavailable" qualifier when
the GeoLite2-ASN offline lookup miss (free-tier
ipwho.is does not expose ASN) leaves `entry.carrier`
null but the location lookup populated
`entry.location`. Private/loopback IPs and offline-
miss rows on BOTH columns keep the original
single-chip layout. ASN-known chip carries the
short DACH label ("Telekom", "Vodafone", "1&1",
"O2") with unknown organisations falling through
to the raw GeoLite2 string.
*/}
{entry.carrier ? (
<span
@@ -467,6 +471,16 @@ export function LoginOverviewSection() {
>
{carrierShortLabel(entry.carrier)}
</span>
) : entry.location ? (
<span
className="text-muted-foreground/80 mt-0.5 block text-[10px] leading-tight"
data-slot="login-overview-carrier"
data-source="geo-fallback"
>
{t("admin.carrierUnavailableGeoFallback", {
location: entry.location,
})}
</span>
) : null}
</td>
<td className="text-muted-foreground px-3 py-2 font-mono text-xs">