tom/HealthLog
1
0 Fork 0
mirror of https://github.com/MBombeck/HealthLog.git synced 2026-11-11 13:52:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

style(planning): prettier sweep on reconcile + v1.4.19 backlog

Browse Source 
Whitespace + table alignment to keep the planning markdown
consistent with the rest of the tree.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Marc-André BombeckandClaude Opus 4.7 committed 2026-05-10 11:10:59 +02:00
1 parent 481403dc3d
commit c072ad8416
2 files changed
+15 -15
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

.planning/phase-D-reconcile-report.md
+13 -13
View File
@@ -33,18 +33,18 @@ guard the wire shape. Existing 53 gamification tests stay green.
## HIGH triage
| Finding | Source | Fix / Defer | Commit |
|---|---|---|---|
| H1 — chart-overlay-prefs R-M-W race | code-review | FIXED | `cf75579` |
| H2 — `useChartOverlayPrefs(chartKey ?? "bp")` waste | code-review | FIXED via simplify F2 | `720e6c8` |
| H3 — bug-buddy shared metric leak | code-review | AUTO-RESOLVED by C1 | `545f44c` |
| H4 — mood-window doc/code mismatch | code-review | FIXED (doc clarified) | `c6e3ac6` |
| H5 — consistentMonthCount unbounded | code-review | FIXED (capped at 1) | `c6e3ac6` |
| HIGH-1 — same as C1 | security | AUTO-RESOLVED by C1 | `545f44c` |
| HIGH-2 — i18n bundle leak | security | DEFERRED to v1.4.19 | bundle-strip needs build hook |
| H1 design — mood `chartKey="mood"` default | design | FIXED | `fbf14fc` |
| H2 design — cog 28x28 to 44x44 | design | FIXED | `194ec2f` |
| H3 design — mood-chart header `flex-wrap` | design | FIXED | `fbf14fc` |
| Finding | Source | Fix / Defer | Commit |
| --------------------------------------------------- | ----------- | --------------------- | ----------------------------- |
| H1 — chart-overlay-prefs R-M-W race | code-review | FIXED | `cf75579` |
| H2 — `useChartOverlayPrefs(chartKey ?? "bp")` waste | code-review | FIXED via simplify F2 | `720e6c8` |
| H3 — bug-buddy shared metric leak | code-review | AUTO-RESOLVED by C1 | `545f44c` |
| H4 — mood-window doc/code mismatch | code-review | FIXED (doc clarified) | `c6e3ac6` |
| H5 — consistentMonthCount unbounded | code-review | FIXED (capped at 1) | `c6e3ac6` |
| HIGH-1 — same as C1 | security | AUTO-RESOLVED by C1 | `545f44c` |
| HIGH-2 — i18n bundle leak | security | DEFERRED to v1.4.19 | bundle-strip needs build hook |
| H1 design — mood `chartKey="mood"` default | design | FIXED | `fbf14fc` |
| H2 design — cog 28x28 to 44x44 | design | FIXED | `194ec2f` |
| H3 design — mood-chart header `flex-wrap` | design | FIXED | `fbf14fc` |
8 of 10 HIGH fixed inline. 1 deferred (HIGH-2 security — i18n
bundle architectural change, doesn't fit reconcile scope). 1
@@ -59,7 +59,7 @@ safe suggestions`:
`chart-overlay-controls`; re-export the canonical pair from
`dashboard-layout`. Test imports updated.
- **F2** — `useChartOverlayPrefs(chartKey: ChartOverlayKey | null |
undefined)` short-circuits when no key is supplied.
undefined)` short-circuits when no key is supplied.
`health-chart` drops the three discard-the-result ternaries.
- **F3** — `/api/analytics` no longer pair-and-counts BP twice; the
windowed helper produces both the headline and the sub-values.
.planning/v1419-backlog.md
+2 -2
View File
@@ -22,7 +22,7 @@ Compiled: 2026-05-10.
an unlock fires, (2) reversible obfuscation (rot13/base64) decoded
client-side only when `unlocked === true`. Approach 1 is the v1.5
fix, approach 2 is the v1.4.19 stopgap. File: `src/lib/i18n/context.tsx:15-16`,
`messages/en.json` "achievements.badges.hidden*".
`messages/en.json` "achievements.badges.hidden\*".
## MED (deferred)
@@ -89,7 +89,7 @@ Compiled: 2026-05-10.
Resolved in v1.4.18 reconcile (commit `720e6c8`).
- **F3 senior-dev** — `src/lib/gamification/achievements.ts` (839
LOC) is at the watchpoint for a `definitions/ + evaluators/ +
utilities/` split. Defer until a 5th responsibility (cross-user
utilities/` split. Defer until a 5th responsibility (cross-user
leaderboard, server-side rules engine) lands.
- **F4 senior-dev** — `toBerlinDayKey()` reimplemented in
`src/lib/analytics/bp-in-target.ts` AND