mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-08 12:32:43 +00:00
Retire the guardian toggle over a pref nothing reads
The evidence disclosure stopped honouring showEvidenceByDefault in v1.4.27 and the owner surface retired the control with it — but the managed-record coach form still offered the switch, silently governing nothing. Remove the control, the managed-schema pick, the response field, and the label in all six locales; the strict schema now refuses the key outright.
This commit is contained in:
1 parent
15fb5dbbdb
commit
a45dde2039
10 files changed
+18
-17
No files matched your search
@@ -4719,7 +4719,6 @@
|
||||
"last30days": "Letzte 30 Tage",
|
||||
"last90days": "Letzte 90 Tage",
|
||||
"allTime": "Gesamter Zeitraum",
|
||||
"showEvidence": "Evidenz standardmäßig anzeigen",
|
||||
"excludedMetrics": "Ausgeschlossene Messwerte",
|
||||
"dataClusters": "Datenbereiche",
|
||||
"customClusters": "Eigene Auswahl von Datenbereichen verwenden",
|
||||
|
||||
@@ -4719,7 +4719,6 @@
|
||||
"last30days": "Last 30 days",
|
||||
"last90days": "Last 90 days",
|
||||
"allTime": "All time",
|
||||
"showEvidence": "Show evidence by default",
|
||||
"excludedMetrics": "Excluded metrics",
|
||||
"dataClusters": "Data clusters",
|
||||
"customClusters": "Use a custom cluster selection",
|
||||
|
||||
@@ -4719,7 +4719,6 @@
|
||||
"last30days": "Últimos 30 días",
|
||||
"last90days": "Últimos 90 días",
|
||||
"allTime": "Todo el tiempo",
|
||||
"showEvidence": "Mostrar evidencia de forma predeterminada",
|
||||
"excludedMetrics": "Métricas excluidas",
|
||||
"dataClusters": "Grupos de datos",
|
||||
"customClusters": "Usar una selección personalizada de grupos",
|
||||
|
||||
@@ -4719,7 +4719,6 @@
|
||||
"last30days": "30 derniers jours",
|
||||
"last90days": "90 derniers jours",
|
||||
"allTime": "Depuis toujours",
|
||||
"showEvidence": "Afficher les sources par défaut",
|
||||
"excludedMetrics": "Mesures exclues",
|
||||
"dataClusters": "Groupes de données",
|
||||
"customClusters": "Utiliser une sélection personnalisée de groupes",
|
||||
|
||||
@@ -4719,7 +4719,6 @@
|
||||
"last30days": "Ultimi 30 giorni",
|
||||
"last90days": "Ultimi 90 giorni",
|
||||
"allTime": "Tutto il periodo",
|
||||
"showEvidence": "Mostra le fonti per impostazione predefinita",
|
||||
"excludedMetrics": "Metriche escluse",
|
||||
"dataClusters": "Gruppi di dati",
|
||||
"customClusters": "Usa una selezione personalizzata di gruppi",
|
||||
|
||||
@@ -4719,7 +4719,6 @@
|
||||
"last30days": "Ostatnie 30 dni",
|
||||
"last90days": "Ostatnie 90 dni",
|
||||
"allTime": "Cały okres",
|
||||
"showEvidence": "Domyślnie pokazuj źródła",
|
||||
"excludedMetrics": "Wykluczone metryki",
|
||||
"dataClusters": "Grupy danych",
|
||||
"customClusters": "Użyj własnego wyboru grup",
|
||||
|
||||
@@ -82,7 +82,6 @@ describe("managed record settings configuration contract", () => {
|
||||
tone: "warm",
|
||||
verbosity: "default",
|
||||
excludeMetrics: [],
|
||||
showEvidenceByDefault: false,
|
||||
defaultWindow: "allTime",
|
||||
},
|
||||
},
|
||||
@@ -100,6 +99,24 @@ describe("managed record settings configuration contract", () => {
|
||||
expect(() => parseManagedRecordSettingsPatch(family, patch)).not.toThrow();
|
||||
});
|
||||
|
||||
// Watched red: re-adding `showEvidenceByDefault: true` to the managed
|
||||
// coach pick makes the strict schema accept the key again and this
|
||||
// fails. The evidence disclosure stopped honouring the flag in v1.4.27
|
||||
// (F14); a guardian toggle over a pref nothing reads is a dead control.
|
||||
it("refuses the retired showEvidenceByDefault pref", () => {
|
||||
expect(() =>
|
||||
parseManagedRecordSettingsPatch("coach", {
|
||||
preferences: {
|
||||
tone: "warm",
|
||||
verbosity: "default",
|
||||
excludeMetrics: [],
|
||||
defaultWindow: "allTime",
|
||||
showEvidenceByDefault: true,
|
||||
},
|
||||
}),
|
||||
).toThrow();
|
||||
});
|
||||
|
||||
it("uses the complete canonical module inventory for a fresh record", () => {
|
||||
expect(Object.keys(MANAGED_RECORD_SETTINGS_MODULE_DEFAULTS)).toEqual(
|
||||
WRITABLE_MODULE_KEYS,
|
||||
|
||||
@@ -139,7 +139,6 @@ export const GET = apiHandler(
|
||||
tone: preferences.tone,
|
||||
verbosity: preferences.verbosity,
|
||||
excludeMetrics: preferences.excludeMetrics,
|
||||
showEvidenceByDefault: preferences.showEvidenceByDefault,
|
||||
defaultWindow: preferences.defaultWindow,
|
||||
...(preferences.dataClusters !== undefined
|
||||
? { dataClusters: preferences.dataClusters }
|
||||
@@ -344,7 +343,6 @@ export const PATCH = apiHandler(
|
||||
tone: preferences.tone,
|
||||
verbosity: preferences.verbosity,
|
||||
excludeMetrics: preferences.excludeMetrics,
|
||||
showEvidenceByDefault: preferences.showEvidenceByDefault,
|
||||
defaultWindow: preferences.defaultWindow,
|
||||
...(preferences.dataClusters !== undefined
|
||||
? { dataClusters: preferences.dataClusters }
|
||||
|
||||
@@ -734,7 +734,6 @@ function CoachSettingsForm({
|
||||
excludeMetrics: COACH_EXCLUDE_METRICS.filter(
|
||||
(metric) => form.get(`exclude-${metric}`) === "on",
|
||||
),
|
||||
showEvidenceByDefault: form.get("showEvidenceByDefault") === "on",
|
||||
defaultWindow: asString(form.get("defaultWindow"), "allTime"),
|
||||
...(form.get("useCustomClusters") === "on"
|
||||
? {
|
||||
@@ -817,12 +816,6 @@ function CoachSettingsForm({
|
||||
</NativeSelect>
|
||||
</label>
|
||||
</div>
|
||||
<ManagedSwitchRow
|
||||
name="showEvidenceByDefault"
|
||||
label={t("settings.sharedRecord.managedSettings.coach.showEvidence")}
|
||||
defaultChecked={preferences.showEvidenceByDefault === true}
|
||||
disabled={disabled}
|
||||
/>
|
||||
<fieldset className="space-y-2">
|
||||
<legend className="text-sm font-medium">
|
||||
{t("settings.sharedRecord.managedSettings.coach.excludedMetrics")}
|
||||
|
||||
@@ -124,7 +124,6 @@ const managedCoachPreferencesSchema = coachPrefsSchema
|
||||
tone: true,
|
||||
verbosity: true,
|
||||
excludeMetrics: true,
|
||||
showEvidenceByDefault: true,
|
||||
defaultWindow: true,
|
||||
dataClusters: true,
|
||||
})
|
||||
|
||||
Reference in new issue
Block a user