mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 07:13:29 +00:00
chore(cleanup): retire AssistantDisabledNotice + dead settings.placeholder copy
Dead-code sweep flagged by the v1.4.33 menu audit. * AssistantDisabledNotice (src/components/insights/assistant-disabled-notice.tsx) was introduced in v1.4.31 for the operator-disabled assistant surface but never wired into a render site. The v1.4.28 retirement of the weekly-report + advisor card removed the planned host components. Delete the component, its SSR test, and the four locale strings it consumed (insights.briefingDisabledByOperator, insights.statusDisabledByOperator, insights.correlationsDisabledByOperator, insights.coach.disabledByOperator) from all six locale files. The AssistantDisabledError thrown by requireAssistantSurface() and the assistant.disabled.<surface> errorCode envelope stay — iOS clients read the errorCode to render an inline notice. * settings.sections.placeholder.coming_soon was an "until extraction lands" string for <SectionPlaceholder>. Every slug in SETTINGS_SECTION_SLUGS has had a matching component since v1.4.22 so the placeholder body is unreachable through the type system. The defensive component itself stays as a guard, but inherits the section's own description for the EmptyState body, retiring the dedicated locale key from all six locale files. Locale-integrity contract holds (parity check green across de, en, es, fr, it, pl). Comments in api-handler.ts and feature-flags/index.ts that referenced <AssistantDisabledNotice> are updated to describe the surface generically. Refs: .planning/round-v1433-audit-menu.md §6
This commit is contained in:
1 parent
d4a1679ec6
commit
99af530490
5 files changed
+11
-120
No files matched your search
@@ -169,8 +169,8 @@ export function apiHandler<T extends (...args: any[]) => Promise<Response>>(
|
||||
// envelope is locked per
|
||||
// `.planning/RESPONSE-TO-IOS-TEAM-2026-05-16.md` §3 R5.
|
||||
// Older iOS clients that don't know the errorCode surface
|
||||
// this as a generic 403; v1.4.31+ clients render the
|
||||
// `<AssistantDisabledNotice>` empty state.
|
||||
// this as a generic 403; v1.4.31+ clients can branch on the
|
||||
// errorCode to render an inline operator-disabled notice.
|
||||
evt.setError(error);
|
||||
response = NextResponse.json(
|
||||
{
|
||||
|
||||
Reference in new issue
Block a user