mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-10 21:32:18 +00:00
chore: drop personal names from comments and test fixtures
Comments referred to the maintainer by name, and a test fixture carried a full real name. Comments describe the behaviour; fixtures use placeholders.
This commit is contained in:
1 parent
146fcac079
commit
7b17ec819a
7 files changed
+14
-14
No files matched your search
@@ -295,7 +295,7 @@ export default function DashboardPageClient({
|
||||
const digestQuery = useDailyDigest(isAuthenticated);
|
||||
|
||||
// v1.29.1 — the v1.29.0 selected-score-ring cluster is removed from the web
|
||||
// hero (Marc, live-use: uneven, wasted tile space). The snapshot still
|
||||
// hero (live use: uneven, wasted tile space). The snapshot still
|
||||
// resolves `scoreRings` server-side for the iOS selection contract; the web
|
||||
// hero just no longer renders them, so no client-side ring ordering here.
|
||||
|
||||
|
||||
@@ -318,7 +318,7 @@ describe("<TodayHero>", () => {
|
||||
});
|
||||
|
||||
// v1.29.1 — the v1.29.0 selected-score-ring cluster was removed from the web
|
||||
// hero (Marc, live-use: uneven, wasted tile space). Only the main
|
||||
// hero (live use: uneven, wasted tile space). Only the main
|
||||
// health-score ring paints now; the cluster's data-slots are gone.
|
||||
it("renders no score-ring cluster — only the health-score ring", () => {
|
||||
const html = render(<TodayHero digest={digest()} />);
|
||||
|
||||
@@ -14,7 +14,7 @@
|
||||
* - the day's read: the health `ScoreRing` (`flat`, md) with its
|
||||
* server-computed band and an honest provisional/final face — a null
|
||||
* score paints the ring's own provisional state, never a zero;
|
||||
* - v1.29.1 (Marc, live-use): the v1.29.0 selected-score-ring cluster is
|
||||
* - v1.29.1 (live use): the v1.29.0 selected-score-ring cluster is
|
||||
* removed from the web hero — it read as uneven and wasted tile space.
|
||||
* The health `ScoreRing` is the hero's only ring now. The score-ring
|
||||
* SELECTION contract stays server-side (`selectedScoreRings` on the
|
||||
|
||||
@@ -5,7 +5,7 @@ import { join } from "node:path";
|
||||
/**
|
||||
* v1.28.52 (Documents R3) — "Ask the Coach" opens the REAL fenced coach
|
||||
* conversation in the shared SIDE DRAWER, scoped to the document, instead of a
|
||||
* full-page nav to `/coach?doc=<id>` (the v1.28.51 behaviour Marc corrected).
|
||||
* full-page nav to `/coach?doc=<id>` (the v1.28.51 behaviour, since corrected).
|
||||
*
|
||||
* The wiring is source-structural (the send-path fence itself is covered by the
|
||||
* coach-send-target unit tests — untouched here). These guards pin:
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import { beforeEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
/**
|
||||
* S8 — auto-stage lab facts after the auto-index job. Pins Marc's sign-off
|
||||
* S8 — auto-stage lab facts after the auto-index job. Pins the sign-off
|
||||
* (auto-STAGE, never auto-COMMIT), the double module gate, the reuse of the
|
||||
* auto-index consent gate, the "looks like a lab" heuristic, idempotency (a
|
||||
* non-STORED or already-staged document is left alone), and the guarded
|
||||
|
||||
@@ -5,7 +5,7 @@
|
||||
* document that LOOKS LIKE a lab result is run through the SAME inbound
|
||||
* extraction the manual "Extract" button uses — but the facts land PENDING for
|
||||
* the existing human-review screen. Nothing is committed here: the user still
|
||||
* taps one confirm before a value becomes a `LabResult`. Marc's sign-off is
|
||||
* taps one confirm before a value becomes a `LabResult`. The sign-off is
|
||||
* explicit — auto-STAGE, never auto-COMMIT.
|
||||
*
|
||||
* Gates (ALL must hold, otherwise the manual extract button is left untouched):
|
||||
|
||||
@@ -279,19 +279,19 @@ describe("buildCoachNudgePayload", () => {
|
||||
|
||||
it("opens the title with a localized morning greeting and the name", () => {
|
||||
const { title, body } = buildCoachNudgePayload("bp", "de", {
|
||||
name: "Marc",
|
||||
name: "Alex",
|
||||
openerSeed: 0,
|
||||
});
|
||||
expect(title).toBe("Guten Morgen, Marc");
|
||||
expect(title).toBe("Guten Morgen, Alex");
|
||||
expect(body.length).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
it("rotates to the casual opener on an odd seed", () => {
|
||||
const { title } = buildCoachNudgePayload("bp", "de", {
|
||||
name: "Marc",
|
||||
name: "Alex",
|
||||
openerSeed: 1,
|
||||
});
|
||||
expect(title).toBe("Hey Marc");
|
||||
expect(title).toBe("Hey Alex");
|
||||
});
|
||||
|
||||
it("drops the name from the greeting when none is given", () => {
|
||||
@@ -361,11 +361,11 @@ describe("resolveGreetingName", () => {
|
||||
it("prefers the display name's first token", () => {
|
||||
expect(
|
||||
resolveGreetingName({
|
||||
displayName: "Marc B.",
|
||||
fullName: "Marc Bombeck",
|
||||
username: "marc",
|
||||
displayName: "Alex B.",
|
||||
fullName: "Alex Example",
|
||||
username: "alex",
|
||||
}),
|
||||
).toBe("Marc");
|
||||
).toBe("Alex");
|
||||
});
|
||||
|
||||
it("falls back to the full name's given token", () => {
|
||||
|
||||
Reference in new issue
Block a user