fix(settings): show a read failure on the share-link list, not an empty state

The share-link query had no error or loading handling, so a failed read
collapsed to an empty list and rendered the "no active share links"
copy — on a clinical sharing surface a load failure was indistinguishable
from "you have shared nothing". Gate the list on the query state:
QueryErrorCard with retry on failure, a skeleton while loading, the lists
only once the data is in. The added test was watched fail first against
the old fall-through before this fix made it pass.
This commit is contained in:
Marc-André Bombeck committed 2026-08-09 04:03:09 +02:00
1 parent 6e3965146c
commit 53a463f11b
2 files changed
+242 -168

No files matched your search

@@ -0,0 +1,54 @@
/**
* A read failure on the owner share-link surface must not read as "no active
* links". `useQuery` is forced into its error state; the card has to render the
* `query-error-card` slot with a retry affordance and must never fall through
* to the empty-state copy — that fall-through is the §6-forbidden case a
* clinical sharing surface cannot afford (a failed read is indistinguishable
* from "you have shared nothing").
*
* SSR-static render, matching the sibling sharing-section test.
*/
import { describe, expect, it, vi } from "vitest";
import { renderToStaticMarkup } from "react-dom/server";
vi.mock("@/hooks/use-auth", () => ({
useAuth: () => ({
user: { id: "u1", role: "USER" },
isAuthenticated: true,
isLoading: false,
refetch: vi.fn(),
}),
}));
vi.mock("@tanstack/react-query", () => ({
useQuery: () => ({
data: undefined,
isError: true,
isLoading: false,
refetch: vi.fn(),
}),
useMutation: () => ({ mutate: vi.fn(), isPending: false }),
useQueryClient: () => ({ invalidateQueries: vi.fn() }),
}));
import { I18nProvider } from "@/lib/i18n/context";
import { SharingSection } from "../sharing-section";
function render() {
return renderToStaticMarkup(
<I18nProvider initialLocale="en">
<SharingSection />
</I18nProvider>,
);
}
describe("<SharingSection> — a read failure is honest, not empty", () => {
it("renders the query-error card with retry and never the empty state", () => {
const html = render();
expect(html).toContain('data-slot="query-error-card"');
expect(html).toContain('data-slot="query-error-retry"');
// The empty-state must not appear: a failed read is not "no active links".
expect(html).not.toContain('data-testid="share-active-empty"');
expect(html).not.toContain("No active share links");
});
});
+188 -168
View File
@@ -39,6 +39,8 @@ import {
import { Badge } from "@/components/ui/badge"; import { Badge } from "@/components/ui/badge";
import { Button } from "@/components/ui/button"; import { Button } from "@/components/ui/button";
import { EmptyState } from "@/components/ui/empty-state"; import { EmptyState } from "@/components/ui/empty-state";
import { QueryErrorCard } from "@/components/ui/query-error-card";
import { Skeleton } from "@/components/ui/skeleton";
import { SettingsCard } from "@/components/settings/settings-card"; import { SettingsCard } from "@/components/settings/settings-card";
import { SettingsCardHeader } from "@/components/settings/_card-header"; import { SettingsCardHeader } from "@/components/settings/_card-header";
import { import {
@@ -106,7 +108,12 @@ function ShareLinksCard() {
expiryDays: number; expiryDays: number;
} | null>(null); } | null>(null);
const { data: links } = useQuery({ const {
data: links,
isError,
isLoading,
refetch,
} = useQuery({
queryKey: queryKeys.shareLinks(), queryKey: queryKeys.shareLinks(),
queryFn: () => queryFn: () =>
apiGet<{ shareLinks: ShareLinkSummary[] }>("/api/share-links").then( apiGet<{ shareLinks: ShareLinkSummary[] }>("/api/share-links").then(
@@ -147,180 +154,193 @@ function ShareLinksCard() {
initialExpiryDays={prefill?.expiryDays} initialExpiryDays={prefill?.expiryDays}
/> />
<div className="space-y-2"> {isError ? (
<h3 className="text-sm font-medium"> // A read failure must not read as "no active links" on a clinical
{t("settings.sharing.activeTitle")} // sharing surface — that is the §6 fall-through this card must avoid.
</h3> <QueryErrorCard onRetry={() => refetch()} />
{activeLinks.length === 0 ? ( ) : isLoading ? (
<EmptyState <div className="space-y-2" data-testid="share-links-loading">
size="compact" <Skeleton className="h-24 w-full rounded-lg" />
data-testid="share-active-empty" <Skeleton className="h-24 w-full rounded-lg" />
title={t("settings.sharing.noActive")} </div>
/> ) : (
) : ( <>
<ul className="space-y-2" data-testid="share-active-list"> <div className="space-y-2">
{activeLinks.map((link) => ( <h3 className="text-sm font-medium">
<li {t("settings.sharing.activeTitle")}
key={link.id} </h3>
className="bg-muted/30 border-border space-y-2 rounded-lg border p-3" {activeLinks.length === 0 ? (
> <EmptyState
<div className="flex flex-wrap items-start justify-between gap-2"> size="compact"
<p className="min-w-0 flex-1 text-sm font-medium break-words"> data-testid="share-active-empty"
{link.label} title={t("settings.sharing.noActive")}
</p> />
<div className="flex flex-wrap items-center gap-1.5"> ) : (
<Badge className="bg-success/15 text-success text-xs"> <ul className="space-y-2" data-testid="share-active-list">
{t("settings.sharing.statusActive")} {activeLinks.map((link) => (
</Badge> <li
{link.protected && ( key={link.id}
<Badge className="bg-muted/30 border-border space-y-2 rounded-lg border p-3"
variant="outline" >
className="gap-1 text-xs" <div className="flex flex-wrap items-start justify-between gap-2">
data-testid="share-protected-badge" <p className="min-w-0 flex-1 text-sm font-medium break-words">
> {link.label}
<KeyRound className="h-2.5 w-2.5" /> </p>
{t("settings.sharing.protected")} <div className="flex flex-wrap items-center gap-1.5">
</Badge> <Badge className="bg-success/15 text-success text-xs">
)} {t("settings.sharing.statusActive")}
{link.documentCount > 0 && ( </Badge>
<Badge {link.protected && (
variant="outline" <Badge
className="gap-1 text-xs" variant="outline"
data-testid="share-doc-count-badge" className="gap-1 text-xs"
aria-label={t("settings.sharing.documentCount", { data-testid="share-protected-badge"
count: link.documentCount, >
})} <KeyRound className="h-2.5 w-2.5" />
> {t("settings.sharing.protected")}
<FileText className="h-2.5 w-2.5" /> </Badge>
{link.documentCount} )}
</Badge> {link.documentCount > 0 && (
)} <Badge
</div> variant="outline"
</div> className="gap-1 text-xs"
<p className="text-muted-foreground text-xs"> data-testid="share-doc-count-badge"
<span className="font-medium"> aria-label={t("settings.sharing.documentCount", {
{t("settings.sharing.created")}: count: link.documentCount,
</span>{" "} })}
{formatDate(link.createdAt)} >
</p> <FileText className="h-2.5 w-2.5" />
<p className="text-muted-foreground text-xs"> {link.documentCount}
<span className="font-medium"> </Badge>
{t("settings.sharing.expires")}: )}
</span>{" "} </div>
{formatDateTime(link.expiresAt)} </div>
</p> <p className="text-muted-foreground text-xs">
<p className="text-muted-foreground text-xs"> <span className="font-medium">
<span className="font-medium"> {t("settings.sharing.created")}:
{t("settings.sharing.accessCount")}: </span>{" "}
</span>{" "} {formatDate(link.createdAt)}
{link.accessCount}
{link.lastAccessAt
? ` · ${formatDateTime(link.lastAccessAt)}`
: ""}
</p>
<AlertDialog>
<AlertDialogTrigger asChild>
<Button
variant="destructive"
size="sm"
className="min-h-11 w-full sm:min-h-9"
>
<Trash2 className="mr-2 h-3.5 w-3.5" />
{t("settings.sharing.revoke")}
</Button>
</AlertDialogTrigger>
<AlertDialogContent>
<AlertDialogHeader>
<AlertDialogTitle>
{t("settings.sharing.revoke")}
</AlertDialogTitle>
<AlertDialogDescription>
{t("settings.sharing.revokeDescription")}
</AlertDialogDescription>
</AlertDialogHeader>
<AlertDialogFooter>
<AlertDialogCancel>
{t("common.cancel")}
</AlertDialogCancel>
<AlertDialogAction
onClick={() => revokeMutation.mutate(link.id)}
>
{t("settings.sharing.revoke")}
</AlertDialogAction>
</AlertDialogFooter>
</AlertDialogContent>
</AlertDialog>
</li>
))}
</ul>
)}
</div>
{inactiveLinks.length > 0 && (
<div className="space-y-2">
<button
type="button"
onClick={() => setShowRevoked((prev) => !prev)}
className="text-foreground hover:text-primary text-sm font-medium transition-colors"
>
{t("settings.sharing.inactiveTitle", {
count: inactiveLinks.length,
})}
</button>
{showRevoked && (
<ul className="space-y-2" data-testid="share-inactive-list">
{inactiveLinks.map((link) => (
<li
key={link.id}
className="bg-muted/20 border-border space-y-1.5 rounded-lg border p-3"
>
<div className="flex flex-wrap items-start justify-between gap-2">
<p className="min-w-0 flex-1 text-sm font-medium break-words">
{link.label}
</p> </p>
<Badge variant="secondary" className="text-xs"> <p className="text-muted-foreground text-xs">
{link.needsReselection <span className="font-medium">
? t("settings.sharing.statusNeedsReselect") {t("settings.sharing.expires")}:
: link.revokedAt </span>{" "}
? t("settings.sharing.statusRevoked") {formatDateTime(link.expiresAt)}
: t("settings.sharing.statusExpired")} </p>
</Badge> <p className="text-muted-foreground text-xs">
</div> <span className="font-medium">
{/* A link whose frozen scope predates the selection model. {t("settings.sharing.accessCount")}:
</span>{" "}
{link.accessCount}
{link.lastAccessAt
? ` · ${formatDateTime(link.lastAccessAt)}`
: ""}
</p>
<AlertDialog>
<AlertDialogTrigger asChild>
<Button
variant="destructive"
size="sm"
className="min-h-11 w-full sm:min-h-9"
>
<Trash2 className="mr-2 h-3.5 w-3.5" />
{t("settings.sharing.revoke")}
</Button>
</AlertDialogTrigger>
<AlertDialogContent>
<AlertDialogHeader>
<AlertDialogTitle>
{t("settings.sharing.revoke")}
</AlertDialogTitle>
<AlertDialogDescription>
{t("settings.sharing.revokeDescription")}
</AlertDialogDescription>
</AlertDialogHeader>
<AlertDialogFooter>
<AlertDialogCancel>
{t("common.cancel")}
</AlertDialogCancel>
<AlertDialogAction
onClick={() => revokeMutation.mutate(link.id)}
>
{t("settings.sharing.revoke")}
</AlertDialogAction>
</AlertDialogFooter>
</AlertDialogContent>
</AlertDialog>
</li>
))}
</ul>
)}
</div>
{inactiveLinks.length > 0 && (
<div className="space-y-2">
<button
type="button"
onClick={() => setShowRevoked((prev) => !prev)}
className="text-foreground hover:text-primary text-sm font-medium transition-colors"
>
{t("settings.sharing.inactiveTitle", {
count: inactiveLinks.length,
})}
</button>
{showRevoked && (
<ul className="space-y-2" data-testid="share-inactive-list">
{inactiveLinks.map((link) => (
<li
key={link.id}
className="bg-muted/20 border-border space-y-1.5 rounded-lg border p-3"
>
<div className="flex flex-wrap items-start justify-between gap-2">
<p className="min-w-0 flex-1 text-sm font-medium break-words">
{link.label}
</p>
<Badge variant="secondary" className="text-xs">
{link.needsReselection
? t("settings.sharing.statusNeedsReselect")
: link.revokedAt
? t("settings.sharing.statusRevoked")
: t("settings.sharing.statusExpired")}
</Badge>
</div>
{/* A link whose frozen scope predates the selection model.
It served a scope nobody chose, so it was closed; the It served a scope nobody chose, so it was closed; the
owner re-mints above with the label, window and expiry owner re-mints above with the label, window and expiry
still in front of them. */} still in front of them. */}
{link.needsReselection ? ( {link.needsReselection ? (
<div <div
className="space-y-1.5" className="space-y-1.5"
data-testid={`share-needs-reselect-${link.id}`} data-testid={`share-needs-reselect-${link.id}`}
> >
<p className="text-muted-foreground text-xs">
{t("settings.sharing.reselectReason")}
</p>
<Button
type="button"
variant="outline"
size="sm"
className="min-h-11 sm:min-h-9"
data-testid={`share-reselect-${link.id}`}
onClick={() => setPrefill(prefillFrom(link))}
>
{t("settings.sharing.reselectAction")}
</Button>
</div>
) : null}
<p className="text-muted-foreground text-xs"> <p className="text-muted-foreground text-xs">
{t("settings.sharing.reselectReason")} <span className="font-medium">
{t("settings.sharing.accessCount")}:
</span>{" "}
{link.accessCount}
</p> </p>
<Button </li>
type="button" ))}
variant="outline" </ul>
size="sm" )}
className="min-h-11 sm:min-h-9" </div>
data-testid={`share-reselect-${link.id}`}
onClick={() => setPrefill(prefillFrom(link))}
>
{t("settings.sharing.reselectAction")}
</Button>
</div>
) : null}
<p className="text-muted-foreground text-xs">
<span className="font-medium">
{t("settings.sharing.accessCount")}:
</span>{" "}
{link.accessCount}
</p>
</li>
))}
</ul>
)} )}
</div> </>
)} )}
</SettingsCard> </SettingsCard>
); );