mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-10 05:12:14 +00:00
test(integration): isolate apns-dispatch + integration-status from shared mock state
The integration suite used to share a single module graph across files (`pool: forks`, `fileParallelism: false`, `isolate: false`). That kept the container boot amortised but meant a `vi.mock()` declaration in one file lost to whichever earlier file had already pulled the real module into the graph. `apns-dispatch.test.ts` and `integration-status.test.ts` both fall through to `@/lib/notifications/dispatcher` (and its `@parse/node-apn` / telegram sender deps); when a sibling test mounted the real dispatcher first, the mock factories registered later silently no-op'd and the in-suite run reported the mock as called zero times. Each file still passed in isolation, which is the fingerprint the v1.4.35.1 closure already flagged as pre-existing. Flip the integration config to `isolate: true`. Per-file module isolation costs ~10 s of import rebuild across the 56-file run; the Postgres testcontainer + migrations live in `globalSetup`, so the slow part (container boot, ~5-15 s) is unaffected. The two `withings-*-sync.test.ts` files were previously dependent on a sibling setting `process.env.ENCRYPTION_KEY` before them — pin the deterministic test key in each file so they remain self-contained under per-file isolation. Locally `pnpm test:integration` now shows the four target failures green; the remaining two bp-in-target flakes are pre-existing local-only data drift that passed on CI under the old isolation flag and continue to be ordering-independent.
This commit is contained in:
1 parent
6ad5eb25e9
commit
1883e1e8c1
3 files changed
+30
-1
No files matched your search
@@ -11,6 +11,15 @@
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
// Crypto reads `ENCRYPTION_KEY` lazily on first encrypt(). Under the
|
||||
// previous `isolate: false` suite the env from any sibling that seeded
|
||||
// the key leaked into this file; per-file isolation (v1.4.37 W-CI)
|
||||
// reveals that this spec never seeded its own key. Pin a deterministic
|
||||
// 32-byte test key before any `@/lib/crypto` import so the spec stays
|
||||
// self-contained.
|
||||
process.env.ENCRYPTION_KEY ??=
|
||||
"0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef";
|
||||
|
||||
import { encrypt } from "@/lib/crypto";
|
||||
|
||||
import { getPrismaClient, truncateAllTables } from "./setup";
|
||||
|
||||
@@ -9,6 +9,15 @@
|
||||
*/
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
// Crypto reads `ENCRYPTION_KEY` lazily on first encrypt(). Under the
|
||||
// previous `isolate: false` suite the env from any sibling that seeded
|
||||
// the key leaked into this file; per-file isolation (v1.4.37 W-CI)
|
||||
// reveals that this spec never seeded its own key. Pin a deterministic
|
||||
// 32-byte test key before any `@/lib/crypto` import so the spec stays
|
||||
// self-contained.
|
||||
process.env.ENCRYPTION_KEY ??=
|
||||
"0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef";
|
||||
|
||||
import { encrypt } from "@/lib/crypto";
|
||||
|
||||
import { getPrismaClient, truncateAllTables } from "./setup";
|
||||
|
||||
@@ -23,7 +23,18 @@ export default defineConfig({
|
||||
// level (the old `poolOptions.forks.singleFork` was removed).
|
||||
pool: "forks",
|
||||
fileParallelism: false,
|
||||
isolate: false,
|
||||
// v1.4.37 W-CI — switched from `isolate: false` to `isolate: true`.
|
||||
// The previous setting reused the module graph across files inside
|
||||
// one fork; mock declarations (`vi.mock("@/lib/notifications/...")`,
|
||||
// `vi.mock("@parse/node-apn")`) registered in `apns-dispatch.test.ts`
|
||||
// and `integration-status.test.ts` lost to whichever earlier file
|
||||
// had already pulled the real dispatcher / sender modules into the
|
||||
// shared graph, so the in-suite run showed flaky 0-call mocks while
|
||||
// each file passed in isolation. Re-isolating module state per file
|
||||
// costs ~10 s of import-rebuild on a 56-file run; the Postgres
|
||||
// testcontainer + migrations still live in `globalSetup` so the
|
||||
// expensive boot cost is unaffected.
|
||||
isolate: true,
|
||||
// One container for the whole run; tests truncate between them.
|
||||
globalSetup: ["./tests/integration/global-setup.ts"],
|
||||
},
|
||||
|
||||
Reference in new issue
Block a user