From 6794533830516be4524fb21045772535fcf6d150 Mon Sep 17 00:00:00 2001 From: Steffen Becker Date: Sun, 6 Sep 2026 19:44:26 +0200 Subject: [PATCH] ci: LibreOffice builds formula objects, and node strips the TS import MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit libreoffice-writer alone has no Math component, so Writer dropped every formula it imported — Word's own OMML included — and the fuzz leg saw the loss. node 20 cannot import tests/schemaValidate.ts, which the monkey run does; 24 strips the types. node 20 is end of life anyway. --- .github/workflows/ci.yml | 11 ++++++----- .github/workflows/deploy.yml | 2 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1eccf73..5cbbce2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: || { echo "a test reads the gitignored parity corpus"; exit 1; } - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: npm - run: npm ci - run: npm run check @@ -38,10 +38,11 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: npm - # poppler-utils rasterizes the PDFs the render-consistency leg compares. - - run: sudo apt-get update && sudo apt-get install -y --no-install-recommends libreoffice-writer fonts-liberation poppler-utils + # libreoffice-math builds the formula objects both importers read back (without it + # Writer drops every formula); poppler-utils rasterizes the render-consistency PDFs. + - run: sudo apt-get update && sudo apt-get install -y --no-install-recommends libreoffice-writer libreoffice-math fonts-liberation poppler-utils - run: npm ci - run: npm run test:lo - run: npx playwright-core install --with-deps chromium @@ -65,7 +66,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: npm - run: npm ci - run: npx playwright-core install --with-deps ${{ matrix.browser }} diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index f981b20..c30ddc1 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -27,7 +27,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 cache: npm - run: npm ci - run: npm run build