mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-09 04:50:59 +00:00
Marc-André BombeckandClaude Opus 4.7
46e686f396
Three orthogonal fixes that account for most of the e2e suite's ongoing red: - The `chromium-mobile` project was actually iPhone 13 (webkit) — CI's `playwright install chromium` therefore could not launch it (`webkit-2272/pw_run.sh` does not exist). Renaming-to-Pixel-5 makes the project name match what the runner provides without expanding the install footprint. - `locale-switch.spec.ts` tried to anchor the cookie at `page.url()`, which on a fresh context is `about:blank`; Playwright rejected the cookie outright. Using the project's configured baseURL is the documented way and works regardless of navigation timing. - `login.spec.ts` looked for the username/password inputs immediately after navigation, but the password form is mounted lazily once the user clicks "Login with password" (passkey is the default mode). A small helper now opens the form before the assertions run. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
55 lines
2.0 KiB
TypeScript
55 lines
2.0 KiB
TypeScript
import { expect, test } from "@playwright/test";
|
|
|
|
/**
|
|
* Locale-key drift smoke check — switch the cookie between EN and DE
|
|
* and assert the login page (the only public surface that's translated)
|
|
* never shows raw i18n keys like `auth.welcomeBack`.
|
|
*
|
|
* Drift catches: a typo'd t("foo.bar") with no key in either locale
|
|
* file would make the raw key surface in the DOM. messages/de.json and
|
|
* messages/en.json key parity is enforced by unit tests; this is the
|
|
* runtime cousin.
|
|
*/
|
|
test.describe("locale switch", () => {
|
|
for (const locale of ["en", "de"] as const) {
|
|
test(`renders /auth/login in ${locale} without raw i18n keys`, async ({
|
|
page,
|
|
context,
|
|
}) => {
|
|
// Cookies must be addressable to a real origin — `page.url()` on
|
|
// a fresh context returns `about:blank`, which Playwright rejects.
|
|
// Anchor at the configured base URL explicitly.
|
|
const baseURL =
|
|
test.info().project.use.baseURL ?? "http://localhost:3000";
|
|
await context.addCookies([
|
|
{
|
|
name: "healthlog_locale",
|
|
value: locale,
|
|
url: baseURL,
|
|
},
|
|
]);
|
|
await page.goto("/auth/login");
|
|
|
|
const bodyText = await page.locator("body").innerText();
|
|
|
|
// i18n keys look like `section.subkey` — letters, numbers,
|
|
// underscores, dots — and are never wrapped in normal sentences,
|
|
// so a regex match anywhere in body text is a sign the lookup
|
|
// fell through.
|
|
const rawKeyPattern = /\b[a-z]+(?:[A-Z][a-z]+)?\.[a-z][A-Za-z0-9_.]+\b/;
|
|
const match = bodyText.match(rawKeyPattern);
|
|
|
|
// Whitelist: filenames or version strings can look like keys,
|
|
// skip those by requiring at least one camelCase segment.
|
|
if (match) {
|
|
const candidate = match[0];
|
|
const looksLikeKey = /\.[a-z][A-Z]/.test(candidate);
|
|
expect(
|
|
looksLikeKey,
|
|
`Possible raw i18n key in ${locale}: ${candidate}`,
|
|
).toBe(false);
|
|
}
|
|
});
|
|
}
|
|
});
|