mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-09 04:50:59 +00:00
Bundles the deferred v1.4.47 Mediums + Lows with the v1.4.48-deferred items into a single release. Headline: server-side suppression of MEDICATION_REMINDER APNs for iOS clients that own their local reminders (closes GH #206), a push_attempts table backing /api/admin/notifications/diagnostic, and a sweep of v1.4.48 QA forward-findings. Performance (the user-visible win): - /api/analytics cold-fallback path splits the heavy single-statement aggregate into two parallel queries. The linearly composable columns (count / min / max / mean) keep the full-partition scan; the windowed 7 / 30 / 90-day avg / slope / r² columns take a 90-day outer cap so the planner does an index range scan on (user_id, type, measured_at) instead of a full-partition sequential scan. Output is bit-identical; cold slim slice drops from multi-second to sub-second on tenants with large measurement partitions. Server-side notifications: - GET + PATCH /api/auth/me/notification-prefs with deep-merge semantics. Initial category medication.clientManaged: boolean (default false). Cron medicationReminderJob skips dose-due APNs when the flag is true, emitting a medication_reminder.suppressed_client_managed wide-event annotation per skip. - push_attempts table backs the diagnostic endpoint. Every APNS / Web-Push / Telegram / NTFY sender writes a fire-and-forget row. Daily 03:35 Europe/Berlin cleanup prunes rows older than 90 days. - /api/admin/notifications/diagnostic — admin-only endpoint surfacing device APNs token presence (masked), channel config presence, and recent push attempts. Registered in OpenAPI. - Per-channel APNs "Send test" button now fires with eventType: "MEDICATION_REMINDER" so the dispatcher's time-sensitive + priority-10 branch runs. A successful self-test now exercises the exact path production reminders take; an unsuccessful one points the user at iOS Settings → Time Sensitive Notifications rather than appearing to be a server-side bug. Withings reliability: - OAuth callback consumes the nonce atomically (delete-first with P2025 catch for the replay branch). The previous read-then-delete pattern allowed a race between two concurrent callbacks. - ?reason=state redirect differentiated into csrf1 / replay / expired / cross_user so operators can tell mismatch types apart without DB shell access. - connect endpoint rate-limited to 10/60s/user; row-create failures redirect to a consistent error surface. Observability hardening: - redactSensitiveFields(body) denylist helper covers password / token / secret / apiKey / authorization / csrfState / nonce, recursive, case-insensitive. Caught: /api/devices invalid_format issues were echoing apnsToken values verbatim into the audit log. - sanitiseZodIssues(issues, { stripValuesFromMessage: true }) overload applied to 14 audit-log sites. Migrations: 0079 (notification_prefs), 0080 (push_attempts). Tests: 4815 → 5272 unit + integration. Workout-batch integration suite that had been red on main since v1.4.45 (three release commits shipped through it) now green again — updated to match v1.4.42 cross-source dedup semantics. Resolves PR #207.
105 lines
3.9 KiB
TypeScript
105 lines
3.9 KiB
TypeScript
"use client";
|
|
|
|
import { useQuery } from "@tanstack/react-query";
|
|
|
|
import { queryKeys } from "@/lib/query-keys";
|
|
import { useQueryClientMounted } from "@/hooks/_internal/use-query-client-safe";
|
|
|
|
/**
|
|
* v1.4.31 — Client-side accessor for the operator's assistant
|
|
* feature-flag matrix. Mirrors `GET /api/feature-flags`'s response
|
|
* shape directly so callers can rely on a typed structure.
|
|
*
|
|
* The matrix gates every assistant-driven surface on the web —
|
|
* Coach + chat, Daily Briefing, per-metric status cards, correlation
|
|
* narration, Health-Score delta explainer. iOS reads the same
|
|
* endpoint and uses the same matrix; the contract is locked per
|
|
* `.planning/RESPONSE-TO-IOS-TEAM-2026-05-16.md` §3 R5.
|
|
*/
|
|
|
|
export interface AssistantFlagSet {
|
|
/** Master kill-switch — when false, every sub-flag is forced false. */
|
|
enabled: boolean;
|
|
/** Coach drawer, chat SSE, history rail, FAB. */
|
|
coach: boolean;
|
|
/** Daily Briefing card + advisor recommendations + regen icon. */
|
|
briefing: boolean;
|
|
/** Per-metric status cards on every `/insights/<metric>` sub-page. */
|
|
insightStatus: boolean;
|
|
/** Correlation narration tile on the mother page. */
|
|
correlations: boolean;
|
|
/** `?` glyph that opens the Health-Score delta explainer popover. */
|
|
healthScoreExplainer: boolean;
|
|
}
|
|
|
|
interface FeatureFlagsPayload {
|
|
assistant: AssistantFlagSet;
|
|
}
|
|
|
|
/** All-on default — matches the v1.4.30 behaviour for fresh installs. */
|
|
export const DEFAULT_ASSISTANT_FLAGS: AssistantFlagSet = Object.freeze({
|
|
enabled: true,
|
|
coach: true,
|
|
briefing: true,
|
|
insightStatus: true,
|
|
correlations: true,
|
|
healthScoreExplainer: true,
|
|
});
|
|
|
|
async function fetchFeatureFlags(): Promise<FeatureFlagsPayload> {
|
|
const res = await fetch("/api/feature-flags");
|
|
if (!res.ok) {
|
|
// Soft-fail: any HTTP error returns the all-on default so the
|
|
// surface continues to render. The endpoint is a non-critical
|
|
// metadata read; a 5xx must not turn into a "Coach hidden"
|
|
// false negative for the user.
|
|
return { assistant: { ...DEFAULT_ASSISTANT_FLAGS } };
|
|
}
|
|
const json = (await res.json()) as { data: FeatureFlagsPayload };
|
|
return json.data;
|
|
}
|
|
|
|
/**
|
|
* Read the operator's assistant feature-flag matrix.
|
|
*
|
|
* `staleTime: 60_000` matches the server-side cache header so the
|
|
* hot /insights mount path doesn't re-fetch the matrix on every
|
|
* remount within a minute. The hook fails open — any network error
|
|
* returns the all-on default so the user keeps seeing the surface.
|
|
*
|
|
* The hook is referenced from a long tail of legacy presentational
|
|
* components (`<InsightStatusCard>`, `<HealthScoreDeltaExplainer>`)
|
|
* whose unit tests render the component without a
|
|
* `<QueryClientProvider>`. To keep those tests valid we delegate
|
|
* the React-Query call to a child hook that's only invoked when a
|
|
* client is mounted. The branch is stable across the component's
|
|
* lifetime — `QueryClientProvider` placement never flips between
|
|
* renders — so the conditional hook call is safe per the Rules of
|
|
* Hooks (same posture the React docs document for "different
|
|
* environments where the same component renders").
|
|
*
|
|
* v1.4.48 M4 — the SSR-mount probe is shared with `useDisableCoach`
|
|
* via `_internal/use-query-client-safe` so the eslint-disable line
|
|
* stays in exactly one place per consumer.
|
|
*/
|
|
export function useFeatureFlags(): AssistantFlagSet {
|
|
const hasClient = useQueryClientMounted();
|
|
if (!hasClient) return DEFAULT_ASSISTANT_FLAGS;
|
|
// eslint-disable-next-line react-hooks/rules-of-hooks
|
|
return useFeatureFlagsQuery();
|
|
}
|
|
|
|
function useFeatureFlagsQuery(): AssistantFlagSet {
|
|
const query = useQuery({
|
|
queryKey: queryKeys.featureFlags(),
|
|
queryFn: fetchFeatureFlags,
|
|
staleTime: 60_000,
|
|
gcTime: 300_000,
|
|
retry: 0,
|
|
});
|
|
|
|
// While loading or on error, default to all-on so the assistant
|
|
// surfaces don't flicker out and back in.
|
|
return query.data?.assistant ?? DEFAULT_ASSISTANT_FLAGS;
|
|
}
|