mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-17 07:42:23 +00:00
The onboarding "Connect Withings" tap opened /api/withings/connect in a new tab, which returned a raw JSON 400 for every brand-new account (Withings credentials are per-user BYO with no env fallback, and the wizard never collects them). WHOOP, Fitbit, Polar, Oura, and Strava shared the identical raw-JSON-on-no-creds pattern on their own /connect routes, while every other failure branch already redirected with a toast reason. All six now redirect to /settings/integrations?<provider>=error&reason=nocreds instead, and the wizard's Withings card checks the integrations-status envelope first: unless credentials are already configured, the CTA reads "Set up in Settings" and links straight to the credentials form rather than launching a doomed OAuth handshake. Also surfaces the BYO-developer-app requirement, which was invisible until a user was deep inside a Settings card. The source-picker step now says up front that device sources need a free developer app on the user's own account; each of the six provider cards gets a compact 3-step guide with the exact callback URL to register, shown until the user has saved their own credentials.
92 lines
2.7 KiB
TypeScript
92 lines
2.7 KiB
TypeScript
import { describe, it, expect, vi } from "vitest";
|
|
import { renderToStaticMarkup } from "react-dom/server";
|
|
|
|
import { I18nProvider } from "@/lib/i18n/context";
|
|
|
|
/**
|
|
* v1.29.x — UX audit H1: the wizard's Withings card must not launch an
|
|
* OAuth handshake that can only 400 for a brand-new account (Withings
|
|
* credentials are per-user BYO with no env fallback). The card reads the
|
|
* consolidated integrations-status envelope and swaps its CTA + href
|
|
* depending on whether the account already has its own credentials saved.
|
|
*/
|
|
|
|
const integrationStatusState = vi.hoisted(() => ({
|
|
data: undefined as
|
|
| {
|
|
threshold: number;
|
|
integrations: Array<{ integration: string; configured?: boolean }>;
|
|
}
|
|
| undefined,
|
|
}));
|
|
|
|
vi.mock("@tanstack/react-query", () => ({
|
|
useQuery: () => ({ data: integrationStatusState.data }),
|
|
useQueryClient: () => ({ invalidateQueries: vi.fn() }),
|
|
}));
|
|
|
|
vi.mock("@/hooks/use-auth", () => ({
|
|
useAuth: () => ({ isAuthenticated: true }),
|
|
}));
|
|
|
|
vi.mock("next/navigation", () => ({
|
|
useRouter: () => ({ push: vi.fn(), replace: vi.fn() }),
|
|
}));
|
|
|
|
vi.mock("next/link", () => ({
|
|
default: ({
|
|
href,
|
|
children,
|
|
...rest
|
|
}: {
|
|
href: string;
|
|
children: React.ReactNode;
|
|
}) => (
|
|
<a href={href} {...rest}>
|
|
{children}
|
|
</a>
|
|
),
|
|
}));
|
|
|
|
import { SourceCardGrid } from "../source-card-grid";
|
|
|
|
function render() {
|
|
return renderToStaticMarkup(
|
|
<I18nProvider initialLocale="en">
|
|
<SourceCardGrid />
|
|
</I18nProvider>,
|
|
);
|
|
}
|
|
|
|
describe("<SourceCardGrid> Withings card", () => {
|
|
it("points at Settings instead of launching OAuth when unconfigured", () => {
|
|
integrationStatusState.data = {
|
|
threshold: 3,
|
|
integrations: [{ integration: "withings", configured: false }],
|
|
};
|
|
const html = render();
|
|
expect(html).toContain('data-testid="source-card-withings-setup"');
|
|
expect(html).toContain('href="/settings/integrations#withings"');
|
|
expect(html).not.toContain('href="/api/withings/connect"');
|
|
expect(html).toContain("Set up in Settings");
|
|
});
|
|
|
|
it("also redirects to Settings when the status envelope hasn't loaded yet", () => {
|
|
integrationStatusState.data = undefined;
|
|
const html = render();
|
|
expect(html).toContain('href="/settings/integrations#withings"');
|
|
expect(html).not.toContain('href="/api/withings/connect"');
|
|
});
|
|
|
|
it("opens the real OAuth connect flow once credentials are configured", () => {
|
|
integrationStatusState.data = {
|
|
threshold: 3,
|
|
integrations: [{ integration: "withings", configured: true }],
|
|
};
|
|
const html = render();
|
|
expect(html).toContain('href="/api/withings/connect"');
|
|
expect(html).not.toContain('data-testid="source-card-withings-setup"');
|
|
expect(html).toContain("Connect Withings");
|
|
});
|
|
});
|