mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-17 23:52:24 +00:00
Vitest's --shard cut the file list into slices of equal length, which gave the integration shards 954 s to 1 449 s. A sequencer now deals files out by their measured duration, plus a fixed per-file cost for import and setup, longest first to the shard with the least work, and starts the longest files first inside a shard. Timings live in tests/durations/*.json and are regenerated from Vitest JSON reports with scripts/test-durations.mjs; every CI shard uploads its report. Integration shards run three workers each, one cloned database per worker. The unit suite runs as three projects decided per file from its source: guards and unit share a module graph inside a worker, isolated keeps a fresh one for every file that mocks, spies, stubs or resets. In CI it is three duration-balanced shards next to a job for lint, format, types and the OpenAPI drift check. The required check names stay as they were. "Lint, Typecheck & Test" is now the job that answers for the static checks and every unit shard, the way "integration" already answers for its shards. The browser-install guard recognises a direct, flags-only vitest run as a run of the unit suite.
66 lines
2.9 KiB
TypeScript
66 lines
2.9 KiB
TypeScript
/**
|
|
* Every job that runs the unit suite installs the browser the suite needs.
|
|
*
|
|
* `health-score-card-geometry.test.tsx` renders the real hero band in a real
|
|
* Chromium and measures the boxes. It used to catch its own launch failure and
|
|
* pass, so for months it measured nothing in CI; since v1.38 it throws when
|
|
* `CI` is set instead, which is right — and which turns a job that runs
|
|
* `pnpm test` without a browser from silently useless into loudly red.
|
|
*
|
|
* That is exactly what happened. The install step was added to the quality job
|
|
* in `security.yml` and nowhere else, and `dependabot-auto-merge.yml` runs the
|
|
* same suite: every dependency bump failed on a launch error that said nothing
|
|
* about the bump. One workflow was fixed, one class was not.
|
|
*
|
|
* The sweep is textual and file-scoped, which is its limit: a workflow with two
|
|
* jobs, only one of which installs the browser, satisfies it. It catches the
|
|
* thing that actually went wrong — a whole workflow running the suite with no
|
|
* browser anywhere in it.
|
|
*/
|
|
import { describe, it, expect } from "vitest";
|
|
import { readFileSync, readdirSync } from "node:fs";
|
|
import { join } from "node:path";
|
|
|
|
const WORKFLOWS = join(process.cwd(), ".github", "workflows");
|
|
|
|
/**
|
|
* `run: pnpm test`, or a direct `vitest run` of the unit config with flags
|
|
* only (the sharded CI job, the nightly shuffled run): the whole unit suite
|
|
* or a slice of it, geometry check included. A run that names a path or
|
|
* another `--config` is a different, narrower suite and does not count.
|
|
*/
|
|
const RUNS_UNIT_SUITE =
|
|
/^\s*(?:-\s*)?run:\s*pnpm test\s*$|pnpm exec vitest run(?![^\n]*--config)(?=\s*$|\s+--)/m;
|
|
const INSTALLS_BROWSER = /playwright install --only-shell chromium/;
|
|
|
|
describe("the browser the unit suite measures with", () => {
|
|
it("is installed by every workflow that runs the suite", () => {
|
|
const files = readdirSync(WORKFLOWS).filter((f) => f.endsWith(".yml"));
|
|
expect(
|
|
files.length,
|
|
"no workflow files found — the walk is broken, not the tree clean",
|
|
).toBeGreaterThanOrEqual(5);
|
|
|
|
const runners = files.filter((f) =>
|
|
RUNS_UNIT_SUITE.test(readFileSync(join(WORKFLOWS, f), "utf8")),
|
|
);
|
|
// An empty match set would agree with an empty violation list. It is two
|
|
// workflows today; pinned at one so removing a job is not a guard failure,
|
|
// but a matcher that stops matching is.
|
|
expect(
|
|
runners.length,
|
|
"no workflow runs `pnpm test` — the matcher stopped matching",
|
|
).toBeGreaterThanOrEqual(1);
|
|
|
|
const missing = runners.filter(
|
|
(f) => !INSTALLS_BROWSER.test(readFileSync(join(WORKFLOWS, f), "utf8")),
|
|
);
|
|
expect(
|
|
missing,
|
|
"a workflow runs the unit suite without installing the headless " +
|
|
"Chromium the hero-geometry check measures with — that check refuses " +
|
|
"to skip under CI, so the job fails on a launch error instead",
|
|
).toEqual([]);
|
|
});
|
|
});
|