mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-08 12:32:43 +00:00
Marc-André Bombeck
6ac3a61829
A GET must not have side effects — api-handler.ts says so next to READ_HTTP_METHODS, where an MCP-audience token is admitted on the safe methods precisely because they are assumed to write nothing. Three routes broke that: the sync handshake bumped User.lastSyncedAt, the achievements read inserted unlock rows, and the cycle calendar fired a discarded promise at the forecast cache so a failed write left no trace anywhere. Each write moves to the place that causes it. The sync checkpoint is now stamped by the batch ingest endpoints for measurements, mood and intakes. The handshake reports it. That also fixes the watermark: the checkpoint used to advance past a window the client had not drained, and a client trusting it would skip that window. It can only trail a real sync now. The unlock rows move to a nightly achievement-unlock-sweep. The badge grid never needed them — unlocked comes from the live metrics and the completion date is derived — so the payload is unchanged; the rows pin that date and carry it into the backup, and the sweep reaches accounts that never open the page. The cycle forecast moves to a nightly cycle-prediction-refresh. The CyclePrediction row is not a cache of a read: it is the index the reminder cron scans, so which reminders an account received depended on whether somebody had opened the calendar. persistPredictionCache no longer swallows its errors either — the job reports them.
34 lines
1.3 KiB
TypeScript
34 lines
1.3 KiB
TypeScript
/**
|
|
* The SyncMode checkpoint — `User.lastSyncedAt`.
|
|
*
|
|
* One writer contract: the checkpoint is stamped by the client-push ingest
|
|
* boundaries (the measurement / mood / intake batch endpoints), never by the
|
|
* handshake that reports it. `GET /api/sync/state` is the only reader, so the
|
|
* column has to describe a sync that actually moved data rather than the fact
|
|
* that a client asked what the server knows.
|
|
*
|
|
* Stamping it on the handshake was also unsafe in exactly the watermark sense
|
|
* the provider pipelines already guard against (`sync-measure-watermark`,
|
|
* `sync-dead-token`): it advanced the checkpoint past a window the client had
|
|
* not drained yet, and a client that trusts the checkpoint then skips that
|
|
* window. Under-advancing a watermark costs a redundant fetch; over-advancing
|
|
* loses rows. Stamped here, the checkpoint can only ever trail the truth.
|
|
*/
|
|
import { prisma } from "@/lib/db";
|
|
import { annotate } from "@/lib/logging/context";
|
|
|
|
/**
|
|
* Stamp `User.lastSyncedAt`. Call from an ingest boundary once the batch has
|
|
* reached a durable verdict — never from a read.
|
|
*/
|
|
export async function markSyncCheckpoint(
|
|
userId: string,
|
|
at: Date = new Date(),
|
|
): Promise<void> {
|
|
await prisma.user.update({
|
|
where: { id: userId },
|
|
data: { lastSyncedAt: at },
|
|
});
|
|
annotate({ meta: { sync_checkpoint_at: at.toISOString() } });
|
|
}
|