mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-09 21:10:59 +00:00
A numeric lab reading was stored with its value as received and the marker's unit stamped on it, so 5.6 mmol/L against a marker kept in mg/dL became 5.6 mg/dL and read as far below range. Both the manual/API write and the scan commit did this; nothing compared the two units. - POST /api/labs returns 422 labs.unit.mismatch, with the marker's unit and the reading's unit in meta, and writes nothing. The unit is compared only when one was sent: on the biomarkerId path it may be omitted, and the marker's unit is then the stated one. A qualitative reading has no unit. - The scan commit skips such a row with reason unit_mismatch, so the outcome reads partial or failed instead of a clean save, and the toast names the analytes concerned rather than saying "duplicates". - The extract response carries the matched marker's unit. The review screen shows a calm badge on a row in another unit, starts it unticked like a duplicate, and treats it as a blocking error on the unit field if it is ticked anyway. - A small lab-specific normaliser forgives spelling only: spacing, the micro prefix, the case of the litre, and a unit printed in capitals for a short list where capitals cannot mean another unit. Case is otherwise significant, so mIU/L and MIU/L, or g/L and G/L, are never merged. The document-commit path already refuses a mismatch and is left as it is. Readings stored wrongly before this cannot be identified, because the original unit was never kept; they are not touched. Adds EN and DE strings; the other locales are left to the maintainers. The OpenAPI spec and the error-code catalogue carry the new code. Fixes #1094
284 lines
8.6 KiB
TypeScript
284 lines
8.6 KiB
TypeScript
/**
|
|
* A reading may only be stored under the unit it is actually in.
|
|
*
|
|
* Before this, a reading that stated another unit than its marker's (5.6
|
|
* mmol/L against a marker kept in mg/dL) was written with its value unchanged
|
|
* and the marker's unit stamped on it, and the range check then judged 5.6
|
|
* against a mg/dL band. These tests follow that reading through the real
|
|
* routes and the real database, and assert both what is refused and what is
|
|
* not: a different spelling of the same unit, a qualitative reading, a
|
|
* reading with no unit on the structured path and a brand-new marker must all
|
|
* still write.
|
|
*/
|
|
import { NextRequest } from "next/server";
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
import { cookieJar } from "./mock-next-headers";
|
|
import { getPrismaClient, truncateAllTables } from "./setup";
|
|
|
|
const USER_ID = "user-lab-unit-mismatch";
|
|
|
|
vi.mock("next/headers", async () => {
|
|
const { cookieJar, headerJar } = await import("./mock-next-headers");
|
|
return {
|
|
headers: vi.fn(async () => ({
|
|
get: (name: string) => headerJar.get(name.toLowerCase()) ?? null,
|
|
})),
|
|
cookies: vi.fn(async () => ({
|
|
get: (name: string) => {
|
|
const value = cookieJar.get(name);
|
|
return value ? { name, value } : undefined;
|
|
},
|
|
set: (name: string, value: string) => {
|
|
cookieJar.set(name, value);
|
|
},
|
|
delete: (name: string) => {
|
|
cookieJar.delete(name);
|
|
},
|
|
})),
|
|
};
|
|
});
|
|
|
|
vi.mock("@/lib/db-compat", () => ({
|
|
ensureDbCompatibility: vi.fn().mockResolvedValue(undefined),
|
|
}));
|
|
|
|
beforeEach(async () => {
|
|
await truncateAllTables(getPrismaClient());
|
|
cookieJar.clear();
|
|
const prisma = getPrismaClient();
|
|
await prisma.user.create({
|
|
data: {
|
|
id: USER_ID,
|
|
username: "lab-unit-mismatch",
|
|
email: "lab-unit-mismatch@example.test",
|
|
},
|
|
});
|
|
const session = await prisma.session.create({
|
|
data: { userId: USER_ID, expiresAt: new Date(Date.now() + 3_600_000) },
|
|
});
|
|
cookieJar.set("healthlog_session", session.id);
|
|
});
|
|
|
|
const TAKEN_AT = "2026-07-10T12:00:00.000Z";
|
|
|
|
async function seedGlucose() {
|
|
return getPrismaClient().biomarker.create({
|
|
data: {
|
|
userId: USER_ID,
|
|
name: "Glucose",
|
|
unit: "mg/dL",
|
|
lowerBound: 70,
|
|
upperBound: 99,
|
|
},
|
|
});
|
|
}
|
|
|
|
function jsonReq(path: string, body: unknown): NextRequest {
|
|
return new NextRequest(`http://localhost${path}`, {
|
|
method: "POST",
|
|
headers: { "content-type": "application/json" },
|
|
body: JSON.stringify(body),
|
|
});
|
|
}
|
|
|
|
async function postLab(body: Record<string, unknown>) {
|
|
const { POST } = await import("@/app/api/labs/route");
|
|
const res = await POST(jsonReq("/api/labs", { takenAt: TAKEN_AT, ...body }));
|
|
return { status: res.status, body: await res.json() };
|
|
}
|
|
|
|
async function commitRows(rows: Record<string, unknown>[]) {
|
|
const { POST } = await import("@/app/api/labs/ocr/commit/route");
|
|
const res = await POST(
|
|
jsonReq("/api/labs/ocr/commit", {
|
|
rows: rows.map((row) => ({ takenAt: TAKEN_AT, ...row })),
|
|
}),
|
|
);
|
|
return { status: res.status, body: await res.json() };
|
|
}
|
|
|
|
const labCount = () =>
|
|
getPrismaClient().labResult.count({ where: { userId: USER_ID } });
|
|
|
|
describe("POST /api/labs", () => {
|
|
it("refuses a reading in another unit than its marker's and writes nothing", async () => {
|
|
await seedGlucose();
|
|
const { status, body } = await postLab({
|
|
analyte: "Glucose",
|
|
value: 5.6,
|
|
unit: "mmol/L",
|
|
});
|
|
expect(status).toBe(422);
|
|
expect(body.meta).toMatchObject({
|
|
errorCode: "labs.unit.mismatch",
|
|
markerUnit: "mg/dL",
|
|
readingUnit: "mmol/L",
|
|
});
|
|
expect(await labCount()).toBe(0);
|
|
});
|
|
|
|
it("refuses it on the structured path too, when a unit is sent", async () => {
|
|
const marker = await seedGlucose();
|
|
const { status, body } = await postLab({
|
|
biomarkerId: marker.id,
|
|
value: 5.6,
|
|
unit: "mmol/L",
|
|
});
|
|
expect(status).toBe(422);
|
|
expect(body.meta.errorCode).toBe("labs.unit.mismatch");
|
|
expect(await labCount()).toBe(0);
|
|
});
|
|
|
|
it("writes a reading on the structured path that sends no unit, under the marker's", async () => {
|
|
const marker = await seedGlucose();
|
|
const { status, body } = await postLab({
|
|
biomarkerId: marker.id,
|
|
value: 95,
|
|
});
|
|
expect(status).toBe(201);
|
|
expect(body.data).toMatchObject({ value: 95, unit: "mg/dL" });
|
|
});
|
|
|
|
it.each(["mg/dl", "mg/DL", "MG/DL", " mg / dL "])(
|
|
"writes the same unit spelled %j",
|
|
async (spelling) => {
|
|
await seedGlucose();
|
|
const { status, body } = await postLab({
|
|
analyte: "Glucose",
|
|
value: 95,
|
|
unit: spelling,
|
|
});
|
|
expect(status).toBe(201);
|
|
expect(body.data).toMatchObject({ value: 95, unit: "mg/dL" });
|
|
},
|
|
);
|
|
|
|
it("does not compare a qualitative reading, which has no unit", async () => {
|
|
await seedGlucose();
|
|
const { status } = await postLab({
|
|
analyte: "Glucose",
|
|
valueText: "negative",
|
|
unit: "mmol/L",
|
|
});
|
|
expect(status).toBe(201);
|
|
});
|
|
|
|
it("lets a new marker adopt the unit of its first reading", async () => {
|
|
const { status, body } = await postLab({
|
|
analyte: "Creatinine",
|
|
value: 80,
|
|
unit: "µmol/L",
|
|
});
|
|
expect(status).toBe(201);
|
|
expect(body.data.unit).toBe("µmol/L");
|
|
// …and then holds the next reading in another unit to it.
|
|
const next = await postLab({
|
|
analyte: "Creatinine",
|
|
value: 0.9,
|
|
unit: "mg/dL",
|
|
});
|
|
expect(next.status).toBe(422);
|
|
expect(await labCount()).toBe(1);
|
|
});
|
|
|
|
it("never judges the refused value against the marker's range", async () => {
|
|
// The case from the report: 5.6 mmol/L is an ordinary glucose, and 5.6
|
|
// mg/dL would read as far below range.
|
|
await seedGlucose();
|
|
await postLab({ analyte: "Glucose", value: 5.6, unit: "mmol/L" });
|
|
const { GET } = await import("@/app/api/labs/route");
|
|
const res = await GET(
|
|
new NextRequest("http://localhost/api/labs?analyte=Glucose"),
|
|
);
|
|
expect((await res.json()).data.results).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe("POST /api/labs/ocr/commit", () => {
|
|
it("writes the matching row, skips the one in another unit, and reports a partial outcome", async () => {
|
|
await seedGlucose();
|
|
const { status, body } = await commitRows([
|
|
{ analyte: "Glucose", value: 95, unit: "mg/dL" },
|
|
{
|
|
analyte: "Glucose",
|
|
value: 5.6,
|
|
unit: "mmol/L",
|
|
takenAt: "2026-08-10T12:00:00.000Z",
|
|
},
|
|
]);
|
|
expect(status).toBe(200);
|
|
expect(body.data.inserted).toHaveLength(1);
|
|
expect(body.data.inserted[0]).toMatchObject({ value: 95, unit: "mg/dL" });
|
|
expect(body.data.skipped).toEqual([
|
|
{ analyte: "Glucose", reason: "unit_mismatch" },
|
|
]);
|
|
expect(body.data.outcome).toBe("partial");
|
|
expect(await labCount()).toBe(1);
|
|
});
|
|
|
|
it("reports a failed outcome when every row is in another unit", async () => {
|
|
await seedGlucose();
|
|
const { body } = await commitRows([
|
|
{ analyte: "Glucose", value: 5.6, unit: "mmol/L" },
|
|
]);
|
|
expect(body.data.inserted).toHaveLength(0);
|
|
expect(body.data.outcome).toBe("failed");
|
|
expect(await labCount()).toBe(0);
|
|
});
|
|
|
|
it("accepts a different spelling of the marker's unit", async () => {
|
|
await seedGlucose();
|
|
const { body } = await commitRows([
|
|
{ analyte: "Glucose", value: 95, unit: "MG/DL" },
|
|
]);
|
|
expect(body.data.outcome).toBe("success");
|
|
expect(body.data.inserted[0].unit).toBe("mg/dL");
|
|
});
|
|
|
|
it("does not compare a qualitative row", async () => {
|
|
await seedGlucose();
|
|
const { body } = await commitRows([
|
|
{ analyte: "Glucose", valueText: "negative", unit: "mmol/L" },
|
|
]);
|
|
expect(body.data.outcome).toBe("success");
|
|
});
|
|
});
|
|
|
|
describe("the scan review's view of a row", () => {
|
|
const scanned = (analyte: string, unit: string) => ({
|
|
analyte,
|
|
value: 5.6,
|
|
valueText: null,
|
|
unit,
|
|
referenceLow: null,
|
|
referenceHigh: null,
|
|
referenceText: null,
|
|
takenAt: null,
|
|
confidence: { analyte: 1, value: 1, unit: 1, range: 1 },
|
|
});
|
|
|
|
it("carries the matched marker's unit, so the screen can say so before Save", async () => {
|
|
await seedGlucose();
|
|
const { annotateRow } = await import("@/lib/labs/ocr-extract");
|
|
const known = await annotateRow(
|
|
USER_ID,
|
|
scanned("Glucose", "mmol/L"),
|
|
"2026-07-10",
|
|
"UTC",
|
|
);
|
|
expect(known).toMatchObject({
|
|
biomarkerMatch: "existing",
|
|
markerUnit: "mg/dL",
|
|
});
|
|
|
|
const fresh = await annotateRow(
|
|
USER_ID,
|
|
scanned("Creatinine", "µmol/L"),
|
|
"2026-07-10",
|
|
"UTC",
|
|
);
|
|
expect(fresh).toMatchObject({ biomarkerMatch: "new", markerUnit: null });
|
|
});
|
|
});
|