mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-08 12:32:43 +00:00
Marc-André Bombeck
24922b2787
v1.36.1 stopped a delegate changing a dose the owner had already recorded, and it stopped them on one route. The sibling `POST /api/medications/[id]/intake` reaches the same rows through the shared slot upsert, where the only existing protection is against a pending sync echo washing out a recorded dose. An explicit skip is not an echo: it fell through, flipped the outcome, and the inventory the take had consumed was refunded on the way. So the refusal I added was a door with the next one left open. The rule compares OUTCOMES rather than refusing every write onto an actioned slot, and the reason is the third case in the new contract. A double tap, an offline replay and a retry after a partial batch all re-post the same decision, and a caregiver hits all three; refusing those would make the feature unreliable exactly when somebody is standing in a kitchen with a pill box. Same decision applies, a different one is refused. The check rides into `applyCanonicalSlotWrite` rather than sitting at the call site, because that is where the existing row is already loaded: no extra query, and nothing between the read and the update for a concurrent write to slip through. A refused attempt files under the owner with the same action name the sibling route uses, so it reaches the activity panel the same way. Three integration cases, and each asserts the row rather than the status alone — a 403 that had already written the flip would read as protection while being the opposite. Watched fail: with the delegate flag forced off, the flip returns 201 while the replay and the owner's own correction stay green.