mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-18 08:02:12 +00:00
The layout settings gain a switch for the dashboard's top card (the Today card above the tiles). Stored server-side on the layout blob as `todayCardVisible`: missing means shown, only an explicit false hides it, the default is omitted from storage, a save that omits the field keeps the stored choice, and a layout reset shows the card again. Hidden, the card leaves no skeleton or error card behind. The flag rides the account-settings backup with the rest of the layout. The field is deliberately not `heroVisible`, the retired opt-in hero's flag that older stored layouts may still carry. An end-to-end journey on its own account switches the card off and on and walks the score histories' range tabs.
95 lines
3.6 KiB
TypeScript
95 lines
3.6 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { readFileSync } from "node:fs";
|
|
import { join } from "node:path";
|
|
|
|
/**
|
|
* Dashboard hero — page + header wiring pins.
|
|
*
|
|
* The legacy opt-in `DashboardHero` (gated on a layout `heroVisible`
|
|
* flag) was retired: the digest-driven `TodayHero` is the single,
|
|
* unambiguous hero, mounted above the tile strip. Pinned here:
|
|
*
|
|
* - the page mounts `TodayHero` and no longer references the legacy
|
|
* hero, its skeleton, or the `heroVisible` gate;
|
|
* - the greeting paragraph lives in the header on every mount (the
|
|
* header owns it unconditionally now that the legacy hero — which
|
|
* once carried it — is gone), while the page itself derives no
|
|
* welcome text.
|
|
*/
|
|
const PAGE_PATH = join(process.cwd(), "src/app/page-client.tsx");
|
|
const HEADER_PATH = join(
|
|
process.cwd(),
|
|
"src/components/dashboard/dashboard-header.tsx",
|
|
);
|
|
|
|
describe("dashboard hero — page wiring", () => {
|
|
const src = readFileSync(PAGE_PATH, "utf8");
|
|
|
|
it("mounts the TodayHero above the tile strip", () => {
|
|
const heroIdx = src.indexOf("<TodayHero");
|
|
const stripIdx = src.indexOf("dashboard-tile-strip");
|
|
expect(heroIdx).toBeGreaterThan(-1);
|
|
expect(stripIdx).toBeGreaterThan(heroIdx);
|
|
});
|
|
|
|
it("asks an empty filtered digest to render its all-clear state", () => {
|
|
expect(src).toContain("renderFilteredHeroAllClear");
|
|
expect(src).toContain(
|
|
"renderFilteredAllClear={renderFilteredHeroAllClear}",
|
|
);
|
|
expect(src).toContain(
|
|
"(layout.enabledHeroItemKinds ?? PRIORITY_ITEM_KINDS).length",
|
|
);
|
|
});
|
|
|
|
it("hides the top card, its skeleton and its error card only on an explicit false", () => {
|
|
// One gate in front of the whole three-way branch, so switching the card
|
|
// off leaves no reserve and no retry card where it stood.
|
|
const gate = src.indexOf("layout.todayCardVisible === false ? null :");
|
|
expect(gate).toBeGreaterThan(-1);
|
|
const hero = src.indexOf("<TodayHero", gate);
|
|
const skeleton = src.indexOf("<TodayHeroSkeleton", gate);
|
|
expect(hero).toBeGreaterThan(gate);
|
|
expect(skeleton).toBeGreaterThan(hero);
|
|
});
|
|
|
|
it("no longer references the retired legacy hero", () => {
|
|
expect(src).not.toContain("DashboardHero");
|
|
expect(src).not.toContain("DashboardHeroSkeleton");
|
|
expect(src).not.toContain("heroVisible");
|
|
});
|
|
|
|
it("the page derives no welcome text (the header owns the greeting)", () => {
|
|
expect(src).not.toContain("welcomeText");
|
|
expect(src).not.toContain("welcomeBackWithName");
|
|
expect(src).not.toContain("getHourForTimeZone");
|
|
});
|
|
});
|
|
|
|
describe("dashboard hero — header greeting", () => {
|
|
const header = readFileSync(HEADER_PATH, "utf8");
|
|
|
|
it("renders the greeting unconditionally (no showGreeting gate)", () => {
|
|
// The greeting line renders on every mount — the legacy hero that
|
|
// once owned it is gone, so there is no `showGreeting` prop to gate
|
|
// it. The `min-h-5` line-box reservation keeps the header stable
|
|
// through the post-hydration name swap.
|
|
expect(header).not.toContain("showGreeting");
|
|
expect(header).toContain("min-h-5");
|
|
expect(header).toContain('data-slot="dashboard-header-greeting"');
|
|
});
|
|
|
|
it("the page mounts the header without a greeting prop", () => {
|
|
const src = readFileSync(PAGE_PATH, "utf8");
|
|
expect(src).toContain(
|
|
"<DashboardHeader onQuickEntry={setQuickEntryDialog} />",
|
|
);
|
|
});
|
|
|
|
it("the header keeps the title + customize + add actions", () => {
|
|
expect(header).toContain('t("dashboard.title")');
|
|
expect(header).toContain("dashboard-customize-shortcut");
|
|
expect(header).toContain("dashboard-quick-add");
|
|
});
|
|
});
|