mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-09 13:01:00 +00:00
Marc-André Bombeck
a23ee61184
A spec that arms `page.route(...)` in a `beforeEach` and never drops the handler races its own teardown. The context closes, an async handler is still awaiting, its next call rejects with "Test ended.", and Playwright attributes that to the test that had just passed. With `retries: 2` plus `failOnFlakyTests`, which spec bites is a matter of timing. `e2e/setup/test.ts` re-exports Playwright's `test` extended with an auto fixture that unroutes every page and the context after each test, and clears the page event listeners a spec subscribes to; `expect` rides along so a spec needs one import. Auto means a spec author cannot forget it and does not have to know it exists. Every spec now takes `test` from there, and `e2e-route-cleanup-guard.test.ts` keeps the import boundary closed with an allowlist that carries its reason. The per-file `afterEach` on the cycle spec goes away — leaving both would read as not trusting the fixture. Not covered: a page inside a context a spec builds itself. Only `share-documents.spec.ts` does that, and it owns those contexts.
74 lines
2.5 KiB
TypeScript
74 lines
2.5 KiB
TypeScript
import { expect, test } from "./setup/test";
|
|
|
|
/**
|
|
* Smoke checks on the login surface — must render, must wire the
|
|
* password-manager autofill hints (autoComplete="username" /
|
|
* "current-password"), must let the user submit.
|
|
*
|
|
* These do NOT log in (no DB seed required); the password-flow
|
|
* roundtrip is exercised by the integration test in
|
|
* tests/integration/auth-flow.test.ts.
|
|
*/
|
|
async function openPasswordForm(page: import("@playwright/test").Page) {
|
|
await page.goto("/auth/login");
|
|
// The login page defaults to passkey mode; the password form is
|
|
// mounted only after clicking the "Login with password" / "Mit
|
|
// Passwort anmelden" outline button.
|
|
await page
|
|
.getByRole("button", {
|
|
name: /sign in with password|login with password|mit passwort/i,
|
|
})
|
|
.click();
|
|
}
|
|
|
|
test.describe("login page", () => {
|
|
test("renders username + password inputs with the right autoComplete", async ({
|
|
page,
|
|
}) => {
|
|
await openPasswordForm(page);
|
|
|
|
const username = page
|
|
.getByLabel(/username|benutzername|email|e-mail/i)
|
|
.first();
|
|
await expect(username).toBeVisible();
|
|
await expect(username).toHaveAttribute("autoComplete", /username|email/);
|
|
|
|
const password = page.locator('input[type="password"]').first();
|
|
await expect(password).toBeVisible();
|
|
await expect(password).toHaveAttribute("autoComplete", "current-password");
|
|
});
|
|
|
|
test("rejects an obviously-wrong credential pair", async ({ page }) => {
|
|
await openPasswordForm(page);
|
|
|
|
await page
|
|
.getByLabel(/username|benutzername|email|e-mail/i)
|
|
.first()
|
|
.fill("nobody-here");
|
|
await page.locator('input[type="password"]').first().fill("not-the-pw");
|
|
|
|
// Intercept the API call so the test does not depend on a real
|
|
// backend rejecting the credentials. The login form's error
|
|
// surfacing is what we actually want to prove here.
|
|
await page.route("**/api/auth/login", (route) =>
|
|
route.fulfill({
|
|
status: 401,
|
|
contentType: "application/json",
|
|
body: JSON.stringify({ error: "Invalid credentials" }),
|
|
}),
|
|
);
|
|
|
|
// The form has multiple buttons matching /sign in/ — both the
|
|
// passkey CTA and the password submit. Filter to the submit button
|
|
// so the click lands on the right one.
|
|
await page
|
|
.locator('button[type="submit"]')
|
|
.filter({ hasText: /login|anmelden|sign in/i })
|
|
.click();
|
|
|
|
await expect(
|
|
page.getByText(/invalid credentials|ungültig|falsch/i),
|
|
).toBeVisible({ timeout: 5_000 });
|
|
});
|
|
});
|