mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-18 08:02:12 +00:00
The `setOnboardingPendingCookie` helper was called from six different auth routes (login, passkey-verify, register, password, /me, /onboarding/complete) by convention. A future auth surface (SSO, magic link, social login) added without remembering the helper would silently re-introduce the dashboard flash that v1.4.22 C4 was designed to fix. Make `onboardingPending` a required parameter on `createSession` (not optional) so issuing a session without anchoring the cookie is type-impossible. The five primary auth surfaces now thread the user's `onboardingCompletedAt == null` value through; the `/api/auth/me` mirror remains as a fall-back for legacy sessions that predate the cookie. The `/api/onboarding/complete` clear stays where it is — it is a value flip after a DB write, not a session issuance. Three new integration tests pin: createSession sets the cookie when pending, clears it when completed, and destroySession clears it alongside the session cookie. Closes Sr-H1. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
37 lines
1.4 KiB
TypeScript
37 lines
1.4 KiB
TypeScript
import { apiSuccess } from "@/lib/api-response";
|
|
import { getGravatarUrl } from "@/lib/gravatar";
|
|
import { apiHandler, requireAuth } from "@/lib/api-handler";
|
|
import { annotate } from "@/lib/logging/context";
|
|
import { setOnboardingPendingCookie } from "@/lib/auth/session";
|
|
|
|
export const dynamic = "force-dynamic";
|
|
|
|
export const GET = apiHandler(async () => {
|
|
const { user } = await requireAuth();
|
|
|
|
// v1.4.22 W5 reconcile (Sr-H1) — fall-back resync for legacy
|
|
// sessions that predate the cookie. New sessions anchor the cookie
|
|
// inside `createSession` itself, so this is no longer the primary
|
|
// write path; it just makes sure pre-v1.4.22 sessions get their
|
|
// cookie set on the first /me roundtrip after the upgrade.
|
|
await setOnboardingPendingCookie(user.onboardingCompletedAt == null);
|
|
|
|
annotate({ action: { name: "auth.me" } });
|
|
|
|
return apiSuccess({
|
|
id: user.id,
|
|
username: user.username,
|
|
email: user.email,
|
|
role: user.role ?? "USER",
|
|
heightCm: user.heightCm,
|
|
dateOfBirth: user.dateOfBirth,
|
|
gender: user.gender,
|
|
timezone: user.timezone,
|
|
onboardingCompletedAt: user.onboardingCompletedAt,
|
|
onboardingTourCompleted: user.onboardingTourCompleted,
|
|
gravatarUrl: user.email ? getGravatarUrl(user.email) : null,
|
|
glucoseUnit: user.glucoseUnit ?? null,
|
|
lastReportPracticeName: user.lastReportPracticeName ?? null,
|
|
});
|
|
});
|