mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-19 08:12:52 +00:00
`User.glucoseUnit` has existed since v1.2 and around thirty surfaces read it — the dashboard tiles, the glucose page, the targets panel, the CSV and FHIR exports, the doctor report, the Coach snapshot, the low-reading push copy. Nothing could ever write it. No route, no schema, no field on any form, so every account resolved to the mg/dL default and the mmol/L half of the app was unreachable code. Anyone who reads glucose in mmol/L converted in their head on every screen. This is the missing end: a `GET`/`PATCH /api/auth/me/glucose-unit` scalar on the pattern the unit-preference endpoint next door established, and a dropdown in the profile form beside it. Deliberately its own control rather than a branch of metric/imperial: metric countries are split on which unit they read glucose in, so one dropdown would get half of them wrong. Storage is untouched and stays untouched. Every reading is written in mg/dL by every ingest path and the unit only selects a display branch, so nothing already recorded is reinterpreted. The entry form moved with the preference, which is the half that could have hurt: it asks in the chosen unit and inverts through `toCanonicalMgdl` on submit, so a 5.3 typed by an mmol/L reader is filed as 95 mg/dL rather than as 5.3 — a value the plausibility band accepts in silence and every surface reads back as a severe hypo. The contract gains the endpoint and nothing else; the account payload already carried the field.
151 lines
4.8 KiB
TypeScript
151 lines
4.8 KiB
TypeScript
"use client";
|
|
|
|
import { useEffect, useRef, useState } from "react";
|
|
import { useMutation, useQueryClient } from "@tanstack/react-query";
|
|
|
|
import { Label } from "@/components/ui/label";
|
|
import { NativeSelect } from "@/components/ui/native-select";
|
|
import { useAuth } from "@/hooks/use-auth";
|
|
import { useTranslations } from "@/lib/i18n/context";
|
|
import { queryKeys } from "@/lib/query-keys";
|
|
import { apiFetchRaw } from "@/lib/api/api-fetch";
|
|
import { resolveGlucoseUnit, type GlucoseUnit } from "@/lib/glucose";
|
|
|
|
/**
|
|
* Blood-glucose display unit as a Profile dropdown.
|
|
*
|
|
* The preference column and its thirty-odd readers shipped in v1.2 with no
|
|
* control to set them, so every account stayed on the mg/dL default and the
|
|
* mmol/L half of the app was unreachable. This is the control.
|
|
*
|
|
* It sits beside the metric/imperial dropdown because it is the same kind of
|
|
* setting — how a number is shown, not what is stored — but it is a separate
|
|
* choice: metric countries are split on which unit they read glucose in, so
|
|
* folding it into metric/imperial would get one of them wrong. The option
|
|
* labels are the unit symbols themselves, which read the same in every
|
|
* locale.
|
|
*
|
|
* Persistence mirrors the unit-system select: a change PATCHes
|
|
* `/api/auth/me/glucose-unit` immediately and invalidates `queryKeys.authMe()`
|
|
* plus `queryKeys.userGlucoseUnit()`, so the dashboard tiles, the glucose
|
|
* insight page and the targets panel re-render on the next /me refetch.
|
|
*/
|
|
export function GlucoseUnitSelect({
|
|
isAuthenticated,
|
|
id = "glucose-unit",
|
|
}: {
|
|
isAuthenticated: boolean;
|
|
id?: string;
|
|
}) {
|
|
const { t } = useTranslations();
|
|
const queryClient = useQueryClient();
|
|
const { user } = useAuth();
|
|
|
|
const [optimistic, setOptimistic] = useState<GlucoseUnit | null>(null);
|
|
const [msg, setMsg] = useState<string | null>(null);
|
|
const [msgType, setMsgType] = useState<"success" | "error" | null>(null);
|
|
const clearTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null);
|
|
|
|
useEffect(() => {
|
|
return () => {
|
|
if (clearTimerRef.current !== null) {
|
|
clearTimeout(clearTimerRef.current);
|
|
clearTimerRef.current = null;
|
|
}
|
|
};
|
|
}, []);
|
|
|
|
function scheduleClear() {
|
|
if (clearTimerRef.current !== null) {
|
|
clearTimeout(clearTimerRef.current);
|
|
}
|
|
clearTimerRef.current = setTimeout(() => {
|
|
clearTimerRef.current = null;
|
|
setMsg(null);
|
|
setMsgType(null);
|
|
}, 3000);
|
|
}
|
|
|
|
const value: GlucoseUnit =
|
|
optimistic ?? resolveGlucoseUnit(user?.glucoseUnit);
|
|
|
|
const mutation = useMutation({
|
|
mutationFn: async (next: GlucoseUnit) => {
|
|
const res = await apiFetchRaw("/api/auth/me/glucose-unit", {
|
|
method: "PATCH",
|
|
headers: { "Content-Type": "application/json" },
|
|
body: JSON.stringify({ glucoseUnit: next }),
|
|
});
|
|
if (!res.ok) {
|
|
const json = (await res.json().catch(() => ({}))) as {
|
|
error?: string;
|
|
};
|
|
throw new Error(json.error ?? `HTTP ${res.status}`);
|
|
}
|
|
return next;
|
|
},
|
|
onSuccess: () => {
|
|
setMsg(t("settings.dashboard.glucoseUnit.saved"));
|
|
setMsgType("success");
|
|
queryClient.invalidateQueries({ queryKey: queryKeys.authMe() });
|
|
queryClient.invalidateQueries({
|
|
queryKey: queryKeys.userGlucoseUnit(),
|
|
});
|
|
setOptimistic(null);
|
|
scheduleClear();
|
|
},
|
|
onError: (err) => {
|
|
setOptimistic(null);
|
|
setMsg(
|
|
err instanceof Error
|
|
? err.message
|
|
: t("settings.dashboard.glucoseUnit.saveError"),
|
|
);
|
|
setMsgType("error");
|
|
scheduleClear();
|
|
},
|
|
});
|
|
|
|
function handleSelect(next: GlucoseUnit) {
|
|
if (next === value || mutation.isPending || !isAuthenticated) return;
|
|
setOptimistic(next);
|
|
setMsg(null);
|
|
setMsgType(null);
|
|
if (clearTimerRef.current !== null) {
|
|
clearTimeout(clearTimerRef.current);
|
|
clearTimerRef.current = null;
|
|
}
|
|
mutation.mutate(next);
|
|
}
|
|
|
|
return (
|
|
<div className="space-y-2">
|
|
<Label htmlFor={id}>{t("settings.dashboard.glucoseUnit.title")}</Label>
|
|
<NativeSelect
|
|
id={id}
|
|
data-testid="settings-glucose-unit-select"
|
|
value={value}
|
|
disabled={!isAuthenticated || mutation.isPending}
|
|
onChange={(e) => handleSelect(e.target.value as GlucoseUnit)}
|
|
>
|
|
{/* Unit symbols, not translated copy — they read the same
|
|
everywhere, and a locale that "translated" one would be
|
|
naming a different measurement. */}
|
|
<option value="mg/dL">mg/dL</option>
|
|
<option value="mmol/L">mmol/L</option>
|
|
</NativeSelect>
|
|
<p
|
|
role="status"
|
|
aria-live="polite"
|
|
className={
|
|
msgType === "error"
|
|
? "text-destructive text-xs"
|
|
: "text-muted-foreground text-xs"
|
|
}
|
|
>
|
|
{msg ?? t("settings.dashboard.glucoseUnit.description")}
|
|
</p>
|
|
</div>
|
|
);
|
|
}
|