mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-09 04:50:59 +00:00
The cookie was the Session row's cuid. cuid is built for collision- resistant identity across distributed writers, not for unguessability — it encodes a millisecond timestamp and a process-local counter and never touches a CSPRNG. A session cookie is a bearer credential and has to be unguessable, so it now carries 32 random bytes and only the HMAC of that value is stored, matching how api_tokens and refresh_tokens already hold their secrets. Compatibility is passive, and deliberately so. A backfill cannot help: the cookie already sitting in a browser is the cuid, and nothing we generate server-side can be pushed into it — backfilling would sign everyone out at deploy. Upgrading a row in place on first use loses to the parallel requests a single page load fires: each mints its own secret, one write wins, and the losers cannot re-emit the winner's secret because only a hash is stored, so the browser can end up holding a value the row does not honour. Instead, rows minted before the column keep a NULL token_hash and stay resolvable by id, and are denied the sliding-expiry extension so they drain within the 30-day session lifetime. Every login from this release forward is on a secret at once, and an id stops authenticating the moment its row holds one. Note for operators: API_TOKEN_HMAC_KEY now also keys session cookies, so rotating it signs browser sessions out as well as invalidating tokens. It is already Core-required, so no deployment gains a new prerequisite.
417 lines
17 KiB
TypeScript
417 lines
17 KiB
TypeScript
import { randomBytes } from "node:crypto";
|
|
import { prisma } from "@/lib/db";
|
|
import { cookies } from "next/headers";
|
|
import type { User } from "@/generated/prisma/client";
|
|
import { hashToken } from "@/lib/auth/hmac";
|
|
import { ensureDbCompatibility } from "@/lib/db-compat";
|
|
import { getEvent } from "@/lib/logging/context";
|
|
import { shouldEmitSecureCookie } from "@/lib/auth/secure-cookie";
|
|
import { isP2025 } from "@/lib/prisma-errors";
|
|
import { locales, type Locale } from "@/lib/i18n/config";
|
|
import { LOCALE_COOKIE, setLocaleCookie } from "@/lib/i18n/locale-cookie";
|
|
|
|
const SESSION_COOKIE = "healthlog_session";
|
|
const SESSION_MAX_AGE_MS = 30 * 24 * 60 * 60 * 1000; // 30 days
|
|
|
|
/**
|
|
* Marks a cookie value as a v1.30.32 session secret. Doubles as the branch
|
|
* between the two resolution paths below, so a cookie is only ever looked up
|
|
* one way and a raw cuid can never be tried as a secret (or vice versa).
|
|
*/
|
|
const SESSION_TOKEN_PREFIX = "hls_";
|
|
const SESSION_SECRET_BYTES = 32;
|
|
|
|
/**
|
|
* Mint a session cookie secret: 32 CSPRNG bytes, hex-encoded.
|
|
*
|
|
* This exists because the cookie used to carry `Session.id` — a `cuid()`.
|
|
* cuid targets collision-resistant identity across distributed writers, not
|
|
* unguessability: it encodes a millisecond timestamp and a process-local
|
|
* counter and never touches a CSPRNG. That is a fine primary key and an unfit
|
|
* bearer credential. Only `hashToken(secret)` reaches the database, so a
|
|
* leaked table dump yields no usable cookie — the same posture ApiToken and
|
|
* RefreshToken already hold.
|
|
*/
|
|
function mintSessionSecret(): string {
|
|
return `${SESSION_TOKEN_PREFIX}${randomBytes(SESSION_SECRET_BYTES).toString("hex")}`;
|
|
}
|
|
|
|
/**
|
|
* Resolve the session row a cookie value refers to, or null.
|
|
*
|
|
* COMPATIBILITY DECISION (v1.30.32). Two paths, and the transition is
|
|
* deliberately passive:
|
|
*
|
|
* 1. `hls_…` — the modern secret. Looked up by `hashToken(value)`.
|
|
* 2. anything else — a pre-upgrade cookie carrying the row's cuid. Accepted
|
|
* ONLY while that row's `tokenHash` is still NULL.
|
|
*
|
|
* A migration-time backfill cannot work: the cookie already in the user's
|
|
* browser is the cuid, and no token we generate server-side can be pushed into
|
|
* it. Backfilling would sign out every logged-in user at deploy — the one
|
|
* outcome this change must not cause.
|
|
*
|
|
* Upgrading a legacy row in place on next use was the other candidate and was
|
|
* rejected as unsafe. A browser fires several requests in parallel, all
|
|
* carrying the same legacy cookie; each would mint its own secret and race to
|
|
* claim the row. Exactly one write can win, and the losers cannot learn the
|
|
* winner's secret to re-emit it — the row stores only a hash. Whichever
|
|
* response reached the browser last would decide the cookie, and if that was a
|
|
* loser's, the user is signed out. A guarded update narrows the write but not
|
|
* the outcome: a loser that declines to re-cookie leaves the browser holding a
|
|
* legacy id the row no longer honours. The race has no correct resolution, and
|
|
* its failure mode is precisely the forced logout we are avoiding.
|
|
*
|
|
* So legacy rows are left alone and simply live out the expiry they already
|
|
* have — `getSession` withholds the sliding-expiry extension from them (see
|
|
* there). That bounds the id-as-credential path to the 30-day session lifetime
|
|
* from the deploy, self-draining, with no operator step and no backfill. Every
|
|
* login from the deploy onward is on a secret immediately.
|
|
*/
|
|
async function findSessionByCookie(cookieValue: string) {
|
|
if (cookieValue.startsWith(SESSION_TOKEN_PREFIX)) {
|
|
return prisma.session.findUnique({
|
|
where: { tokenHash: hashToken(cookieValue) },
|
|
include: { user: true },
|
|
});
|
|
}
|
|
|
|
const legacy = await prisma.session.findUnique({
|
|
where: { id: cookieValue },
|
|
include: { user: true },
|
|
});
|
|
// A row that already holds a secret has retired its id as a credential.
|
|
return legacy && legacy.tokenHash === null ? legacy : null;
|
|
}
|
|
|
|
// v1.23 — throttle window for the user-facing active-session list's "last
|
|
// seen" stamp. A write only happens when the prior stamp is older than this,
|
|
// so the high-churn `getSession` path costs at most one extra UPDATE per
|
|
// session per window rather than one per request.
|
|
const LAST_ACTIVE_THROTTLE_MS = 5 * 60 * 1000; // 5 minutes
|
|
|
|
/**
|
|
* v1.4.22 C4 — flag cookie mirroring the user's `onboardingCompletedAt`
|
|
* status. Set to `"pending"` while the field is null and cleared once
|
|
* onboarding completes. The proxy reads this cookie to short-circuit
|
|
* the post-hydration redirect that previously caused a dashboard flash
|
|
* before the client-side `<AuthShell>` effect could fire.
|
|
*
|
|
* NOT httpOnly: the cookie is a UX hint, not a security signal — the
|
|
* real gate stays the server-side onboarding-complete check in
|
|
* `/api/onboarding/complete`. A user editing the cookie locally just
|
|
* skips the dashboard flash; they still can't bypass any data check.
|
|
*/
|
|
const ONBOARDING_COOKIE = "hl_onboarding";
|
|
|
|
export async function setOnboardingPendingCookie(
|
|
pending: boolean,
|
|
): Promise<void> {
|
|
const cookieStore = await cookies();
|
|
if (pending) {
|
|
cookieStore.set(ONBOARDING_COOKIE, "pending", {
|
|
httpOnly: false,
|
|
secure: shouldEmitSecureCookie(),
|
|
// v1.4.22 W5 reconcile (Sec-MED-1) — Strict (not Lax) because
|
|
// no cross-site redirect flow ever depends on this cookie. The
|
|
// sibling `healthlog_session` cookie stays Lax because the
|
|
// Withings OAuth callback arrives via top-level cross-site
|
|
// redirect; the onboarding hint has no equivalent flow.
|
|
sameSite: "strict",
|
|
maxAge: SESSION_MAX_AGE_MS / 1000,
|
|
path: "/",
|
|
});
|
|
} else {
|
|
cookieStore.delete(ONBOARDING_COOKIE);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* v1.4.22 W5 reconcile (Sr-H1) — `onboardingPending` is required
|
|
* (not optional) so issuing a session without anchoring the
|
|
* onboarding cookie is type-impossible. Every auth surface (login,
|
|
* passkey-verify, register, password-reset) must thread the user's
|
|
* `onboardingCompletedAt == null` value through. The onboarding
|
|
* surface itself flips the cookie via `setOnboardingPendingCookie`
|
|
* directly when the user hands in the form.
|
|
*/
|
|
export async function createSession(
|
|
userId: string,
|
|
onboardingPending: boolean,
|
|
ipAddress?: string | null,
|
|
userAgent?: string | null,
|
|
// v1.23 — set when this session was minted behind a completed second
|
|
// factor (the `/api/auth/mfa/verify` path) or a fresh factor re-confirm.
|
|
// `requireFreshMfa` reads it for step-up freshness; a null value means
|
|
// "single-factor session" and never satisfies step-up.
|
|
mfaVerifiedAt?: Date | null,
|
|
): Promise<string> {
|
|
// The secret is the cookie; the row id stays an internal identifier and is
|
|
// never handed to the client.
|
|
const secret = mintSessionSecret();
|
|
const session = await prisma.session.create({
|
|
data: {
|
|
userId,
|
|
tokenHash: hashToken(secret),
|
|
expiresAt: new Date(Date.now() + SESSION_MAX_AGE_MS),
|
|
ipAddress: ipAddress ?? null,
|
|
userAgent: userAgent ?? null,
|
|
mfaVerifiedAt: mfaVerifiedAt ?? null,
|
|
},
|
|
});
|
|
|
|
const cookieStore = await cookies();
|
|
cookieStore.set(SESSION_COOKIE, secret, {
|
|
httpOnly: true,
|
|
secure: shouldEmitSecureCookie(),
|
|
// OAuth callbacks (e.g. Withings) arrive via top-level cross-site redirect.
|
|
// Lax keeps CSRF protection for unsafe methods while allowing this flow.
|
|
sameSite: "lax",
|
|
maxAge: SESSION_MAX_AGE_MS / 1000,
|
|
path: "/",
|
|
});
|
|
|
|
// Anchor the onboarding cookie alongside the session cookie so a
|
|
// future auth surface added without remembering the helper can never
|
|
// reintroduce the dashboard flash.
|
|
await setOnboardingPendingCookie(onboardingPending);
|
|
|
|
return session.id;
|
|
}
|
|
|
|
export async function getSession(): Promise<{
|
|
session: { id: string; expiresAt: Date };
|
|
user: User;
|
|
} | null> {
|
|
try {
|
|
await ensureDbCompatibility();
|
|
} catch (error) {
|
|
getEvent()?.setError(
|
|
error instanceof Error
|
|
? error
|
|
: new Error("DB compatibility check failed"),
|
|
);
|
|
}
|
|
|
|
const cookieStore = await cookies();
|
|
const cookieValue = cookieStore.get(SESSION_COOKIE)?.value;
|
|
if (!cookieValue) return null;
|
|
|
|
const session = await findSessionByCookie(cookieValue);
|
|
|
|
if (!session || session.expiresAt < new Date()) {
|
|
if (session) {
|
|
await prisma.session
|
|
.deleteMany({ where: { id: session.id } })
|
|
.catch(() => {});
|
|
}
|
|
cookieStore.delete(SESSION_COOKIE);
|
|
cookieStore.delete(ONBOARDING_COOKIE);
|
|
return null;
|
|
}
|
|
|
|
// Sliding expiry: refresh if more than 1 day old.
|
|
//
|
|
// Withheld from legacy (`tokenHash === null`) rows on purpose. Extending
|
|
// those would let a cuid-as-credential session renew itself indefinitely for
|
|
// an active user, and the whole point of the passive transition is that the
|
|
// id-resolvable path drains on its own. Capping them at the expiry they
|
|
// already carry bounds it to at most 30 days past the deploy; the user then
|
|
// logs in once and lands on a secret. Re-emitting the cookie is likewise
|
|
// pointless for a legacy row — its value cannot be improved in place.
|
|
const oneDayMs = 24 * 60 * 60 * 1000;
|
|
if (
|
|
session.tokenHash !== null &&
|
|
session.expiresAt.getTime() - Date.now() < SESSION_MAX_AGE_MS - oneDayMs
|
|
) {
|
|
const newExpiry = new Date(Date.now() + SESSION_MAX_AGE_MS);
|
|
await prisma.session.update({
|
|
where: { id: session.id },
|
|
data: { expiresAt: newExpiry },
|
|
});
|
|
cookieStore.set(SESSION_COOKIE, cookieValue, {
|
|
httpOnly: true,
|
|
secure: shouldEmitSecureCookie(),
|
|
sameSite: "lax",
|
|
maxAge: SESSION_MAX_AGE_MS / 1000,
|
|
path: "/",
|
|
});
|
|
}
|
|
|
|
// v1.23 — sliding "last seen" stamp for the active-session list. Throttled
|
|
// (only when the prior stamp is stale) and fire-and-forget so it never adds
|
|
// latency or a failure mode to the request-resolution path.
|
|
const lastActive = session.lastActiveAt;
|
|
if (
|
|
!lastActive ||
|
|
lastActive.getTime() < Date.now() - LAST_ACTIVE_THROTTLE_MS
|
|
) {
|
|
void prisma.session
|
|
.update({
|
|
where: { id: session.id },
|
|
data: { lastActiveAt: new Date() },
|
|
})
|
|
.catch(() => {});
|
|
}
|
|
|
|
// Locale-cookie refresh: Safari's ITP expires the script-written
|
|
// `healthlog-locale` cookie after 7 days, so a returning user's first
|
|
// paint fell back to the browser language once a week. When the user
|
|
// has a persisted locale but the cookie is gone, re-emit it here —
|
|
// Set-Cookie is exempt from the ITP cap. Absent-only on purpose: a
|
|
// locale switch writes the cookie client-side before the PUT persists
|
|
// the column, and overwriting a *differing* cookie here would revert
|
|
// that fresh choice mid-flight. Fail-soft: in a server-component
|
|
// render the cookie store is read-only and `set` throws — the next
|
|
// route-handler request re-attempts.
|
|
if (
|
|
session.user.locale &&
|
|
(locales as readonly string[]).includes(session.user.locale) &&
|
|
!cookieStore.get(LOCALE_COOKIE)
|
|
) {
|
|
try {
|
|
setLocaleCookie(cookieStore, session.user.locale as Locale);
|
|
} catch {
|
|
// Read-only cookie context — skip; nothing depends on this write.
|
|
}
|
|
}
|
|
|
|
return {
|
|
session: { id: session.id, expiresAt: session.expiresAt },
|
|
user: session.user,
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Lightweight read of the signed-in user's persisted locale for the root
|
|
* layout's first-paint language resolution. Deliberately NOT
|
|
* `getSession()`: no db-compat check, no sliding-expiry write, no cookie
|
|
* mutation — the root layout renders on every request in a context where
|
|
* the cookie store is read-only, so the full session touch is both dead
|
|
* weight and a throw hazard there. Returns null for missing/expired
|
|
* sessions and users without a persisted locale.
|
|
*/
|
|
export async function getSessionUserLocale(): Promise<string | null> {
|
|
const cookieStore = await cookies();
|
|
const cookieValue = cookieStore.get(SESSION_COOKIE)?.value;
|
|
if (!cookieValue) return null;
|
|
|
|
// Same two-path resolution as `getSession`, read-only: this runs in the root
|
|
// layout where the cookie store cannot be written, so there is nothing to
|
|
// refresh or clear here.
|
|
const session = await findSessionByCookie(cookieValue);
|
|
if (!session || session.expiresAt < new Date()) return null;
|
|
return session.user.locale;
|
|
}
|
|
|
|
export async function destroySession(): Promise<void> {
|
|
const cookieStore = await cookies();
|
|
const cookieValue = cookieStore.get(SESSION_COOKIE)?.value;
|
|
if (cookieValue) {
|
|
// Resolve the cookie to its row before deleting — the cookie is a secret,
|
|
// not the primary key, so `delete({ where: { id: cookieValue } })` would
|
|
// silently no-op on every modern session and leave the row alive after a
|
|
// logout.
|
|
//
|
|
// Logout is idempotent: a session row that no longer exists (P2025) is a
|
|
// no-op. Any other failure is a real delete error — record it on the wide
|
|
// event rather than swallowing it silently, but never block the cookie
|
|
// clear below: a transient DB fault must not leave the client logged in
|
|
// with the cookie intact.
|
|
const session = await findSessionByCookie(cookieValue).catch(() => null);
|
|
if (session) {
|
|
await prisma.session
|
|
.delete({ where: { id: session.id } })
|
|
.catch((err) => {
|
|
if (!isP2025(err)) {
|
|
getEvent()?.addWarning(
|
|
`destroySession delete failed: ${err instanceof Error ? err.message : String(err)}`,
|
|
);
|
|
}
|
|
});
|
|
}
|
|
}
|
|
cookieStore.delete(SESSION_COOKIE);
|
|
cookieStore.delete(ONBOARDING_COOKIE);
|
|
}
|
|
|
|
/**
|
|
* Revoke every authenticated surface a user owns: web sessions, API
|
|
* tokens (long-lived Bearer credentials issued via `/settings/api-tokens`),
|
|
* and native-client refresh tokens. Called from every credential-rotation
|
|
* path (`/api/auth/password`, `/api/admin/users/[id]/reset-password`,
|
|
* `DELETE /api/settings/account`) so a remediated user wipes a stolen
|
|
* credential across every transport, not just the browser cookie.
|
|
*
|
|
* `ApiToken` flips `revoked=true` (the token-hash lookup at
|
|
* `src/lib/auth/api-token.ts` filters on this column). `RefreshToken`
|
|
* sets `revokedAt` (the rotation lookup at
|
|
* `src/lib/auth/refresh-token.ts` short-circuits on a non-null value).
|
|
* Both run as `updateMany` rather than `deleteMany` so the audit trail
|
|
* survives — the rows linger as evidence of the rotation event.
|
|
*/
|
|
export async function destroyAllSessions(userId: string): Promise<void> {
|
|
await prisma.$transaction([
|
|
prisma.session.deleteMany({ where: { userId } }),
|
|
prisma.apiToken.updateMany({
|
|
where: { userId, revoked: false },
|
|
data: { revoked: true },
|
|
}),
|
|
prisma.refreshToken.updateMany({
|
|
where: { userId, revokedAt: null },
|
|
data: { revokedAt: new Date() },
|
|
}),
|
|
// v1.23 — a credential rotation also kills every "remember this device"
|
|
// trusted-device token: a stolen device cookie must not survive a
|
|
// password change or account-credential remediation.
|
|
prisma.trustedDevice.deleteMany({ where: { userId } }),
|
|
]);
|
|
}
|
|
|
|
/**
|
|
* v1.23 — "sign out everywhere" for the user-facing active-session surface
|
|
* (issue #64). Distinct from `destroyAllSessions`: this keeps the caller's
|
|
* CURRENT cookie session alive so clicking the button doesn't log the user out
|
|
* of the device they pressed it on, and it does NOT revoke `ApiToken`s — those
|
|
* are long-lived programmatic credentials the user manages separately under
|
|
* /settings/api-tokens, not "sessions" in the device-list sense. It DOES revoke
|
|
* every native-client `RefreshToken` (each is a device login) so a signed-in
|
|
* phone/tablet is dropped too, matching the "everywhere" promise.
|
|
*
|
|
* Returns the number of OTHER web sessions removed so the surface can confirm.
|
|
*/
|
|
export async function destroyOtherSessions(
|
|
userId: string,
|
|
currentSessionId: string,
|
|
): Promise<{ sessionsRevoked: number }> {
|
|
const [deleted] = await prisma.$transaction([
|
|
prisma.session.deleteMany({
|
|
where: { userId, id: { not: currentSessionId } },
|
|
}),
|
|
prisma.refreshToken.updateMany({
|
|
where: { userId, revokedAt: null },
|
|
data: { revokedAt: new Date() },
|
|
}),
|
|
// v1.23 — "sign out everywhere" also drops every trusted device so a
|
|
// remembered browser can no longer skip the second factor (§1.7: a device
|
|
// cookie is killed on sign-out-everywhere).
|
|
prisma.trustedDevice.deleteMany({ where: { userId } }),
|
|
]);
|
|
return { sessionsRevoked: deleted.count };
|
|
}
|
|
|
|
/**
|
|
* v1.23 — revoke a single web session by id, scoped to the owning user so a
|
|
* caller can never delete another user's session row. Returns whether a row
|
|
* was actually removed (false → not found or not owned).
|
|
*/
|
|
export async function destroySessionById(
|
|
userId: string,
|
|
sessionId: string,
|
|
): Promise<boolean> {
|
|
const result = await prisma.session.deleteMany({
|
|
where: { id: sessionId, userId },
|
|
});
|
|
return result.count > 0;
|
|
}
|