mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-07 04:12:04 +00:00
Marc-André Bombeck
88750e0048
The hero-geometry check has never measured anything in CI. It launches Chromium in a hook, catches the launch failure, and every case then returns early — green. The quality job installs no browsers, so every run of it since the file landed printed [hero geometry] SKIPPED — no Chromium build available (Error: browserType.launch: Executable doesn't exist at /home/runner/.cache/ms-playwright/chromium_headless_shell-1234/ch) and passed. The file's own header warned about exactly this trap and then fell into it. Both ends move. The quality job installs the headless shell before the unit suite — `--only-shell chromium`, because that is the build `chromium.launch()` resolves to and the one the failing runs named, with a cache on the lockfile hash so the download is paid once. And the check now refuses to be optional: with CI set, a launch failure throws out of the hook and fails the suite with the step to restore. Without CI it still skips, through the test context so the skip and its reason land in the report rather than in a console line nobody reads. No panel number changed. The measurements the check reads back are the same ones the reserve was set against: panels of 400 / 428 / 456 / 484 px for three to six rows, 420 px for three rows plus the basis line, against a 448 px reserve.