mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 23:33:29 +00:00
A medication's startsOn/endsOn are calendar dates stored as UTC midnight, and the rrule library emits its day anchors the same way. The engine read those midnights on the user's wall clock, which west of UTC is the evening before. A FREQ=WEEKLY;BYDAY=MO plan therefore fired on Sundays in New York, a daily course starting on the 14th produced a dose on the 13th, and an evening dose on the last course day was cut off. One-shot doses, the first dose of a rolling cadence and the legacy weekday walk (startsOn floor, endsOn cap, every-N-weeks phase) carried the same shift. The engine now keeps a calendar day as a calendar day end to end: startsOn and rrule anchors are read from their UTC fields, instants (createdAt, intake times) are converted to the local day they fall on, and only then is the HH:mm materialised in the user's zone. Rolling cadences count calendar days from the local day of the last intake, so a late-evening dose across a DST change no longer slides a day. A nonexistent local time now always moves forward, including in zones whose clocks skip midnight. RRULE anchors with BYHOUR are collapsed per day so a twice-daily protocol cannot emit duplicate slots. CYCLIC on/off weeks are counted as seven-day blocks from the start day in the local calendar. They used to snap to Sunday-rooted UTC weeks, so a three-weeks-on course starting on a Wednesday lost its first days and the off week began on the wrong day east and west of UTC. Measurement reminders pass their anchor and course end as instants; the adapter now converts them to the user's calendar day before handing them to the engine.