mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 07:13:29 +00:00
Every raw-SQL clock read against a timestamp column without a zone now writes NOW() AT TIME ZONE 'UTC', so passkey and login challenges, rate limits, provider pauses, coach usage stamps, tombstone and measurement windows no longer pass through the session time zone even where the per-connection pin cannot apply. The regression-window bounds stay naive UTC timestamps instead of being turned into timestamptz. A structural guard keeps bare NOW() / CURRENT_TIMESTAMP out of raw SQL outside a short list of timestamptz targets. The integration test sets the database default to Europe/Berlin and drives challenge claims, session expiry, the native sign-in handoff freshness check and the rate-limit window through the app's client, plus the challenge claim through an unpinned client. Self-hosting docs describe the pin for an existing or shared Postgres.
98 lines
3.9 KiB
TypeScript
98 lines
3.9 KiB
TypeScript
/**
|
|
* Raw SQL never reads the clock through the session time zone.
|
|
*
|
|
* Stored times are UTC in `timestamp` columns without a zone. Postgres
|
|
* compares such a column with `NOW()` / `CURRENT_TIMESTAMP` /
|
|
* `clock_timestamp()` by converting through the session time zone, and
|
|
* assigns one of them to such a column the same way, so on a database whose
|
|
* default is not UTC a fresh passkey challenge read as already expired. Every
|
|
* connection is pinned to UTC (`@/lib/db-session`), and on top of that every
|
|
* raw-SQL clock read writes `NOW() AT TIME ZONE 'UTC'`, which yields the naive
|
|
* UTC timestamp whatever the session says.
|
|
*
|
|
* The few bare reads left are listed below with the reason they are safe:
|
|
* each feeds a `timestamptz` column or returns the instant to JavaScript.
|
|
*/
|
|
import { readdirSync, readFileSync, statSync } from "node:fs";
|
|
import { join, relative } from "node:path";
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
const ROOT = join(__dirname, "..", "..");
|
|
const SRC = join(ROOT, "src");
|
|
|
|
/** `file: reason` for every bare clock read that is deliberately left. */
|
|
const ALLOWED: Record<string, string> = {
|
|
"src/lib/rollups/mood-rollups.ts": "computed_at is timestamptz",
|
|
"src/lib/rollups/medication-compliance-rollups.ts":
|
|
"computed_at is timestamptz",
|
|
"src/lib/jobs/job-failures.ts": "pg-boss tables are timestamptz",
|
|
"src/lib/jobs/reminder/registrar-shared.ts": "pg-boss tables are timestamptz",
|
|
"src/lib/db-compat.ts": "DDL default on a timestamptz column",
|
|
};
|
|
|
|
const SQL_CLOCK =
|
|
/(?<![.\w])(?:NOW\(\)|CURRENT_TIMESTAMP\b|clock_timestamp\(\))|(?:(?<!=)[<>]|=)\s*now\(\)\s*(?:$|[,)]|[-+]\s*(?:make_interval|INTERVAL))|\bnow\(\)\s*[-+]\s*(?:make_interval|INTERVAL)/;
|
|
const ANCHORED =
|
|
/(?:NOW\(\)|CURRENT_TIMESTAMP|clock_timestamp\(\)) AT TIME ZONE 'UTC'/g;
|
|
|
|
function walk(dir: string, out: string[] = []): string[] {
|
|
for (const name of readdirSync(dir)) {
|
|
const full = join(dir, name);
|
|
if (name === "generated" || name === "__tests__") continue;
|
|
if (statSync(full).isDirectory()) walk(full, out);
|
|
else if (/\.tsx?$/.test(name) && !/\.test\.tsx?$/.test(name))
|
|
out.push(full);
|
|
}
|
|
return out;
|
|
}
|
|
|
|
function offenders(): string[] {
|
|
const found: string[] = [];
|
|
for (const file of walk(SRC)) {
|
|
const rel = relative(ROOT, file);
|
|
if (ALLOWED[rel]) continue;
|
|
readFileSync(file, "utf8")
|
|
.split("\n")
|
|
.forEach((line, index) => {
|
|
if (/^\s*(\/\/|\*|\/\*|--)/.test(line)) return;
|
|
if (SQL_CLOCK.test(line.replace(ANCHORED, ""))) {
|
|
found.push(`${rel}:${index + 1}: ${line.trim()}`);
|
|
}
|
|
});
|
|
}
|
|
return found;
|
|
}
|
|
|
|
describe("raw SQL clock reads are anchored to UTC", () => {
|
|
it("finds the anchored form across the swept files", () => {
|
|
// The matcher must see something, or a broken walk would pass.
|
|
const passkey = readFileSync(join(SRC, "lib/auth/passkey.ts"), "utf8");
|
|
expect(passkey.match(ANCHORED)?.length).toBeGreaterThanOrEqual(3);
|
|
expect(SQL_CLOCK.test("AND expires_at > NOW()")).toBe(true);
|
|
expect(SQL_CLOCK.test("updated_at = now()")).toBe(true);
|
|
expect(SQL_CLOCK.test("const started = now();")).toBe(false);
|
|
expect(SQL_CLOCK.test("elapsedMs: () => now() - started,")).toBe(false);
|
|
expect(SQL_CLOCK.test("const ends = now() + perCallMs;")).toBe(false);
|
|
expect(
|
|
SQL_CLOCK.test("deleted_at >= now() - make_interval(days => 1)"),
|
|
).toBe(true);
|
|
expect(SQL_CLOCK.test("Date.now()")).toBe(false);
|
|
});
|
|
|
|
it("leaves no bare NOW() / CURRENT_TIMESTAMP outside the allowlist", () => {
|
|
expect(offenders()).toEqual([]);
|
|
});
|
|
|
|
it("keeps the allowlist honest: every entry still has a bare read", () => {
|
|
for (const rel of Object.keys(ALLOWED)) {
|
|
const lines = readFileSync(join(ROOT, rel), "utf8")
|
|
.replace(ANCHORED, "")
|
|
.split("\n");
|
|
expect(
|
|
lines.some((line) => SQL_CLOCK.test(line)),
|
|
rel,
|
|
).toBe(true);
|
|
}
|
|
});
|
|
});
|