mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 07:13:29 +00:00
Found by an adversarial pass over the release candidate before it was tagged, and it is the reason the tag waited. `POST /api/medications/intake` is admitted for delegates because a caregiver standing next to the patient has to be able to say the tablet went down. It is an update, though, and the same body can carry two other things. Snoozing writes `snoozedUntil` on the OWNER's medication row, and the reminder cron skips that medication for as long as the stamp is in the future. The field takes any future instant. So somebody with write access could stop another person's medication reminders for years, and three things made it quiet: the owner is deliberately not notified of a delegated snooze, the activity feed renders the whole family as "marked a dose", and the only accurate trace was a line in the admin audit log. The second was flipping a dose the owner had already recorded — taken to skipped and back, which rewrites their compliance history and refunds inventory. The consent screen promises that changing what is already there stays with the owner. Both refuse for a delegate now and stay open to the owner, who is the only person either was ever for. A refused attempt is filed under the owner and gets its own sentence in the activity panel rather than borrowing the one for marking a dose, because folding them together is what made the gap dangerous. Two more from the same pass: The consent notice named allergies among the things a delegate may add. That left the admitted set before this release shipped, and it said so in six languages on the one screen where somebody decides who may write into their health record. It also omitted half of what IS admitted. The copy now matches the frozen list, and the test asserts the withdrawal rather than only the presence of the rest. The banner told a WRITE delegate nothing at all — the mode line rendered only in the read case, guarded by a comment stating that write grants did not exist yet. This is the release that made them exist. It matters that the banner say it, because the rule that a refused control is absent rather than disabled rests on the banner naming the mode globally. And a third instance of the substitution this release already fixed twice: the BMI chart divided the owner's weights by the height of whoever was looking. Inside a shared record it draws nothing now rather than a number belonging to two different people.
184 lines
6.9 KiB
TypeScript
184 lines
6.9 KiB
TypeScript
/**
|
|
* The access level, on the three screens that decide it.
|
|
*
|
|
* What an SSR render can prove, and what it cannot, stated up front because the
|
|
* distinction is the reason this file is shaped the way it is. It can prove
|
|
* that a control exists, that a sentence is on the page beside it, and that a
|
|
* row states its level before the button that accepts it. It CANNOT prove that
|
|
* the chosen level reaches the server: there is no click here, so the submit
|
|
* path never runs, and every assertion below stays green with the form wired
|
|
* back to a constant. That half is the browser journey's
|
|
* (`e2e/account-sharing.spec.ts`, which reads the posted body), and the
|
|
* database half is `src/app/api/account/grants/__tests__/`.
|
|
*
|
|
* The invitation copy is asserted by its promise rather than by its wording:
|
|
* "cannot edit or delete" is the sentence somebody's expectation is set by, and
|
|
* a rewrite that quietly drops it should fail here.
|
|
*/
|
|
import { renderToStaticMarkup } from "react-dom/server";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
|
|
import { I18nProvider } from "@/lib/i18n/context";
|
|
import type { GrantList, GrantRow } from "@/lib/queries/use-account-grants";
|
|
|
|
const grantsRef: { value: GrantList } = { value: { given: [], received: [] } };
|
|
|
|
vi.mock("@/lib/queries/use-account-grants", async (importOriginal) => {
|
|
const actual =
|
|
await importOriginal<typeof import("@/lib/queries/use-account-grants")>();
|
|
return {
|
|
...actual,
|
|
useInviteGrant: () => ({ mutate: vi.fn(), isPending: false }),
|
|
useAccountGrants: () => ({
|
|
data: grantsRef.value,
|
|
isLoading: false,
|
|
isError: false,
|
|
refetch: vi.fn(),
|
|
}),
|
|
useRecordActivity: () => ({
|
|
data: undefined,
|
|
isLoading: false,
|
|
isError: false,
|
|
refetch: vi.fn(),
|
|
}),
|
|
useAcceptGrant: () => ({ mutate: vi.fn(), isPending: false }),
|
|
useRenounceGrant: () => ({ mutate: vi.fn(), isPending: false }),
|
|
useRevokeGrant: () => ({ mutate: vi.fn(), isPending: false }),
|
|
};
|
|
});
|
|
|
|
vi.mock("@/hooks/use-account-switch", () => ({
|
|
useAccountSwitch: () => ({ mutate: vi.fn(), isPending: false }),
|
|
}));
|
|
|
|
import { GrantInviteCard } from "../grant-invite-card";
|
|
import { GrantsReceivedCard } from "../grants-received-card";
|
|
import { revokeBody } from "../grants-given-card";
|
|
|
|
function render(node: React.ReactNode): string {
|
|
return renderToStaticMarkup(
|
|
<I18nProvider initialLocale="en">{node}</I18nProvider>,
|
|
);
|
|
}
|
|
|
|
const BASE: GrantRow = {
|
|
id: "g1",
|
|
account: { id: "acct-1", username: "housemate", displayName: "Jo" },
|
|
access: "READ",
|
|
state: "PENDING",
|
|
invitedAt: "2026-01-02T10:00:00.000Z",
|
|
acceptedAt: null,
|
|
expiresAt: null,
|
|
lastUsedAt: null,
|
|
revokedAt: null,
|
|
revokedBy: null,
|
|
};
|
|
|
|
describe("offering a level", () => {
|
|
it("offers both levels and preselects the narrower one", () => {
|
|
const html = render(<GrantInviteCard />);
|
|
expect(html).toContain('data-slot="grant-invite-access"');
|
|
expect(html).toContain('data-access="READ"');
|
|
expect(html).toContain('data-access="WRITE"');
|
|
// The narrow level is the one somebody chooses their way out of.
|
|
expect(html).toContain('data-access="READ" data-selected="true"');
|
|
expect(html).toContain('data-access="WRITE" data-selected="false"');
|
|
});
|
|
|
|
it("says what the wider level actually does, and what it does not", () => {
|
|
const html = render(<GrantInviteCard />);
|
|
// The thing a person reading "write access" gets wrong.
|
|
expect(html).toContain("cannot edit or delete anything");
|
|
expect(html).toContain("marking a dose taken or skipped");
|
|
// v1.36.1 — the copy named allergies, which left the admitted set before
|
|
// this shipped, and it did so on the one screen where somebody decides who
|
|
// may write into their health record. Assert the withdrawal too, not only
|
|
// the presence of the rest: a consent notice that over-promises is worse
|
|
// than one that is merely incomplete.
|
|
expect(html).not.toContain("allergies");
|
|
// Deferring a reminder is the capability the same request could reach and
|
|
// delegation does not cover; the notice has to say so.
|
|
expect(html).toContain("cannot defer one of your reminders");
|
|
// And the narrow option still says it is narrow.
|
|
expect(html).toContain("They cannot add or change anything.");
|
|
});
|
|
});
|
|
|
|
describe("accepting a level", () => {
|
|
it("states the level and what accepting it means before the button", () => {
|
|
grantsRef.value = {
|
|
given: [],
|
|
received: [{ ...BASE, access: "WRITE" }],
|
|
};
|
|
const html = render(<GrantsReceivedCard />);
|
|
|
|
expect(html).toContain('data-grant-access="WRITE"');
|
|
expect(html).toContain("Can read and add entries");
|
|
expect(html).toContain('data-slot="grant-write-consent"');
|
|
// In document order the consent sits ahead of the control it qualifies.
|
|
expect(html.indexOf('data-slot="grant-write-consent"')).toBeLessThan(
|
|
html.indexOf('data-slot="grant-accept"'),
|
|
);
|
|
});
|
|
|
|
it("does not ask a read invitation for a write consent", () => {
|
|
grantsRef.value = { given: [], received: [{ ...BASE, access: "READ" }] };
|
|
const html = render(<GrantsReceivedCard />);
|
|
expect(html).toContain('data-grant-access="READ"');
|
|
expect(html).not.toContain('data-slot="grant-write-consent"');
|
|
});
|
|
|
|
it("stops saying it once the invitation has been answered", () => {
|
|
// A sentence about a decision already taken is nagging, not consent.
|
|
grantsRef.value = {
|
|
given: [],
|
|
received: [
|
|
{
|
|
...BASE,
|
|
access: "WRITE",
|
|
state: "ACTIVE",
|
|
acceptedAt: "2026-01-02T11:00:00.000Z",
|
|
},
|
|
],
|
|
};
|
|
const html = render(<GrantsReceivedCard />);
|
|
expect(html).not.toContain('data-slot="grant-write-consent"');
|
|
});
|
|
});
|
|
|
|
describe("ending an access, and what it says about what was entered", () => {
|
|
const t = (key: string, params?: Record<string, string | number>): string =>
|
|
params ? `${key}(${JSON.stringify(params)})` : key;
|
|
|
|
it("says nothing about entries for a grant that could not make any", () => {
|
|
const body = revokeBody({
|
|
t,
|
|
access: "READ",
|
|
name: "Jo",
|
|
retentionDays: 90,
|
|
});
|
|
expect(body).toContain("recordSharing.given.revokeBody");
|
|
expect(body).not.toContain("revokeEntriesStay");
|
|
expect(body).not.toContain("revokeAttribution");
|
|
});
|
|
|
|
it("tells a write owner that the entries stay and stay attributed", () => {
|
|
const body = revokeBody({
|
|
t,
|
|
access: "WRITE",
|
|
name: "Jo",
|
|
retentionDays: 90,
|
|
});
|
|
expect(body).toContain("recordSharing.given.revokeEntriesStay");
|
|
expect(body).toContain('revokeAttribution({"days":90})');
|
|
});
|
|
|
|
it("omits the window rather than inventing one", () => {
|
|
// The number is the operator's setting. A compiled-in 365 here would be
|
|
// exactly the invented value the sentence exists to avoid.
|
|
const body = revokeBody({ t, access: "WRITE", name: "Jo" });
|
|
expect(body).toContain("recordSharing.given.revokeEntriesStay");
|
|
expect(body).not.toContain("revokeAttribution");
|
|
});
|
|
});
|