mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-11 05:42:19 +00:00
The outbound safety screen ran on the Coach only. A dose-change imperative or a fabricated clinical risk score written onto a per-metric, biomarker or derived-score status card persisted as that day's cached assessment, while the identical sentence in the Coach was caught and replaced -- the only transform between provider and persistence was whitespace normalisation. Move the pattern banks into a shared screen that takes the reader's locale. The old signature took no locale, so the dose-refusal and risk-score contracts had no enforcement for fr/es/it/pl even though the ground rules ship in all six contract files. Banks now cover all six locales and each screen runs the reader's bank plus English, since a provider often answers in English regardless of the language directive. Status cards withhold on a trip: serve the deterministic stub and persist no model text. Nobody waits on a background-generated card, and persisting a refusal would pin it to the card for the day.
274 lines
10 KiB
TypeScript
274 lines
10 KiB
TypeScript
/**
|
|
* Shared helpers for the seven per-card status generators.
|
|
*
|
|
* Every `src/lib/insights/*-status.ts` generator carried byte-identical
|
|
* copies of `round`, `normalizeSummaryText`, `normalizeLocale`, and (in
|
|
* six of seven) `summarizeSeries`, plus an identical "parse the model's
|
|
* `{summary}` envelope" block and an identical `prisma.auditLog.create`
|
|
* persist block. This module is the single source of truth so a change
|
|
* to the rounding precision, the chart-token scrub, or the cache-row
|
|
* shape lands once rather than seven times.
|
|
*
|
|
* `SupportedLocale` is the full six-locale UI union. The status prompts
|
|
* compose one of two reviewed instruction bodies (de / en) but name the
|
|
* reader's own language in an explicit output directive, so the reader's
|
|
* locale must survive the whole pipeline rather than being collapsed to a
|
|
* binary on the way in. The
|
|
* medication-compliance generator writes a richer cache `details` shape
|
|
* (it carries a per-medication array), so it shares `round`,
|
|
* `normalizeSummaryText`, `normalizeLocale`, and `parseSummaryFromContent`
|
|
* but keeps its own `auditLog.create`.
|
|
*/
|
|
import { prisma } from "@/lib/db";
|
|
import { locales, type Locale } from "@/lib/i18n/config";
|
|
import { stripChartTokens } from "@/lib/insights/chart-tokens";
|
|
import {
|
|
screenModelOutput,
|
|
INSIGHTS_CONTRACTS,
|
|
type OutboundReason,
|
|
} from "@/lib/ai/safety/outbound-screen";
|
|
|
|
/**
|
|
* The locales the assessment pipeline carries end-to-end — all six the UI
|
|
* ships. Aliased to the i18n `Locale` so adding a UI locale widens the
|
|
* pipeline in one place rather than needing a second edit here.
|
|
*/
|
|
export type SupportedLocale = Locale;
|
|
|
|
const SUPPORTED_LOCALES: ReadonlySet<string> = new Set(locales);
|
|
|
|
/** Round to `digits` decimal places. */
|
|
export function round(value: number, digits = 1): number {
|
|
const factor = 10 ** digits;
|
|
return Math.round(value * factor) / factor;
|
|
}
|
|
|
|
/** Scrub chart tokens and collapse whitespace out of a model summary. */
|
|
export function normalizeSummaryText(value: string): string {
|
|
return stripChartTokens(value).replace(/\s+/g, " ").trim();
|
|
}
|
|
|
|
/**
|
|
* Validate an arbitrary locale string against the six the UI ships.
|
|
*
|
|
* A recognised locale passes through UNCHANGED — that is the whole point:
|
|
* the former `value === "de" ? "de" : "en"` binary erased a French reader's
|
|
* locale before any prompt saw it, so the output-language directive could
|
|
* never fire. An unrecognised or missing value defaults to ENGLISH, never
|
|
* German; a German default is the bug class this replaces.
|
|
*/
|
|
export function normalizeLocale(
|
|
value: string | null | undefined,
|
|
): SupportedLocale {
|
|
return typeof value === "string" && SUPPORTED_LOCALES.has(value)
|
|
? (value as SupportedLocale)
|
|
: "en";
|
|
}
|
|
|
|
export interface SeriesSummary {
|
|
points: number;
|
|
start: number;
|
|
end: number;
|
|
delta: number;
|
|
mean: number;
|
|
min: number;
|
|
max: number;
|
|
}
|
|
|
|
/**
|
|
* Fold a value series into a single start/end/delta/mean/min/max
|
|
* summary. Returns null for an empty series.
|
|
*
|
|
* v1.4.33 — fold sum/min/max into a single walk. The previous
|
|
* `Math.min(...series.map(...))` / `Math.max(...series.map(...))`
|
|
* spread tripped V8's ~125 000-arg ceiling on the bound /api/analytics
|
|
* path; see `.planning/round-v1433-analytics-500-report.md` §"Carry-
|
|
* over". These helpers are fed bounded windows today so the crash
|
|
* never reached them, but the spread allocates a transient args array
|
|
* on every call — the fold is both stack-safe and cheaper.
|
|
*/
|
|
export function summarizeSeries(
|
|
series: Array<{ value: number }>,
|
|
): SeriesSummary | null {
|
|
if (series.length === 0) return null;
|
|
const first = series[0].value;
|
|
const last = series[series.length - 1].value;
|
|
let sum = 0;
|
|
let minVal = series[0].value;
|
|
let maxVal = series[0].value;
|
|
for (const entry of series) {
|
|
sum += entry.value;
|
|
if (entry.value < minVal) minVal = entry.value;
|
|
if (entry.value > maxVal) maxVal = entry.value;
|
|
}
|
|
return {
|
|
points: series.length,
|
|
start: round(first, 2),
|
|
end: round(last, 2),
|
|
delta: round(last - first, 2),
|
|
mean: round(sum / series.length, 2),
|
|
min: round(minVal, 2),
|
|
max: round(maxVal, 2),
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Strip a Markdown code fence and isolate the JSON object body.
|
|
*
|
|
* The Anthropic and local providers have no native JSON mode (only the
|
|
* OpenAI-family clients send `response_format: json_object`), so a
|
|
* compliant model still routinely wraps its `{ "summary": … }` reply in a
|
|
* ```json … ``` fence or prefixes it with a sentence. `JSON.parse` then
|
|
* throws and the caller would surface the raw fenced string as the
|
|
* user-facing assessment. This helper removes a leading/trailing fence and
|
|
* narrows to the first `{` … last `}` span so the parse sees clean JSON.
|
|
*
|
|
* It is a no-op on already-clean JSON and on genuinely fence-free prose
|
|
* with no braces — in both cases the original (trimmed) string is returned,
|
|
* so the bare-prose fallback below still works.
|
|
*/
|
|
export function stripJsonFences(content: string): string {
|
|
let text = content.trim();
|
|
// Drop a leading ```json / ``` fence and a trailing ``` fence if present.
|
|
const fenced = text.match(/^```(?:json)?\s*\n?([\s\S]*?)\n?```$/i);
|
|
if (fenced) {
|
|
text = fenced[1].trim();
|
|
}
|
|
// Narrow to the first `{` … last `}` so a leading/trailing sentence the
|
|
// model added around the object does not break the parse.
|
|
const first = text.indexOf("{");
|
|
const last = text.lastIndexOf("}");
|
|
if (first !== -1 && last !== -1 && last > first) {
|
|
return text.slice(first, last + 1);
|
|
}
|
|
return text;
|
|
}
|
|
|
|
/**
|
|
* Pull the `summary` string out of a model completion. The status
|
|
* prompts return a `{ "summary": "…" }` envelope; a model that ignores
|
|
* the contract and returns bare prose falls back to the raw content.
|
|
*
|
|
* Tries the content as-is first (the common, fence-free case), then a
|
|
* fence-stripped retry for providers without a native JSON mode.
|
|
*/
|
|
export function parseSummaryFromContent(content: string): string {
|
|
try {
|
|
const parsed = JSON.parse(content) as { summary?: string };
|
|
if (typeof parsed.summary === "string") return parsed.summary;
|
|
} catch {
|
|
// not directly parseable — try a fence-stripped retry below
|
|
}
|
|
try {
|
|
const stripped = stripJsonFences(content);
|
|
if (stripped !== content) {
|
|
const parsed = JSON.parse(stripped) as { summary?: string };
|
|
if (typeof parsed.summary === "string") return parsed.summary;
|
|
}
|
|
} catch {
|
|
// still not JSON — fall through to the raw content
|
|
}
|
|
return content;
|
|
}
|
|
|
|
/**
|
|
* Persist one status assessment cache row in the standard text-only
|
|
* shape (`{ dateKey, locale, text, providerType, model, tokensUsed }`).
|
|
* Returns the row's `createdAt` ISO string. The medication-compliance
|
|
* generator writes a richer `details` shape (per-medication array) and
|
|
* keeps its own `auditLog.create` call.
|
|
*/
|
|
export async function persistStatusInsight(args: {
|
|
userId: string;
|
|
cacheAction: string;
|
|
todayKey: string;
|
|
locale: SupportedLocale;
|
|
text: string;
|
|
providerType: string;
|
|
model: string;
|
|
tokensUsed: number | null;
|
|
/**
|
|
* v1.16.8 — fingerprint of the data snapshot this assessment was
|
|
* generated from (see `snapshot-hash.ts`). The regeneration gate
|
|
* compares the fresh snapshot's hash against this and skips the
|
|
* provider call when nothing changed.
|
|
*/
|
|
snapshotHash?: string;
|
|
/**
|
|
* v1.18.11 (P6) — cheap fingerprint of the SALIENT INPUTS (per-type
|
|
* count + newest measuredAt) for slow-moving metrics. The input gate
|
|
* compares a freshly probed fingerprint against this BEFORE the heavy
|
|
* snapshot build, so a no-change day for weight/BMI skips the whole
|
|
* gather (not just the provider call). Absent on metrics that don't
|
|
* opt into the input gate.
|
|
*/
|
|
inputHash?: string;
|
|
}): Promise<string> {
|
|
const created = await prisma.auditLog.create({
|
|
data: {
|
|
userId: args.userId,
|
|
action: args.cacheAction,
|
|
details: JSON.stringify({
|
|
dateKey: args.todayKey,
|
|
locale: args.locale,
|
|
text: args.text,
|
|
providerType: args.providerType,
|
|
model: args.model,
|
|
tokensUsed: args.tokensUsed,
|
|
...(args.snapshotHash ? { snapshotHash: args.snapshotHash } : {}),
|
|
...(args.inputHash ? { inputHash: args.inputHash } : {}),
|
|
}),
|
|
},
|
|
select: { createdAt: true },
|
|
});
|
|
return created.createdAt.toISOString();
|
|
}
|
|
|
|
/**
|
|
* Outcome of turning one status-card completion into a shippable assessment.
|
|
* `blocked` carries the tripped contract so the caller can annotate before it
|
|
* withholds.
|
|
*/
|
|
export type StatusSummaryOutcome =
|
|
{ ok: true; text: string } | { ok: false; reason: OutboundReason };
|
|
|
|
/**
|
|
* The single finalize step every per-metric / biomarker / derived-score status
|
|
* generator runs on its completion: parse the `{ summary }` envelope, scrub
|
|
* chart tokens and whitespace, then SCREEN the prose against the insights
|
|
* safety contracts.
|
|
*
|
|
* Why the screen belongs here. Before this existed, the only transform between
|
|
* a provider and a persisted status assessment was `normalizeSummaryText`,
|
|
* which is whitespace-only — so a dose-change imperative or a fabricated
|
|
* clinical risk score written onto a metric card persisted as that day's cached
|
|
* assessment while the identical sentence in the Coach was caught and replaced.
|
|
* Every generator shares this chokepoint, so a card cannot be added that
|
|
* silently skips the screen.
|
|
*
|
|
* SURFACE POLICY — WITHHOLD. Unlike the Coach, a status card is generated in
|
|
* the background and read from cache; nobody is waiting on the turn. Persisting
|
|
* a refusal is wrong (it would pin "I can't advise on doses" to the user's
|
|
* Weight card for the day, which is noise on a surface they did not ask a
|
|
* question on) and persisting the screened prose is obviously wrong. So the
|
|
* caller serves its existing deterministic stub — the same signal-grounded line
|
|
* the card shows when no provider is configured — and persists no model text.
|
|
* The card degrades to a state the UI already renders honestly, and the short
|
|
* negative-cache window lets the next run try again.
|
|
*
|
|
* The contracts include `causal` here: GROUND RULE 12 declares surface
|
|
* `insights`, and these cards are that surface.
|
|
*/
|
|
export function finalizeStatusSummary(
|
|
content: string,
|
|
locale: SupportedLocale,
|
|
): StatusSummaryOutcome {
|
|
const text = normalizeSummaryText(parseSummaryFromContent(content));
|
|
if (!text) return { ok: true, text: "" };
|
|
const decision = screenModelOutput(text, locale, INSIGHTS_CONTRACTS);
|
|
if (decision.block && decision.reason) {
|
|
return { ok: false, reason: decision.reason };
|
|
}
|
|
return { ok: true, text };
|
|
}
|