mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-11 05:42:19 +00:00
Eleven touch-disjoint waves landed on develop plus a six-axis QA reconcile round before tagging. See CHANGELOG.md for the user-facing prose; this commit message documents the wave + report inventory for release-management traceability. Waves shipped (each with a phase report under .planning/): - phase-W-POOL-v1440-report.md — p-limit(4) wrapper around the analytics 15-way fan-out + pg.Pool max raised 10 -> 20. Closes the v1.4.39 empirical-trace finding #1 (Prisma pool starvation). - phase-W-DELETED-v1440-report.md — 11 reader-tier helpers + 3 integration contracts close audit Critical Finding #3 (soft-delete invisibility) across dashboard, analytics, summaries, rollup tiers, and the Coach snapshot path. - phase-W-INSIGHTS-v1440-report.md — mood-rollup swap on the three /api/insights/{features,targets,cards} routes plus the compliance-rollup hook gap closure for bulk-projection mints; the post-QA reconcile patch closes the six remaining measurement.findMany sites in the cluster that still leaked tombstoned rows. - phase-W-INFRA-v1440-report.md — rollup helper umbrella consolidation under src/lib/rollups/* with zero orphan re-exports; lint, typecheck, knip, and 93/93 rollup tests green post-restructure. - phase-W-RSC-v1440-report.md — per-tile Suspense boundaries plus the queryKey factory-bypass walker test (extended to comparison/ in the reconcile pass). - phase-W-PRIVACY-v1440-report.md — bilingual /privacy page with 17 paired-section tests pinning the 9 SB-3 disclosure requirements. - phase-W-AASA-v1440-report.md — /.well-known/apple-app-site-association endpoint pinned to S8WDX4W5KX.dev.healthlog.app with app-ID parity assertions guarding against split rotation. - phase-W-APNS-NOTIFY-v1440-report.md — MEDICATION_REMINDER time-sensitive APNs payload (priority 10 + interruption-level) scoped via a parameterised test that pins all 6 other event-types do not bypass Focus. AP-2 .p8 install gates real delivery. - phase-W-CONSENT-v1440-report.md — AI consent receipts CRUD with append-only invariant pinned in test; revoke-then-regrant leaves both rows; idempotent DELETE returns 200 + receipt: null. - phase-W-WMY-WIRE-v1440-report.md — three previously-dead WMY readers (week/month/year) wired through summaries-slice and health-score-fast-path with a linear-composability parity test pinning the cross-consumer routing contract. - phase-W-GHOSTS-v1440-report.md — ~1 177 lines of dead code removed across 9 atomic commits; startOfUtcDay + wallClockInTz consolidation eliminates a sibling-drift risk; knip whitelist trimmed to three files pending follow-up. QA reconcile patches applied per the v1.4.40 QA round (six reports under .planning/round-v1440-QA-*-findings.md): - senior C1 — dashboard-suspense-boundaries regex aligned with the post-W-INFRA Thread 2 userTimezone-local lift. - senior H1 — soft-delete filter added to the six remaining insights measurement.findMany sites. - specialist H1 — Promise.allSettled around bulk-projection compliance recompute on both /api/medications/intake and /api/dashboard/summary. - ux H1 — compare-toggle migrated to queryKeys.dashboardWidgets factory; walker test extended to src/components/comparison/. - security M1 — consent artefact 64 KB cap enforced via Buffer.byteLength (UTF-8 bytes, not UTF-16 code units). Quality gates green at tag: pnpm typecheck, pnpm lint, pnpm knip --include files,dependencies,binaries,unlisted, pnpm test --run (4726 passing / 1 skipped). Tests 4525 -> 4726 unit + 1 skipped over the v1.4.39 -> v1.4.40 span. User-facing prose: see CHANGELOG.md.
85 lines
3.3 KiB
TypeScript
85 lines
3.3 KiB
TypeScript
/**
|
|
* v1.4.36 — per-type rollup coverage probe.
|
|
*
|
|
* The v1.4.35/v1.4.36 read-swap gates on whether the DAY rollup table
|
|
* carries buckets for a user. The first iteration checked a single
|
|
* `COUNT(*) > 0` against `measurement_rollups`. That returns `true` as
|
|
* soon as *any* type has buckets, which breaks the "first measurement
|
|
* for a brand-new type" case: the per-write hook upserts one DAY bucket
|
|
* for the new type → the global probe stays >0 → the read path picks
|
|
* the bucket-derived branch for *every* type → the brand-new type's
|
|
* narrow-aggregate windowed columns come back fine but the seed loop
|
|
* only iterates bucket-bearing types, so a type that has live
|
|
* measurements but no buckets falls out of the response entirely.
|
|
*
|
|
* The probe below joins `measurements`-distinct-types against
|
|
* `measurement_rollups` so the caller learns, per type, whether the
|
|
* bucket table covers it. Types with `hasBuckets=false` fall back to
|
|
* the live aggregator branch; types with `hasBuckets=true` ride the
|
|
* cheap composed branch. The result is a single round-trip indexed
|
|
* read regardless of how many types the user has logged.
|
|
*/
|
|
import { prisma } from "@/lib/db";
|
|
|
|
/**
|
|
* Per-type coverage map. `true` means at least one DAY rollup row
|
|
* exists for this `(user, type)` pair; the caller can safely compose
|
|
* `count / min / max / mean` from the bucket table for this type.
|
|
* `false` means the bucket table is empty for this type and the caller
|
|
* must fall back to the live aggregate.
|
|
*
|
|
* Types the user has never logged are absent from the map — callers
|
|
* never need to ask about a type with zero measurements.
|
|
*/
|
|
export type RollupCoverageMap = Map<string, boolean>;
|
|
|
|
/**
|
|
* Probe DAY-bucket coverage for every type the user has measurements
|
|
* for. The join is anchored on the smaller `DISTINCT type FROM
|
|
* measurements` set so the planner picks the per-type
|
|
* `(user_id, type, measured_at)` index path; the LEFT JOIN onto the
|
|
* rollup table uses the `(user_id, type, granularity, bucket_start)`
|
|
* composite primary key. A `COUNT > 0` per partition keeps the result
|
|
* shape stable even when a type has zero buckets.
|
|
*/
|
|
export async function probeRollupCoverage(
|
|
userId: string,
|
|
): Promise<RollupCoverageMap> {
|
|
const rows = await prisma.$queryRaw<
|
|
Array<{ type: string; has_buckets: boolean }>
|
|
>`
|
|
SELECT
|
|
m."type"::text AS type,
|
|
COUNT(r.*) > 0 AS has_buckets
|
|
FROM (
|
|
SELECT DISTINCT "type"
|
|
FROM measurements
|
|
WHERE user_id = ${userId}
|
|
AND "deleted_at" IS NULL
|
|
) m
|
|
LEFT JOIN measurement_rollups r
|
|
ON r.user_id = ${userId}
|
|
AND r."type" = m."type"
|
|
AND r.granularity = 'DAY'
|
|
GROUP BY m."type"
|
|
`;
|
|
const coverage: RollupCoverageMap = new Map();
|
|
for (const row of rows) {
|
|
coverage.set(row.type, Boolean(row.has_buckets));
|
|
}
|
|
return coverage;
|
|
}
|
|
|
|
/**
|
|
* Convenience — `true` when the user has at least one measurement and
|
|
* every type with measurements also has DAY-bucket coverage. The read
|
|
* path can skip the live aggregate entirely.
|
|
*/
|
|
export function isFullyCovered(coverage: RollupCoverageMap): boolean {
|
|
if (coverage.size === 0) return false;
|
|
for (const hasBuckets of coverage.values()) {
|
|
if (!hasBuckets) return false;
|
|
}
|
|
return true;
|
|
}
|