mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-18 16:12:11 +00:00
The runner moves from Wolfi to node:22-trixie-slim, the same image and digest as the dependency and build stages. Wolfi's free repository keeps only its newest Node stream current, so nodejs-22 stayed at 22.23.2 and missed two releases with HIGH fixes; the official image carries 22.23.4. The runner removes npm, npx, corepack and yarn before anything else and fails the build if one is left. The Prisma CLI install moves to its own prisma-cli stage on the same base and is copied over, so npm never runs in the runner. pg_dump and pg_restore 18.6 come from a pgclient stage on postgres:18.6-trixie, pinned by digest, with the libpq they link; the Kerberos, LDAP and SASL libraries come from apt. The PGDG package would bring Perl and the wrapper scripts, and its repository drops a pinned minor once the next one is out. The native ABI and glibc check between builder and runner stays as a guard. runtime-package-pins now holds every stage to a digest, the runner to the builder's image, the runner free of package managers, and the pgclient minor to the bundled database's. Dependabot ignores a PostgreSQL major in the Dockerfile as it does in the compose file.
99 lines
4.0 KiB
TypeScript
99 lines
4.0 KiB
TypeScript
/**
|
|
* Structural guard: the runtime image puts the @napi-rs/canvas native binary
|
|
* of the version the app pins next to that version's loader.
|
|
*
|
|
* ## The failure this freezes (GitHub #1124)
|
|
*
|
|
* The pnpm store held two canvas versions: the one in package.json and an
|
|
* older one that a second, older pdfjs-dist pulled in (gone since #1277).
|
|
* The runner stage picked the platform binary with `find | head -1`, got the
|
|
* old one, and copied it into the new loader's directory, where the loader
|
|
* looks first. PDF rendering still worked, so nothing looked wrong;
|
|
* `loadImage` called an `Image.decode` the old binary lacks, and every
|
|
* preview thumbnail failed with "image.decode is not a function" on both
|
|
* architectures.
|
|
*
|
|
* ## What it proves and what it does not
|
|
*
|
|
* The builder records the resolved canvas version, the runner hoists by that
|
|
* name, and the build stops when the copied binary's package is a different
|
|
* version. Whether the binary loads is proved when the image runs; this file
|
|
* reads the Dockerfile only.
|
|
*/
|
|
import { readFileSync } from "node:fs";
|
|
import { join } from "node:path";
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
const DOCKERFILE = readFileSync(join(process.cwd(), "Dockerfile"), "utf8");
|
|
|
|
function stage(name: string): string {
|
|
const start = DOCKERFILE.search(new RegExp(`^FROM .* AS ${name}$`, "m"));
|
|
expect(start, `the Dockerfile has a ${name} stage`).toBeGreaterThan(0);
|
|
const next = DOCKERFILE.slice(start + 1).search(/^FROM /m);
|
|
return next < 0
|
|
? DOCKERFILE.slice(start)
|
|
: DOCKERFILE.slice(start, start + 1 + next);
|
|
}
|
|
|
|
describe("canvas binary hoist", () => {
|
|
it("records the resolved canvas version in the builder", () => {
|
|
expect(stage("builder")).toMatch(
|
|
/require\('\/app\/node_modules\/@napi-rs\/canvas\/package\.json'\)\.version"[\s\\]*>\s*\/app\/\.canvas-version/,
|
|
);
|
|
});
|
|
|
|
it("hoists the loader and the glibc binary of that version only", () => {
|
|
const runner = stage("runner");
|
|
expect(runner).toContain(
|
|
"COPY --from=builder /app/.canvas-version /tmp/.canvas-version",
|
|
);
|
|
expect(runner).toContain(
|
|
'CANVAS_DIR="/app/node_modules/.pnpm/@napi-rs+canvas@${CANVAS_VERSION}/',
|
|
);
|
|
// The image is Debian: the glibc (`-gnu`) build is the one that runs,
|
|
// and the musl build, which needs ARMv8.2 on arm64 (#1311), is not.
|
|
expect(runner).toContain("canvas-linux-*-gnu@${CANVAS_VERSION}/");
|
|
expect(runner).toContain("-name 'skia.linux-*-gnu.node'");
|
|
expect(runner).not.toMatch(/-musl/);
|
|
// A version-blind pick is the defect: any `canvas…@*` glob decides by
|
|
// readdir order which of the store's copies wins.
|
|
expect(runner).not.toMatch(/@napi-rs\+canvas[^"'\s]*@\*/);
|
|
});
|
|
|
|
it("installs and runs on the same Debian glibc image", () => {
|
|
const froms = DOCKERFILE.match(/^FROM \S+ AS \S+$/gm) ?? [];
|
|
expect(froms).toEqual([
|
|
expect.stringMatching(
|
|
/^FROM node:22-trixie-slim@sha256:[0-9a-f]{64} AS deps$/,
|
|
),
|
|
expect.stringMatching(
|
|
/^FROM node:22-trixie-slim@sha256:[0-9a-f]{64} AS builder$/,
|
|
),
|
|
expect.stringMatching(
|
|
/^FROM node:22-trixie-slim@sha256:[0-9a-f]{64} AS prisma-cli$/,
|
|
),
|
|
expect.stringMatching(
|
|
/^FROM postgres:18\.\d+-trixie@sha256:[0-9a-f]{64} AS pgclient$/,
|
|
),
|
|
expect.stringMatching(
|
|
/^FROM node:22-trixie-slim@sha256:[0-9a-f]{64} AS runner$/,
|
|
),
|
|
]);
|
|
// The native packages pnpm picked in the builder must load in the
|
|
// runner: same module ABI, and a glibc no older than the builder's.
|
|
expect(stage("builder")).toContain("> /app/.native-abi");
|
|
expect(stage("runner")).toContain(
|
|
'[ "$RUN_ABI" = "$BUILD_ABI" ] || { echo "ERROR: runner Node module ABI',
|
|
);
|
|
expect(stage("runner")).toContain("is older than the builder's");
|
|
});
|
|
|
|
it("fails the build when the copied binary is another version", () => {
|
|
const runner = stage("runner");
|
|
expect(runner).toMatch(
|
|
/\[ "\$BIN_VERSION" = "\$CANVAS_VERSION" \] \|\| \{[^}]*exit 1; \}/,
|
|
);
|
|
});
|
|
});
|