mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-11 13:52:20 +00:00
Opening an Insights category page froze the whole UI: the per-metric status card fired a cold, uncapped LLM fetch on mount with no client abort, so the request hung up to the server's 60s ceiling and the pending/resolve re-renders thrashed the tab strip and ate touch events. Timeouts were never negatively cached, so every visit re-blocked. Fix the class holistically: - Bound every status GET on the client. The shared use-insight-status hook and the inline medication-compliance query now wrap fetch in an 8s AbortController and stop retrying inline; navigation can no longer await an uncapped round-trip. - Make the status routes read-only. On a cache miss the generator enqueues an out-of-band pg-boss job (insight-status-generate) and returns a preparing envelope; the client polls a bounded interval until the worker warms the cache. Models the dashboard snapshot's ready/preparing pattern. The queue is registered in the worker allQueues loop + a boss.work handler, with a guard test. - Fix the nightly warm-pass regression: warm every supported locale (the client reads against the active UI locale, not the persisted User.locale) and warm on a cached comprehensive outcome too (its write still evicts the per-status caches). Add a short-TTL negative cache on the timeout path so a transient provider stall no longer makes every subsequent visit re-block or re-enqueue. - Add loading.tsx for the insights segment + the root so any future RSC await streams a skeleton instead of blocking the transition. - Stabilise the advisor regenerate callback so a status-query flip can't re-render the memoised tab strip mid-gesture. New i18n key insights.assessmentPreparing across all six locales.
103 lines
3.6 KiB
TypeScript
103 lines
3.6 KiB
TypeScript
import { prisma } from "@/lib/db";
|
|
import { annotate } from "@/lib/logging/context";
|
|
|
|
/**
|
|
* Shared timeout / provider-error fallback for the InsightStatus routes.
|
|
*
|
|
* When the upstream provider call exceeds `STATUS_PROVIDER_TIMEOUT_MS`
|
|
* (or rejects outright) the generator still has to return a deterministic
|
|
* envelope. It used to persist a sentinel row carrying the generic
|
|
* fallback under the same `text` field a real assessment uses; the
|
|
* cache-read served it as valid and it stuck until midnight — hiding the
|
|
* real, data-driven assessment for the rest of the day on any account that
|
|
* hit a single transient stall. v1.4.28 removed that persist entirely.
|
|
*
|
|
* v1.8.3 — re-introduce a *negative* cache, but a strictly bounded one. The
|
|
* status route is now read-only: a cache miss enqueues an out-of-band
|
|
* generation. If the provider stalls inside the worker, nothing stops the
|
|
* next navigation from enqueuing again, and again — a stalled provider
|
|
* turns into a re-enqueue storm. So the timeout path writes a short-TTL
|
|
* negative stub (`{ timeout:true, model:"timeout-stub", retryAt }`). The
|
|
* read-only resolver honours it: while the stub is fresh it returns
|
|
* `preparing` WITHOUT re-enqueuing; once `retryAt` passes the stub is stale
|
|
* and the next visit re-attempts. The stub is NEVER served as assessment
|
|
* text — `readFreshStatusText` still rejects every timeout stub by marker,
|
|
* so a transient stall can't hide the real assessment for the day.
|
|
*/
|
|
|
|
/** Short retry window after a provider stall before a re-enqueue is allowed. */
|
|
export const TIMEOUT_NEGATIVE_CACHE_MS = 5 * 60 * 1000;
|
|
|
|
/**
|
|
* Persist a short-TTL negative-cache stub for `(userId, cacheAction)`.
|
|
* Best-effort: a failure here just means the read-only resolver may
|
|
* re-enqueue sooner than the window intended.
|
|
*/
|
|
export async function persistTimeoutNegativeStub(args: {
|
|
userId: string;
|
|
cacheAction: string;
|
|
todayKey: string;
|
|
reason: "timeout" | "error";
|
|
}): Promise<void> {
|
|
try {
|
|
await prisma.auditLog.create({
|
|
data: {
|
|
userId: args.userId,
|
|
action: args.cacheAction,
|
|
details: JSON.stringify({
|
|
dateKey: args.todayKey,
|
|
timeout: true,
|
|
model: "timeout-stub",
|
|
reason: args.reason,
|
|
retryAt: new Date(
|
|
Date.now() + TIMEOUT_NEGATIVE_CACHE_MS,
|
|
).toISOString(),
|
|
}),
|
|
},
|
|
});
|
|
} catch {
|
|
// Negative cache is best-effort — never throw out of the timeout path.
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Return the deterministic fallback envelope for a timeout / error. The
|
|
* current render still gets the fallback text, marked `cached:true` so the
|
|
* UI does not mislabel it as a fresh assessment and `updatedAt:null` to
|
|
* signal "no persisted assessment". When `userId` + `todayKey` are present
|
|
* (the worker-side generation path) a short-TTL negative stub is persisted
|
|
* so a stalled provider doesn't trigger a re-enqueue storm.
|
|
*/
|
|
export function returnTimeoutFallback(input: {
|
|
cacheAction: string;
|
|
reason: "timeout" | "error";
|
|
stubText: string;
|
|
userId?: string;
|
|
todayKey?: string;
|
|
}): {
|
|
hasProvider: true;
|
|
text: string;
|
|
cached: true;
|
|
updatedAt: null;
|
|
} {
|
|
annotate({
|
|
action: { name: "insights.status.fallback_served" },
|
|
meta: { cacheAction: input.cacheAction, reason: input.reason },
|
|
});
|
|
if (input.userId && input.todayKey) {
|
|
// Fire-and-forget — the caller's render must not wait on the write.
|
|
void persistTimeoutNegativeStub({
|
|
userId: input.userId,
|
|
cacheAction: input.cacheAction,
|
|
todayKey: input.todayKey,
|
|
reason: input.reason,
|
|
});
|
|
}
|
|
return {
|
|
hasProvider: true,
|
|
text: input.stubText,
|
|
cached: true,
|
|
updatedAt: null,
|
|
};
|
|
}
|