mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-09 04:50:59 +00:00
Marc-André Bombeck
6ac3a61829
A GET must not have side effects — api-handler.ts says so next to READ_HTTP_METHODS, where an MCP-audience token is admitted on the safe methods precisely because they are assumed to write nothing. Three routes broke that: the sync handshake bumped User.lastSyncedAt, the achievements read inserted unlock rows, and the cycle calendar fired a discarded promise at the forecast cache so a failed write left no trace anywhere. Each write moves to the place that causes it. The sync checkpoint is now stamped by the batch ingest endpoints for measurements, mood and intakes. The handshake reports it. That also fixes the watermark: the checkpoint used to advance past a window the client had not drained, and a client trusting it would skip that window. It can only trail a real sync now. The unlock rows move to a nightly achievement-unlock-sweep. The badge grid never needed them — unlocked comes from the live metrics and the completion date is derived — so the payload is unchanged; the rows pin that date and carry it into the backup, and the sweep reaches accounts that never open the page. The cycle forecast moves to a nightly cycle-prediction-refresh. The CyclePrediction row is not a cache of a read: it is the index the reminder cron scans, so which reminders an account received depended on whether somebody had opened the calendar. persistPredictionCache no longer swallows its errors either — the job reports them.
83 lines
2.8 KiB
TypeScript
83 lines
2.8 KiB
TypeScript
/**
|
|
* Cycle prediction cache — debounced stale-while-revalidate (the v1.8.7
|
|
* insight-assessment cache pattern, ios-contract §2.D).
|
|
*
|
|
* The `CyclePrediction` row is what the cycle-reminder cron scans to find
|
|
* who is due a period-soon or fertile-soon push. It is written by the
|
|
* `cycle-prediction-refresh` job (see `prediction-refresh.ts`), never by a
|
|
* read: `GET /api/cycle/calendar` runs the same engine for the forecast it
|
|
* returns and persists nothing.
|
|
*
|
|
* The persist is debounced: a re-write only lands when the prior row is
|
|
* older than the debounce window OR the forecast actually changed, so a
|
|
* repeated refresh never thrashes the row.
|
|
*
|
|
* Failures propagate. This used to swallow every error, which made a cache
|
|
* that had not been written for weeks indistinguishable from one with
|
|
* nothing to write; the caller is a job and puts the failure on the
|
|
* operator's failing-jobs surface.
|
|
*/
|
|
import { prisma } from "@/lib/db";
|
|
import type { CyclePredictionResult } from "@/lib/cycle/types";
|
|
|
|
/** Don't re-persist an unchanged forecast more often than this. */
|
|
const PREDICTION_DEBOUNCE_MS = 6 * 60 * 60 * 1000; // 6h
|
|
|
|
/**
|
|
* Persist (or refresh) the cached forecast for a user, debounced. A
|
|
* no-op when a fresh-enough identical row already exists.
|
|
*/
|
|
export async function persistPredictionCache(
|
|
userId: string,
|
|
result: CyclePredictionResult,
|
|
now: Date = new Date(),
|
|
): Promise<void> {
|
|
const existing = await prisma.cyclePrediction.findUnique({
|
|
where: { userId },
|
|
select: {
|
|
method: true,
|
|
nextPeriodStart: true,
|
|
nextPeriodStartLow: true,
|
|
nextPeriodStartHigh: true,
|
|
confidence: true,
|
|
cyclesObserved: true,
|
|
generatedAt: true,
|
|
},
|
|
});
|
|
|
|
const unchanged =
|
|
existing !== null &&
|
|
existing.method === result.method &&
|
|
existing.nextPeriodStart === result.nextPeriodStart &&
|
|
existing.nextPeriodStartLow === result.nextPeriodStartLow &&
|
|
existing.nextPeriodStartHigh === result.nextPeriodStartHigh &&
|
|
existing.confidence === result.confidence &&
|
|
existing.cyclesObserved === result.cyclesObserved;
|
|
|
|
const fresh =
|
|
existing !== null &&
|
|
now.getTime() - existing.generatedAt.getTime() < PREDICTION_DEBOUNCE_MS;
|
|
|
|
// Skip the write only when the row is BOTH unchanged AND fresh.
|
|
if (unchanged && fresh) return;
|
|
|
|
const data = {
|
|
method: result.method,
|
|
nextPeriodStart: result.nextPeriodStart,
|
|
nextPeriodStartLow: result.nextPeriodStartLow,
|
|
nextPeriodStartHigh: result.nextPeriodStartHigh,
|
|
fertileWindowStart: result.fertileWindowStart,
|
|
fertileWindowEnd: result.fertileWindowEnd,
|
|
predictedOvulation: result.predictedOvulation,
|
|
confidence: result.confidence,
|
|
cyclesObserved: result.cyclesObserved,
|
|
generatedAt: now,
|
|
};
|
|
|
|
await prisma.cyclePrediction.upsert({
|
|
where: { userId },
|
|
create: { userId, ...data },
|
|
update: data,
|
|
});
|
|
}
|