mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-08 12:32:43 +00:00
Exporting the whole record, making a clinician share link, minting a token, and the admin backup download, upload and restore, data wipe and password reset ran on a live session alone. The plaintext full backup did, while the encrypted one beside it asked for a second factor. Whoever held a stolen session could take the record, or leave behind a credential that outlives the session. These now go through one gate, requireRecentProof (assertRecentCookieProof for the routes that resolve their caller themselves). A browser session passes after a sign-in or re-proof within five minutes: a second factor on an account that has one, otherwise the password or a passkey. The refusal is 401 auth.reproof.required with meta.methods, and the web opens the re-proof dialog, posts the proof to the new POST /api/auth/reproof and retries. A password proof stamps the new Session.reproofAt (migration 0359), never mfaVerifiedAt, so it cannot stand in for a second factor anywhere. On Bearer, the full backup asks for an X-Step-Up elevation; the encrypted export asks for a second-factor elevation on an account that has one. Share links and connector tokens keep taking the token alone, because the shipped app calls them without an elevation and reads a 401 there as a dead session; the guard test names them. Key rotation keeps its stricter second-factor gate.
185 lines
7.8 KiB
TypeScript
185 lines
7.8 KiB
TypeScript
/**
|
|
* Error classes for `apiHandler`-wrapped routes — a LEAF module.
|
|
*
|
|
* Moved out of `api-handler.ts` to break the one real import cycle in the
|
|
* tree: api-handler imports the record-session fence, and the fence threw
|
|
* `RecordSessionChangedError` / `SharingAccessDeniedError` imported back
|
|
* from api-handler — a loop that only worked by evaluation-order luck.
|
|
* This module imports nothing but the fence CONTRACT constants (itself a
|
|
* leaf), so anything may import it. `api-handler.ts` re-exports every
|
|
* class, so the ~500 existing importers read exactly as before.
|
|
*/
|
|
import { RECORD_FENCE_ERROR_CODE } from "./sharing/record-session-fence-contract";
|
|
|
|
/**
|
|
* Custom error class for HTTP errors with status codes.
|
|
* Throw inside apiHandler-wrapped routes to return a JSON error response.
|
|
*
|
|
* `errorCode` is optional and lands in `meta.errorCode` when set — the same
|
|
* field the step-up, consent, module and sharing gates already use. An
|
|
* HttpError without one serialises exactly as before.
|
|
*/
|
|
export class HttpError extends Error {
|
|
constructor(
|
|
public statusCode: number,
|
|
message: string,
|
|
public errorCode?: string,
|
|
) {
|
|
super(message);
|
|
this.name = "HttpError";
|
|
}
|
|
}
|
|
|
|
/**
|
|
* The stable codes the generic auth gates refuse with.
|
|
*
|
|
* These decide the single most important branch a native client makes:
|
|
* refresh the token and retry, drop the session and show the login screen, or
|
|
* stop retrying because this credential will never work. Until they existed
|
|
* the only way to tell those apart was to string-match the English sentence
|
|
* "Token expired", so a rewording — or a localisation pass — would have turned
|
|
* a recoverable refresh into a forced logout for every shipped build.
|
|
*
|
|
* Dot.case, matching the majority convention and the `auth.refresh.*` /
|
|
* `auth.stepup.*` families already on the wire. Add to this list rather than
|
|
* inventing a second field.
|
|
*/
|
|
export const AUTH_ERROR_CODES = {
|
|
/** No credential at all: no session cookie and no Bearer header. */
|
|
missing: "auth.missing",
|
|
/** The Bearer token was valid once and its expiry has passed. Refresh. */
|
|
expired: "auth.token.expired",
|
|
/** Unknown, revoked, or belonging to a user that no longer exists. */
|
|
invalid: "auth.token.invalid",
|
|
/** Authenticated, but the credential's scope does not reach this route. */
|
|
scope: "auth.scope.insufficient",
|
|
/** Authenticated, but not an admin. Cookie-only surface; never a token. */
|
|
admin: "auth.admin.required",
|
|
/**
|
|
* The second factor presented on a step-up flow did not verify — a wrong
|
|
* TOTP digit, a replayed one, or a recovery code that is spent. The session
|
|
* itself is untouched: the client re-prompts for a code rather than signing
|
|
* the user out, which is the opposite of what the other 401 codes ask for.
|
|
*/
|
|
mfaCode: "auth.mfa.code_invalid",
|
|
} as const;
|
|
|
|
/**
|
|
* v1.36.0 — the two refusals the acting-account resolver can raise.
|
|
*
|
|
* Both are 403 with a stable `meta.errorCode`, the same envelope shape the
|
|
* step-up and consent gates already use, so a client branches on the code
|
|
* rather than on prose.
|
|
*/
|
|
export abstract class SharingAuthError extends HttpError {
|
|
abstract readonly errorCode: string;
|
|
}
|
|
|
|
/**
|
|
* "You may not act as that account."
|
|
*
|
|
* Deliberately parameterless. The message is a fixed literal and the
|
|
* constructor takes no arguments, so there is no way for a caller to vary the
|
|
* response — which is what makes a selector naming an account that does not
|
|
* exist and one naming an account that granted nothing produce the SAME BYTES.
|
|
* That is not a formatting nicety: a distinguishable refusal turns this
|
|
* endpoint into an account-enumeration oracle for anyone with a login.
|
|
*
|
|
* The indistinguishability is structural rather than careful, too. Neither
|
|
* branch ever looks an account up: the resolver asks the grant table for the
|
|
* (owner, delegate) pair and a missing account and a missing grant are the
|
|
* same empty result, on the same code path, after the same one query.
|
|
*
|
|
* Why the reason is not in the response at all: the caller already knows what
|
|
* they sent, and the only party who benefits from knowing WHICH condition
|
|
* failed is someone probing. The reason goes to the audit row and the wide
|
|
* event, where the owner and the operator can see it.
|
|
*/
|
|
export class SharingAccessDeniedError extends SharingAuthError {
|
|
readonly errorCode = "sharing.access.denied";
|
|
constructor() {
|
|
super(403, "Account access denied");
|
|
this.name = "SharingAccessDeniedError";
|
|
}
|
|
}
|
|
|
|
/**
|
|
* "This endpoint does not act on another account's record."
|
|
*
|
|
* A different fact from the one above and so a different code: nothing here is
|
|
* about whether a grant exists. The route simply never declared that it can be
|
|
* used under a switch, so it refuses rather than quietly serving the caller's
|
|
* OWN record — which is the reverse data-mixing failure, and the reason this
|
|
* class exists at all. A delegate who believes they are reading the owner's
|
|
* record must never be handed their own instead.
|
|
*/
|
|
export class SharingNotPermittedError extends SharingAuthError {
|
|
readonly errorCode = "sharing.not_permitted";
|
|
constructor() {
|
|
super(403, "This endpoint cannot be used while acting on another account");
|
|
this.name = "SharingNotPermittedError";
|
|
}
|
|
}
|
|
|
|
/**
|
|
* v1.37.0 — "the record this session is on is not the record you asserted."
|
|
*
|
|
* A third sibling rather than a branch, so it rides the existing
|
|
* `SharingAuthError` arm with no new serialisation code. The status is
|
|
* the one thing that differs and it differs on purpose: 409, not 403, because
|
|
* this is not a refusal of access. The caller may well be entitled to both
|
|
* records. What failed is agreement about WHICH one, and the instruction the
|
|
* code carries is "reconcile through `/api/auth/me` and try again", not "you
|
|
* have lost this record".
|
|
*
|
|
* That distinction is load-bearing for deploy compatibility: the currently
|
|
* shipped bundle reacts to `sharing.access.denied` by leaving the record and
|
|
* hard-navigating, which is exactly the wrong response to a transient
|
|
* disagreement and exactly the right one for a bundle too old to reconcile. See
|
|
* `src/lib/sharing/record-session-fence-contract.ts` for why the fence hands
|
|
* each bundle the code it can act on.
|
|
*
|
|
* The body carries `meta.errorCode` and nothing else — no current epoch, no
|
|
* current scope. A client may learn its context from exactly two responses
|
|
* (`GET /api/auth/me` and `POST /api/account/switch`), and putting the truth in
|
|
* this refusal would open a third path, one that arrives on the very requests
|
|
* whose context is in doubt.
|
|
*/
|
|
export class RecordSessionChangedError extends SharingAuthError {
|
|
readonly errorCode = RECORD_FENCE_ERROR_CODE;
|
|
constructor() {
|
|
super(409, "The record this session is on has changed");
|
|
this.name = "RecordSessionChangedError";
|
|
}
|
|
}
|
|
|
|
/**
|
|
* The session carries no proof recent enough for the action, and the request
|
|
* brought none. The client asks for one (`POST /api/auth/reproof`, or a proof
|
|
* in the body on the enrollment routes) and retries.
|
|
*/
|
|
export const REPROOF_REQUIRED_CODE = "auth.reproof.required";
|
|
|
|
/**
|
|
* Error thrown when a step-up gate is not satisfied. Carries `errorCode` so
|
|
* the route can surface a stable machine code (`auth.stepup.required`) the
|
|
* client branches on to launch a re-verification flow rather than parsing
|
|
* prose.
|
|
*/
|
|
export class StepUpRequiredError extends HttpError {
|
|
constructor(
|
|
public errorCode: string = "auth.stepup.required",
|
|
message = "Recent second-factor verification required",
|
|
/**
|
|
* Extra machine fields for the envelope's `meta`, beside `errorCode`. The
|
|
* recent-proof gate names the proofs the account can give here
|
|
* (`methods`), so the client offers exactly those and nothing it would
|
|
* then refuse.
|
|
*/
|
|
public extraMeta: Record<string, unknown> = {},
|
|
) {
|
|
super(401, message);
|
|
this.name = "StepUpRequiredError";
|
|
}
|
|
}
|