HealthLog/src/lib/fitbit/__tests__/sync-user-fitbit.test.ts

/**
 * v1.12.0 — `syncUserFitbit` orchestration tests (mocked resource sync).
 *
 * Covers the all-403 "looks-healthy" guard: a genuine grant-revoke 403s the
 * metrics collection. The resource sync soft-skips (returns 0, records no
 * failure) via `handleCollectionFetchError`, so the orchestrator sees
 * `total === 0` with no thrown error — and without the guard would stamp
 * `recordSyncSuccess`, keeping a dead connection "connected" until the
 * token-refresh path catches the 401. The guard refuses to stamp success when
 * every enabled resource soft-skipped and nothing imported.
 */
import { beforeEach, describe, expect, it, vi } from "vitest";

const {
  recordSyncSuccess,
  recordSyncFailure,
  isReauthRequired,
  syncUserMetrics,
  syncUserActivity,
  syncUserSleep,
  syncUserWorkout,
  findUnique,
  update,
  recomputeUserRollups,
} = vi.hoisted(() => ({
  recordSyncSuccess: vi.fn<(...a: unknown[]) => Promise<void>>(async () => {}),
  recordSyncFailure: vi.fn<(...a: unknown[]) => Promise<void>>(async () => {}),
  isReauthRequired: vi.fn<(...a: unknown[]) => Promise<boolean>>(
    async () => false,
  ),
  syncUserMetrics: vi.fn<(...a: unknown[]) => Promise<number>>(),
  syncUserActivity: vi.fn<(...a: unknown[]) => Promise<number>>(),
  syncUserSleep: vi.fn<(...a: unknown[]) => Promise<number>>(),
  syncUserWorkout: vi.fn<(...a: unknown[]) => Promise<number>>(),
  findUnique: vi.fn<(...a: unknown[]) => Promise<unknown>>(),
  update: vi.fn<(...a: unknown[]) => Promise<unknown>>(async () => ({})),
  recomputeUserRollups: vi.fn<(...a: unknown[]) => Promise<unknown>>(
    async () => ({ rowsUpserted: 0, durationMs: 0 }),
  ),
}));

vi.mock("@/lib/db", () => ({
  prisma: {
    fitbitConnection: { findUnique, update },
    measurement: {
      findMany: vi.fn(async () => []),
      createManyAndReturn: vi.fn(async (arg: { data: unknown[] }) =>
        arg.data.map((row, index) => ({
          ...(row as Record<string, unknown>),
          id: `inserted-${index}`,
        })),
      ),
      update: vi.fn(async () => ({})),
    },
  },
}));
vi.mock("@/lib/crypto", () => ({
  encrypt: (s: string) => s,
  decrypt: (s: string) => s,
}));
vi.mock("@/lib/logging/context", () => ({
  getEvent: () => null,
  annotate: () => {},
}));
vi.mock("@/lib/integrations/status", () => ({
  recordSyncFailure: (...a: unknown[]) => recordSyncFailure(...a),
  recordSyncSuccess: (...a: unknown[]) => recordSyncSuccess(...a),
  isReauthRequired: (...a: unknown[]) => isReauthRequired(...a),
}));
vi.mock("@/lib/rollups/measurement-rollups", () => ({
  collapseToTypeDayKeys: (rows: Array<{ type: string; measuredAt: Date }>) =>
    rows,
  recomputeBucketsForMeasurement: vi.fn(async () => {}),
  recomputeUserRollups: (...a: unknown[]) => recomputeUserRollups(...a),
}));
vi.mock("@/lib/insights/comprehensive-generate", () => ({
  invalidateStatusInsightsForTypes: vi.fn(async () => {}),
}));

vi.mock("../sync-metrics", () => ({
  syncUserMetrics: (...a: unknown[]) => syncUserMetrics(...a),
}));
vi.mock("../sync-activity", () => ({
  syncUserActivity: (...a: unknown[]) => syncUserActivity(...a),
}));
vi.mock("../sync-sleep", () => ({
  syncUserSleep: (...a: unknown[]) => syncUserSleep(...a),
}));
vi.mock("../sync-workout", () => ({
  syncUserWorkout: (...a: unknown[]) => syncUserWorkout(...a),
}));

import {
  handleCollectionFetchError,
  noteHardFailure,
  upsertFitbitMeasurements,
} from "../sync-core";
import { syncUserFitbit } from "../sync";
import { FitbitApiError } from "../response-classifier";
import { prisma } from "@/lib/db";

/** A resource sync that 403s its collection and soft-skips, like the real one. */
async function softSkip403(...args: unknown[]): Promise<number> {
  return handleCollectionFetchError(
    "test-resource",
    String(args[0]),
    new FitbitApiError({
      verb: "fetchTest",
      classification: "reauth_required",
      httpStatus: 403,
      reason: "http_403",
    }),
  );
}

/** A connection with a fixed last-synced watermark for the snapshot tests. */
const LAST_SYNCED = new Date("2026-06-01T00:00:00.000Z");

beforeEach(() => {
  vi.clearAllMocks();
  isReauthRequired.mockResolvedValue(false);
  // Default: a connected account with a known watermark.
  findUnique.mockResolvedValue({ lastSyncedAt: LAST_SYNCED });
  update.mockResolvedValue({});
  // The W5 resources default to a quiet success (nothing new) so a test that
  // exercises only the metrics resource doesn't trip the all-soft-skipped guard.
  syncUserMetrics.mockResolvedValue(0);
  syncUserActivity.mockResolvedValue(0);
  syncUserSleep.mockResolvedValue(0);
  syncUserWorkout.mockResolvedValue(0);
});

describe("syncUserFitbit — all-403 looks-healthy guard", () => {
  it("does NOT stamp success when EVERY resource soft-skipped and nothing imported", async () => {
    // A genuine grant-revoke 403s every Restricted bundle — each resource
    // soft-skips. Only when ALL of them soft-skip and nothing imported does the
    // guard refuse to stamp success.
    syncUserMetrics.mockImplementation(softSkip403);
    syncUserActivity.mockImplementation(softSkip403);
    syncUserSleep.mockImplementation(softSkip403);
    syncUserWorkout.mockImplementation(softSkip403);

    const { imported: total } = await syncUserFitbit("user1");

    expect(total).toBe(0);
    expect(recordSyncSuccess).not.toHaveBeenCalled();
    // Soft-skips record no failure either — the status is left exactly as-is so
    // the token-refresh 401 path is the one that flips it to reauth.
    expect(recordSyncFailure).not.toHaveBeenCalled();
  });

  it("stamps success when at least one resource synced even though others soft-skip", async () => {
    // A partial grant: metrics imports, the rest 403 (bundles not granted).
    syncUserMetrics.mockResolvedValue(5);
    syncUserActivity.mockImplementation(softSkip403);
    syncUserSleep.mockImplementation(softSkip403);
    syncUserWorkout.mockImplementation(softSkip403);

    const { imported: total } = await syncUserFitbit("user1");

    expect(total).toBe(5);
    expect(recordSyncSuccess).toHaveBeenCalledWith("user1", "fitbit");
  });

  it("stamps success on a cycle that imported rows", async () => {
    syncUserMetrics.mockResolvedValue(3);
    syncUserActivity.mockResolvedValue(2);

    const res = await syncUserFitbit("user1");

    expect(res).toEqual({ imported: 5, failed: false });
    expect(recordSyncSuccess).toHaveBeenCalledWith("user1", "fitbit");
  });

  it("stamps success on a quiet cycle (no soft-skip, nothing new)", async () => {
    syncUserMetrics.mockResolvedValue(0);

    const { imported: total } = await syncUserFitbit("user1");

    expect(total).toBe(0);
    // No collection was 403'd → this is a genuine "nothing changed" tick.
    expect(recordSyncSuccess).toHaveBeenCalledWith("user1", "fitbit");
  });

  it("short-circuits without stamping success when parked at error_reauth", async () => {
    isReauthRequired.mockResolvedValue(true);

    const { imported: total } = await syncUserFitbit("user1");

    expect(total).toBe(0);
    expect(recordSyncSuccess).not.toHaveBeenCalled();
    expect(syncUserMetrics).not.toHaveBeenCalled();
    // No connection read either — the reauth gate runs first.
    expect(findUnique).not.toHaveBeenCalled();
  });
});

/** A resource sync that HARD-fails its collection (non-403) and, thanks to the
 * ported ledger, records + returns 0 instead of rethrowing. */
async function hardFail500(...args: unknown[]): Promise<number> {
  return handleCollectionFetchError(
    "test-resource",
    String(args[0]),
    new FitbitApiError({
      verb: "fetchTest",
      classification: "transient",
      httpStatus: 500,
      reason: "http_500",
    }),
  );
}

describe("syncUserFitbit — hard-fail ledger (F-SYNC-4)", () => {
  it("a non-403 hard failure does NOT rethrow and keeps siblings running", async () => {
    // Metrics hard-fails (500) but must not abort the cycle: the sibling
    // resources still run, and the whole call resolves (no rethrow).
    syncUserMetrics.mockImplementation(hardFail500);
    syncUserActivity.mockResolvedValue(2);
    syncUserSleep.mockResolvedValue(1);
    syncUserWorkout.mockResolvedValue(0);

    // Resolves (no rethrow) with the siblings' imports.
    const { imported: total } = await syncUserFitbit("user1");
    expect(total).toBe(3);

    // Every sibling resource still ran despite the metrics hard failure.
    expect(syncUserActivity).toHaveBeenCalled();
    expect(syncUserSleep).toHaveBeenCalled();
    expect(syncUserWorkout).toHaveBeenCalled();
  });

  it("a hard-failed collection fails the cycle: no success stamp, no watermark", async () => {
    syncUserMetrics.mockImplementation(hardFail500);
    // Others import so the run is not degenerate — only the ledger keeps it honest.
    syncUserActivity.mockResolvedValue(4);

    await syncUserFitbit("user1");

    // The ledger flips anyFailed → success is NOT stamped and the watermark is
    // not advanced, so the next tick refetches the broken collection's window.
    expect(recordSyncSuccess).not.toHaveBeenCalled();
    expect(update).not.toHaveBeenCalled();
    // The hard failure was recorded on the status ledger.
    expect(recordSyncFailure).toHaveBeenCalled();
  });

  it("a write-failure ledger entry holds the watermark and fails the verdict", async () => {
    // A resource that fetched rows but failed to write them notes the write
    // label on the ledger and returns 0. The F-SYNC-4 test above covers a
    // collection label; this pins the WRITE label (F-2) through the same gate.
    syncUserMetrics.mockImplementation(async () => {
      noteHardFailure("measurements:create");
      return 0;
    });
    // A sibling imports so the run is not degenerate — only the ledger keeps it
    // honest.
    syncUserActivity.mockResolvedValue(4);

    const { imported, failed } = await syncUserFitbit("user1");

    expect(imported).toBe(4);
    expect(failed).toBe(true);
    // The write failure holds the watermark: no stamp, no success.
    expect(update).not.toHaveBeenCalled();
    expect(recordSyncSuccess).not.toHaveBeenCalled();
  });

  it("a failed natural-key rescue probe notes the ledger: no success stamp, no watermark", async () => {
    // The rescue probe (second measurement.findMany inside the upsert) dies.
    // The rows still go to createMany (skipDuplicates absorbs a twin
    // collision), but a twin that WAS wedged would be dropped silently — so
    // the ledger entry must hold the watermark for a retry next tick.
    const measurementFindMany = vi.mocked(prisma.measurement.findMany);
    measurementFindMany
      .mockResolvedValueOnce([]) // externalId probe
      .mockRejectedValueOnce(new Error("db down")); // natural-key rescue probe
    syncUserMetrics.mockImplementation(async (...args: unknown[]) => {
      const { imported } = await upsertFitbitMeasurements(
        String(args[0]),
        [
          {
            type: "ACTIVITY_STEPS",
            value: 8123,
            unit: "steps",
            measuredAt: new Date("2026-07-08T00:00:00.000Z"),
            externalId: "stats:steps:2026-07-08",
          },
        ],
        { deferRollup: true },
      );
      return imported;
    });

    // Resolves (no rethrow) — the insert was still attempted.
    const { imported: total } = await syncUserFitbit("user1");
    expect(total).toBe(1);

    // The ledger flips anyFailed → success is NOT stamped and the watermark is
    // not advanced, so the next tick retries the rescue.
    expect(recordSyncSuccess).not.toHaveBeenCalled();
    expect(update).not.toHaveBeenCalled();
  });
});

describe("syncUserFitbit — single cycle-wide watermark", () => {
  it("snapshots the incremental start ONCE and threads the SAME watermark to every resource", async () => {
    syncUserMetrics.mockResolvedValue(1);

    await syncUserFitbit("user1");

    // The connection's `lastSyncedAt` is read exactly once for the whole cycle.
    expect(findUnique).toHaveBeenCalledTimes(1);

    // Every resource receives the identical resolved `start` (lastSyncedAt - 24h
    // overlap). A per-resource read+stamp would have given later resources a
    // start of ~now, dropping the gap after an outage longer than the overlap.
    const expectedStart = new Date(LAST_SYNCED.getTime() - 24 * 60 * 60 * 1000);
    for (const fn of [
      syncUserMetrics,
      syncUserActivity,
      syncUserSleep,
      syncUserWorkout,
    ]) {
      expect(fn).toHaveBeenCalledTimes(1);
      const opts = fn.mock.calls[0]![1] as { start?: Date; fullSync?: boolean };
      expect(opts.start?.getTime()).toBe(expectedStart.getTime());
    }
  });

  it("stamps markSynced exactly ONCE at the end of a non-degenerate cycle", async () => {
    syncUserMetrics.mockResolvedValue(3);

    await syncUserFitbit("user1");

    // The single end-of-cycle stamp — never per resource.
    expect(update).toHaveBeenCalledTimes(1);
    expect(update.mock.calls[0]![0]).toMatchObject({
      where: { userId: "user1" },
    });
  });

  it("does NOT stamp markSynced when every resource soft-skipped (all-403)", async () => {
    syncUserMetrics.mockImplementation(softSkip403);
    syncUserActivity.mockImplementation(softSkip403);
    syncUserSleep.mockImplementation(softSkip403);
    syncUserWorkout.mockImplementation(softSkip403);

    await syncUserFitbit("user1");

    // Leaving the watermark untouched on a dead cycle keeps the next tick's
    // window from silently advancing past the gap.
    expect(update).not.toHaveBeenCalled();
    expect(recordSyncSuccess).not.toHaveBeenCalled();
  });

  it("passes fullSync + deferRollup through with a bounded backfill start", async () => {
    syncUserMetrics.mockResolvedValue(2);

    await syncUserFitbit("user1", { fullSync: true });

    const opts = syncUserMetrics.mock.calls[0]![1] as {
      start?: Date;
      end?: Date;
      fullSync?: boolean;
      deferRollup?: boolean;
    };
    expect(opts.fullSync).toBe(true);
    // The classic Web API range caps mean the backfill walks a bounded horizon
    // (~1 year back), not an unbounded deep history.
    expect(opts.start).toBeInstanceOf(Date);
    expect(opts.end).toBeInstanceOf(Date);
    const spanDays =
      (opts.end!.getTime() - opts.start!.getTime()) / (24 * 60 * 60 * 1000);
    expect(spanDays).toBeGreaterThan(360);
    expect(spanDays).toBeLessThan(370);
    // The backfill defers the per-write rollup hook to one end-of-cycle pass.
    expect(opts.deferRollup).toBe(true);
  });

  it("does NOT thread deferRollup on an incremental cycle", async () => {
    syncUserMetrics.mockResolvedValue(1);

    await syncUserFitbit("user1");

    const opts = syncUserMetrics.mock.calls[0]![1] as { deferRollup?: boolean };
    expect(opts.deferRollup).not.toBe(true);
  });
});

describe("syncUserFitbit — backfill collapses rollup recompute to one pass", () => {
  it("runs ONE recomputeUserRollups spanning the touched days, not a per-day loop", async () => {
    // A resource that actually writes (via the real deferRollup-aware
    // upsert) so the orchestrator's defer tracker accumulates touched keys.
    syncUserActivity.mockImplementation(async (...args: unknown[]) => {
      const opts = args[1] as { deferRollup?: boolean };
      const { imported } = await upsertFitbitMeasurements(
        String(args[0]),
        [
          {
            type: "ACTIVITY_STEPS",
            value: 1000,
            unit: "count",
            measuredAt: new Date("2026-05-01T00:00:00.000Z"),
            externalId: "stats:steps:2026-05-01",
          },
          {
            type: "ACTIVITY_STEPS",
            value: 2000,
            unit: "count",
            measuredAt: new Date("2026-05-03T00:00:00.000Z"),
            externalId: "stats:steps:2026-05-03",
          },
        ],
        { deferRollup: opts.deferRollup },
      );
      return imported;
    });

    await syncUserFitbit("user1", { fullSync: true });

    // Exactly one collapsed recompute for the whole backfill cycle.
    expect(recomputeUserRollups).toHaveBeenCalledTimes(1);
    const arg = recomputeUserRollups.mock.calls[0]![1] as {
      types: string[];
      from: Date;
      to: Date;
    };
    expect(arg.types).toEqual(["ACTIVITY_STEPS"]);
    // Range spans the first touched day through just past the last.
    expect(arg.from.getTime()).toBe(
      new Date("2026-05-01T00:00:00.000Z").getTime(),
    );
    expect(arg.to.getTime()).toBe(
      new Date("2026-05-03T00:00:00.000Z").getTime() + 24 * 60 * 60 * 1000,
    );
  });

  it("does NOT run the collapsed recompute on an incremental cycle", async () => {
    syncUserMetrics.mockResolvedValue(3);

    await syncUserFitbit("user1");

    expect(recomputeUserRollups).not.toHaveBeenCalled();
  });

  it("returns 0 without running resources when the connection is gone", async () => {
    findUnique.mockResolvedValue(null);

    const { imported: total } = await syncUserFitbit("user1");

    expect(total).toBe(0);
    expect(syncUserMetrics).not.toHaveBeenCalled();
    expect(update).not.toHaveBeenCalled();
  });
});