Files
HealthLog/.planning/phase-B6-report.md
T
Marc-André BombeckandClaude Opus 4.7 ae13dc0fb2 docs(planning): mark phase B6 (settings naming-audit) complete
STATE.md gets the four B6 commits + audit doc link + status block.
phase-B6-report.md was the v1.4.15 doctor-report report; rewritten
for the v1.4.16 phase.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-10 00:29:22 +02:00

4.5 KiB

Phase B6 — Settings naming-audit + UX consolidation (v1.4.16)

Status: complete on origin/main · 2026-05-10T00:28+02:00 · four commits

Previous milestone's B6 (Doctor-report v2 in v1.4.15) is preserved in the v1415 audit summary; this file now belongs to v1.4.16's B6.

Audit doc: docs/audit/v1416-settings-audit.md — 320-line single-pass inventory of every /settings/<slug> route, its component, its i18n keys, its sidebar label vs page heading, and every inconsistency found, with the decision tabulated per row.

What shipped

Four atomic commits on origin/main, on top of the v1.4.16 B7 marker:

  1. 01a05e4 docs(audit): v1.4.16 settings naming + consolidation audit — every slug + section component file path + i18n key namespace + sidebar label vs <h1> checked. Cross-checks against the new memory feedback_settings_no_split.md for top/bottom-split anti-patterns. Out of scope per kickoff: /settings/ai (B2), /settings/export (B7 just shipped, no churn).

  2. a432cb2 refactor(settings): consistent naming + i18n key namespace — file renames so every section follows the canonical <slug>-section.tsx <SlugSection> convention:

    • thresholds-settings-section.tsx (route wrapper) → thresholds-section.tsx
    • inner editor thresholds-section.tsx (<ThresholdsSection>) → thresholds-editor-section.tsx (<ThresholdsEditorSection>)
    • route page import + SECTION_COMPONENTS map updated
    • section test mock points at the new editor module
    • rewrites three muddy section descriptions in EN + DE (account undersold its scope, api was framed as "headless clients"/"Drittanbieter" which Marc doesn't speak, advanced still mentioned "Import" which B7 removed). No user-facing setting removed.
  3. ed0cfda refactor(settings): remove duplicate toggles, route to canonical owner — documents the Settings vs Admin scope rule in CLAUDE.md. The audit found no live duplicate user-facing toggle: notification channels, AI providers, and per-channel test buttons all have legitimate divisions. The rule lands as a new bullet under ## Important Patterns.

  4. d914f76 test(settings): coverage for renamed/consolidated sections — two new <ThresholdsSection> SSR smoke tests, plus brand-new sections-i18n-parity.test.ts that walks every slug in SETTINGS_SECTION_SLUGS and asserts both .title and .description resolve to non-empty strings in EN AND DE — and that the DE description is not a verbatim copy of the EN one. The parity test caught a real instance: notifications.description was "Telegram, ntfy, Web Push." in both locales because the channel names are proper nouns. Rewrote the description in both locales so the German reads as German.

Verification

  • Worktree: /Users/marc/Projects/HealthLog-b6 on agent/b6-settings-audit, rebased onto origin/main and merged fast-forward into main (74c2eb8..d914f76), pushed cleanly.
  • pnpm typecheck — 0 errors.
  • pnpm lint — 12 pre-existing warnings, 0 errors (matches the Wave-A gate baseline).
  • pnpm test --run src/components/settings — 7/7 files, 63/63 tests green (was 40/40 before phase B6 — this phase added 23 new tests).
  • The two pre-existing test failures (i18n-locale-integrity for insights.recommendation.source / viewSource, and insight-citation-footnote for Quelle:) are not my work — they reproduce against the gate baseline before any of my changes and trace back to sibling B5a / B1 agents. Out of B6 scope; flagged for whoever owns those phases.

Out-of-scope items (flagged for follow-up)

  • B2 owns the AI section top/bottom split (Marc's specific call-out — provider dropdown at top, key inputs at bottom) plus the DE sidebar/heading mismatch ("KI-Auswertungen" vs "KI-Insights").
  • Hygiene PR (post-v1.4.16) — migrate every flat settings.<key> consumer to the settings.sections.<slug>.cards.* shape that Export already uses, then delete the legacy flat keys and the dead settings.adminAreaTitle keys.
  • v1.5 product roadmap — surface achievements opt-out, personal medical-references override, locale-detection toggle.

Constraints honoured

  • No user-facing setting removed.
  • No new dependency.
  • Every new i18n key landed in EN + DE.
  • No --no-verify, no --no-gpg-sign.
  • Co-Authored-By trailer on every commit.
  • Commit messages in Marc's voice, no agent/Claude/AI mention.
  • Worktree-isolated so sibling-agent uncommitted state in the primary checkout (B1, B5b in flight) could not bleed in.