tom/HealthLog

0 Fork 0

mirror of https://github.com/MBombeck/HealthLog.git synced 2026-11-14 14:40:52 +00:00

Files

T

Marc-André BombeckandClaude Opus 4.7 a94a3eac45 docs(planning): record phase-7 pre-release verification

- typecheck/lint/test/format clean (modulo the chart test file
  blocked by Marc constraint — pre-existing)
- integration suite green after the test-isolation fix in the
  preceding commit (10/10 consecutive runs)
- build + e2e blocked by the documented Node-25 Reflect.get bug
  on this workstation; CI Docker (Node 22) is canonical and
  Phase-3 already records 41/41 e2e specs green there
- format sweep on .planning/*.md + e2e/measurement-flow.spec.ts
  to clear the warnings Phase 6 reconcile listed as
  pre-existing-out-of-scope

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-09 18:08:25 +02:00

5.5 KiB

Raw Blame History

Phase 5 — UX polish report

Status: done. 6 atomic commits + 1 audit doc. pnpm typecheck, pnpm lint (0 errors / 12 pre-existing warnings), pnpm test (97 files / 752 tests) all green at the end of the phase.

Acceptance criteria

/admin a11y reactivated — e2e/a11y.spec.ts no longer carries a test.fixme for /admin. The audit now covers /admin (overview), /admin/system-status, and /admin/users as the two representative sub-routes called for in the Phase 5 spec. Done in commit 987ce0d fix(a11y): clear axe-core violations on /admin and key sub-routes. The single commit also fixes the violations identified while reading the relevant components:
- duplicate <PasswordInput> in _shared.tsx whose toggle had no accessible name → re-export the canonical one from src/components/settings/password-input.tsx (already aria-labelled in phase 3),
- icon-only buttons in user-management-section.tsx got explicit aria-label and aria-hidden icons,
- empty <dd> placeholder in the audit-log status card removed.
Walk-through audit — written up at docs/audit/v15-ux-friction.md. Top-10 with severity, file location, and status. Method note explains why this round was static (Node-25 Reflect.get regression on the local machine; CI Node 22 will exercise the e2e suite).
Triage — applied. Three v1.4.6 deferred items closed inline:
- feat(ui): trend arrow color reflects metric-specific direction sentiment (38f12df) — directionSentiment prop with up-good / up-bad / neutral buckets; all 11 dashboard tile call sites wired; new trend-card.test.tsx covers all 3 sentiments × 3 slope directions plus the back-compat default.
- feat(settings): allow removing saved AI provider key (788c8ad) — <AlertDialog> confirmation + PATCH null. EN + DE i18n keys.
- style(ui): use semantic tokens for mood and feedback indicators (569300e) — adds --success / --warning / --info to globals.css; dark-mode aliases over the Dracula palette so visuals stay pixel-identical, light-mode (Alucard) gets the higher-contrast counterparts. Migrated callers: feedback BUG badge (→ destructive), feedback published-to-GitHub badge, medication card status, AI section connection badges and success-toast colour.
Two extra friction fixes inline (both <50 LOC):
- fix(ui): disambiguate dashboard quick-add menu items (e3a6899) — closes the Phase-3 i18n collision where both dropdown items rendered the literal "Add". New dashboard.quickAddMeasurement / dashboard.quickAddMood keys; e2e spec rewritten to target by name instead of .first().
- fix(a11y): label /admin overview quick-jump as a navigation landmark (65cfb27) — wraps the section list in <nav aria-labelledby> so the landmark is distinguishable from the sidebar.

Hard constraints honoured

No chart visual changes. The trend-arrow change touches the <TrendCard> icon only; chart axes / lines / colours / animations are untouched (feedback_charts_visual_identity.md enforced).
No edits to src/app/admin/[section]/page.tsx, src/components/layout/sidebar-nav.tsx. The admin shell from Phase 4b stayed put.
No --no-verify, no --no-gpg-sign — every commit went through the pre-commit hook.
No new dependencies — all changes use existing packages (Radix <AlertDialog>, lucide icons, the canonical PasswordInput).

Atomic commit list

SHA	Message
`987ce0d`	fix(a11y): clear axe-core violations on /admin and key sub-routes
`38f12df`	feat(ui): trend arrow color reflects metric-specific direction sentiment
`788c8ad`	feat(settings): allow removing saved AI provider key
`569300e`	style(ui): use semantic tokens for mood and feedback indicators
`e3a6899`	fix(ui): disambiguate dashboard quick-add menu items
`5ffe750`	docs(audit): file v1.5 phase-5 UX friction audit
`65cfb27`	fix(a11y): label /admin overview quick-jump as a navigation landmark

v1.5.1 backlog (from this phase)

Carried to docs/audit/v15-ux-friction.md:

Dedicated Sign-out CTA in <SettingsShell> mobile mode.
aria-label on <nav> landmarks across /insights and other multi-nav pages.
Broader semantic-token sweep (telegram-card, ntfy-card, web-push-card, account-section, about-section, test-connection-button) — same colour swap as feedback / AI / meds but bigger blast radius; needs a single-PR sweep.
"Late" medication status uses dracula-yellow directly; once we have a --caution semantic token, swap that too.
Insights long-page section navigator could grow a "back to top" button on mobile for one-handed reach.

Pre-existing items not touched

The 12 lint warnings (_param-style unused vars in notifications/web-push/test/route.ts, withings/status/route.ts, lib/ai/provider.ts, etc.) are pre-existing and out of scope.
pnpm format:check was not re-run; nothing in this phase touched files outside the standard prettier sweep, and the prior phases document pnpm format:check clean state in the v1.4.6 marathon summary.

Audit doc

docs/audit/v15-ux-friction.md — top-10 friction findings with file locations, severity, status, and v1.5.1 backlog.

5.5 KiB Raw Blame History Unescape Escape