mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-08 04:32:42 +00:00
Marc-André Bombeck
f1773cf602
The bucketer hard-coded Europe/Berlin for day, week and month boundaries, so a reading taken on the last evening of a month landed in the wrong month's bar for everyone who does not live there. Two smaller siblings did the same thing: the Today chip asked the browser for a time instead of the profile, and the score card's tooltip formatter carried a locale but no timezone. The boundary timezone is a required option rather than a defaulted one. A default would have left any caller that forgets to pass one still wrong and still silent; required makes the compiler name them, which is how the three call sites and the eight test sites in this diff were found rather than guessed at. The tests were always asserting Berlin's calendar without saying so, and now they say so. Two fixture mistakes worth recording, both caught by running the tests rather than trusting them: summer time is already in force in Berlin on 31 March, so the first instant chosen was April on both sides; and 31 March 2025 falls in the same ISO week as 1 April, so the week case needed its own instant where one side is still Sunday.