Marc-André Bombeck
359f11fe4d
Deleting a conversation hides the row and sends the DELETE only after the six-second undo window. The pending delete lived in a timer alone, so a reload, a closed tab or an installed app sent to the background inside the window dropped it without a request, and the conversation came back. When the window did run out, the hide filter was released while the paginated history still held the row, so it showed again until the refetch landed. Every surface that deletes a conversation (the Coach panel, the conversations page, the settings memory card) shares one hook, and the fix lives there: - a scheduled delete commits early when the page is hidden, on pagehide and on unmount, and the request is sent with keepalive - a committed row leaves every list cache, head list and every history search variant, before anything else changes, and stays hidden - deletes not yet confirmed are kept in sessionStorage; the next page hides them and sends them again, so its list read cannot bring the row back before the old page's request lands; a 404 counts as gone - a failed delete restores the lists and says so instead of the row quietly returning - Undo after the commit reports false, so the rail does not reopen a thread that is gone
e2e/
End-to-end browser tests. Playwright 1.60 drives a production build of the app against a real PostgreSQL, with @axe-core/playwright for accessibility assertions. This is the heaviest test tier; CI runs it on every PR, and locally it is worth running when a change touches a UI flow.
Running
pnpm e2e
The Playwright config (../playwright.config.ts) builds the app (next build) and brings up Postgres before the specs run; setup/global-setup.ts seeds the auth + fixture state. The suite is not part of the fast local gate (typecheck / lint / test) — it surfaces at PR CI, so expect responsive/wizard/nav reworks to flag here first.
Layout
setup/—test.ts(the suite'stest+expectentry point),global-setup.ts(auth + DB seeding),test-helpers.ts(shared login + navigation helpers).utils/— fixtures such asmock-dashboard-snapshot.ts.fixtures/— synthetic payloads a journey uploads, built in code rather than committed as blobs so the content stays reviewable (apple-health-export.ts).*.spec.ts— one spec per flow: auth/login/redirect, dashboard, charts, the medication-wizard cadences (medications-wizard-*), insights generation + scroll restoration, doctor report, settings, mobile-viewport consistency, locale switch, accessibility (a11y.spec.ts), and thev1427-*regression set.
Conventions
Import test and expect from ./setup/test, never from @playwright/test — types (Page, Route, …) still come from the package. The entry point extends Playwright's test with an automatic fixture that drops route handlers and page listeners after every test, so a handler left in flight cannot fail the test it belonged to once the context closes. src/__tests__/e2e-route-cleanup-guard.test.ts enforces the import boundary.
Assert against stable data-* attributes (data-slot, data-display-step, root display attrs), not viewport-dependent visible text. Responsive sm:hidden UI changes break getByText on desktop while the underlying element is still present — anchoring on data attributes keeps the specs stable across breakpoints. See ../CLAUDE.md.