mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-11 13:52:20 +00:00
Opening an Insights category page froze the whole UI: the per-metric status card fired a cold, uncapped LLM fetch on mount with no client abort, so the request hung up to the server's 60s ceiling and the pending/resolve re-renders thrashed the tab strip and ate touch events. Timeouts were never negatively cached, so every visit re-blocked. Fix the class holistically: - Bound every status GET on the client. The shared use-insight-status hook and the inline medication-compliance query now wrap fetch in an 8s AbortController and stop retrying inline; navigation can no longer await an uncapped round-trip. - Make the status routes read-only. On a cache miss the generator enqueues an out-of-band pg-boss job (insight-status-generate) and returns a preparing envelope; the client polls a bounded interval until the worker warms the cache. Models the dashboard snapshot's ready/preparing pattern. The queue is registered in the worker allQueues loop + a boss.work handler, with a guard test. - Fix the nightly warm-pass regression: warm every supported locale (the client reads against the active UI locale, not the persisted User.locale) and warm on a cached comprehensive outcome too (its write still evicts the per-status caches). Add a short-TTL negative cache on the timeout path so a transient provider stall no longer makes every subsequent visit re-block or re-enqueue. - Add loading.tsx for the insights segment + the root so any future RSC await streams a skeleton instead of blocking the transition. - Stabilise the advisor regenerate callback so a status-query flip can't re-render the memoised tab strip mid-gesture. New i18n key insights.assessmentPreparing across all six locales.
143 lines
4.5 KiB
TypeScript
143 lines
4.5 KiB
TypeScript
import { resolveProvider, resolveProviderChain } from "@/lib/ai/provider";
|
|
import {
|
|
AllProvidersFailedError,
|
|
runRawCompletionWithFallback,
|
|
type ProviderChainResolved,
|
|
} from "@/lib/ai/provider-runner";
|
|
import { annotate } from "@/lib/logging/context";
|
|
import { STATUS_PROVIDER_TIMEOUT_MS, withTimeout } from "./with-timeout";
|
|
|
|
/**
|
|
* Shared provider plumbing for the seven `*-status.ts` generators.
|
|
*
|
|
* Before this, each generator resolved a single provider via
|
|
* `resolveProvider()` and raced one `generateCompletion()` call against
|
|
* a 20 s cap. A degraded primary provider could not cascade, and the
|
|
* cap fired below the providers' own 60 s floor — converting healthy-
|
|
* but-slow generations into the generic fallback.
|
|
*
|
|
* This helper mirrors the Coach (`chat/route.ts`): resolve the user's
|
|
* provider chain, fall back to the legacy single provider when the chain
|
|
* is empty, and run `runRawCompletionWithFallback` so a degraded provider
|
|
* cascades to the next. The whole thing is still wrapped in
|
|
* `withTimeout` at the aligned 60 s budget so a total stall can't pin the
|
|
* card — but a timeout / error is reported as a transient miss (the
|
|
* caller serves the fallback for this render without persisting it),
|
|
* never as the day's cached assessment.
|
|
*/
|
|
|
|
export type StatusProviderResult =
|
|
| { kind: "none" }
|
|
| { kind: "timeout" }
|
|
| { kind: "error" }
|
|
| {
|
|
kind: "ok";
|
|
content: string;
|
|
providerType: string;
|
|
model: string;
|
|
tokensUsed: number | null;
|
|
};
|
|
|
|
interface RunStatusCompletionArgs {
|
|
userId: string;
|
|
cacheAction: string;
|
|
systemPrompt: string;
|
|
userPrompt: string;
|
|
temperature?: number;
|
|
maxTokens?: number;
|
|
}
|
|
|
|
/**
|
|
* Resolve the provider chain for `userId`, falling back to the legacy
|
|
* single provider. Returns `null` when the user has no usable provider
|
|
* anywhere (the caller surfaces the no-key fallback with
|
|
* `hasProvider:false`).
|
|
*/
|
|
async function resolveStatusChain(
|
|
userId: string,
|
|
): Promise<ProviderChainResolved[] | null> {
|
|
const chain = await resolveProviderChain(userId);
|
|
if (chain.length > 0) return chain;
|
|
|
|
const legacy = await resolveProvider(userId);
|
|
if (legacy.type === "none") return null;
|
|
return [{ providerType: "admin-openai", instance: legacy }];
|
|
}
|
|
|
|
/**
|
|
* Cheap provider-availability probe for the read-only status path.
|
|
*
|
|
* v1.8.3 — when a status route runs in read-only mode (serve cache, never
|
|
* block on the LLM) it still has to tell the difference between "no
|
|
* provider — show the no-key fallback" and "provider configured but the
|
|
* assessment isn't warm yet — show preparing + enqueue a generation". This
|
|
* resolves the same chain `runStatusCompletion` would, but does NOT run a
|
|
* completion, so the navigation request never awaits an LLM round-trip.
|
|
*/
|
|
export async function hasUsableStatusProvider(
|
|
userId: string,
|
|
): Promise<boolean> {
|
|
return (await resolveStatusChain(userId)) !== null;
|
|
}
|
|
|
|
/**
|
|
* Run a status generation across the user's provider chain, bounded by
|
|
* `STATUS_PROVIDER_TIMEOUT_MS`. The result discriminates between
|
|
* no-provider / timeout / provider-error / success so the caller can
|
|
* decide what to persist — only `ok` is ever cached as the day's
|
|
* assessment.
|
|
*/
|
|
export async function runStatusCompletion(
|
|
args: RunStatusCompletionArgs,
|
|
): Promise<StatusProviderResult> {
|
|
const { userId, cacheAction, systemPrompt, userPrompt } = args;
|
|
|
|
const chain = await resolveStatusChain(userId);
|
|
if (chain === null) {
|
|
return { kind: "none" };
|
|
}
|
|
|
|
const raced = await withTimeout(
|
|
() =>
|
|
runRawCompletionWithFallback({
|
|
userId,
|
|
providers: chain,
|
|
params: {
|
|
systemPrompt,
|
|
userPrompt,
|
|
temperature: args.temperature ?? 0.3,
|
|
maxTokens: args.maxTokens ?? 1000,
|
|
},
|
|
}),
|
|
STATUS_PROVIDER_TIMEOUT_MS,
|
|
null,
|
|
);
|
|
|
|
if (raced.timedOut) {
|
|
return { kind: "timeout" };
|
|
}
|
|
if (raced.errored || raced.value === null) {
|
|
return { kind: "error" };
|
|
}
|
|
|
|
const { result, workingProvider } = raced.value;
|
|
const content = result.content;
|
|
if (typeof content !== "string" || content.trim().length === 0) {
|
|
annotate({
|
|
action: { name: "insights.status.empty_content" },
|
|
meta: { cacheAction, providerType: workingProvider.providerType },
|
|
});
|
|
return { kind: "error" };
|
|
}
|
|
|
|
return {
|
|
kind: "ok",
|
|
content,
|
|
providerType: workingProvider.providerType,
|
|
model: result.model ?? "unknown",
|
|
tokensUsed: result.tokensUsed ?? null,
|
|
};
|
|
}
|
|
|
|
export { AllProvidersFailedError };
|