mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-11 05:42:19 +00:00
Marc-André BombeckandClaude Opus 4.7
31959e436e
The "Bug reports" admin toggle had no effect. The form on `/bugreport` posts to `/api/feedback`, which was the wrong endpoint for the gate — it lived only on the legacy `/api/bugreport` route the form does not call. Users still submitted into the local feedback inbox after the admin disabled the feature, and the prior commit message claimed "the report button gracefully disappears" was untrue. - `/api/bugreport/status` now also returns `enabled` (defaults true when the column has never been written) so the page can decide whether to render the form at all. - `/api/feedback` POST checks `bugReportEnabled` and returns 503 with a readable error when the admin has switched the feature off, so a scripted client cannot bypass the UI by hitting the endpoint directly. - `/bugreport` page now hides the form and shows the disabled-banner copy when `enabled === false`. - New i18n keys for the disabled state in DE + EN. - Vitest covers the gate: blocked when off, allowed when on, allowed when row absent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
107 lines
2.9 KiB
TypeScript
107 lines
2.9 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from "vitest";
|
|
|
|
vi.mock("@/lib/api-handler", () => ({
|
|
apiHandler: <T extends (...args: unknown[]) => unknown>(fn: T) => fn,
|
|
requireAuth: vi.fn(async () => ({
|
|
user: { id: "u-1", email: "test@example.com", role: "USER" },
|
|
session: { id: "s-1" },
|
|
})),
|
|
}));
|
|
|
|
vi.mock("@/lib/db", () => ({
|
|
prisma: {
|
|
appSettings: { findUnique: vi.fn() },
|
|
feedback: { create: vi.fn() },
|
|
},
|
|
}));
|
|
|
|
vi.mock("@/lib/rate-limit", () => ({
|
|
checkRateLimit: vi.fn(async () => ({ allowed: true })),
|
|
}));
|
|
|
|
vi.mock("@/lib/logging/context", () => ({
|
|
annotate: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("@/lib/auth/audit", () => ({
|
|
auditLog: vi.fn(async () => undefined),
|
|
}));
|
|
|
|
import { POST } from "../route";
|
|
import { prisma } from "@/lib/db";
|
|
|
|
beforeEach(() => {
|
|
vi.resetAllMocks();
|
|
});
|
|
|
|
function jsonRequest(body: unknown): Request {
|
|
return new Request("http://localhost/api/feedback", {
|
|
method: "POST",
|
|
headers: { "content-type": "application/json" },
|
|
body: JSON.stringify(body),
|
|
});
|
|
}
|
|
|
|
describe("POST /api/feedback bug-report toggle gate", () => {
|
|
it("returns 503 when bugReportEnabled is false", async () => {
|
|
vi.mocked(prisma.appSettings.findUnique).mockResolvedValue({
|
|
bugReportEnabled: false,
|
|
} as never);
|
|
|
|
const res = await POST(
|
|
jsonRequest({
|
|
category: "BUG",
|
|
subject: "test",
|
|
description: "Anything at least ten characters long.",
|
|
}),
|
|
);
|
|
expect(res.status).toBe(503);
|
|
const body = (await res.json()) as { error: string };
|
|
expect(body.error).toMatch(/disabled/i);
|
|
// Must not even attempt to create the row when the toggle is off.
|
|
expect(prisma.feedback.create).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("creates feedback when bugReportEnabled is true", async () => {
|
|
vi.mocked(prisma.appSettings.findUnique).mockResolvedValue({
|
|
bugReportEnabled: true,
|
|
} as never);
|
|
vi.mocked(prisma.feedback.create).mockResolvedValue({
|
|
id: "fb-1",
|
|
createdAt: new Date(),
|
|
category: "BUG",
|
|
status: "NEW",
|
|
} as never);
|
|
|
|
const res = await POST(
|
|
jsonRequest({
|
|
category: "BUG",
|
|
subject: "test",
|
|
description: "Anything at least ten characters long.",
|
|
}),
|
|
);
|
|
expect(res.status).toBe(201);
|
|
expect(prisma.feedback.create).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("creates feedback when bugReportEnabled has never been written (default ON)", async () => {
|
|
vi.mocked(prisma.appSettings.findUnique).mockResolvedValue(null);
|
|
vi.mocked(prisma.feedback.create).mockResolvedValue({
|
|
id: "fb-2",
|
|
createdAt: new Date(),
|
|
category: "BUG",
|
|
status: "NEW",
|
|
} as never);
|
|
|
|
const res = await POST(
|
|
jsonRequest({
|
|
category: "BUG",
|
|
subject: "test",
|
|
description: "Anything at least ten characters long.",
|
|
}),
|
|
);
|
|
expect(res.status).toBe(201);
|
|
expect(prisma.feedback.create).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|