mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-08 12:32:43 +00:00
The v1.4.42 senior-dev QA flagged that `dedupeWorkoutBatch` reads the source ladder from the canonical `DEFAULT_WORKOUT_SOURCE_PRIORITY` constant unconditionally, while the read-time picker resolves the per-user `sourcePriorityJson` from the User row. A customised user who promoted MANUAL above APPLE_HEALTH in Settings -> Sources can still have their preferred Manual row dropped at write-time before the read-time picker ever sees it. Scope-narrow today (most paired users keep the Apple-first default) but the moment a user customises, the divergence silently overrides them. The architecturally correct fix (v1.4.43 candidate) is to accept the small ingest-path cost of one indexed `User.sourcePriorityJson` lookup and thread the user's ladder into the picker. Until that lands, this docstring is the load-bearing operator notice.