mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-08 20:42:43 +00:00
Antiheld86
6d86b71a3c
Two notes from review, neither a behaviour change. `counts only live tokens carrying this scope` mints successfully and then inspects the `where` handed to the count — it was sitting in the refusal block and belongs beside the other what-was-the-helper-given cases. Moved verbatim. `still mints on the last free slot` stays where it is, next to the 409 it is the other half of: the pair is what pins `>=` against `>`, and reading either alone tells you less than reading both together. The ceiling is count-then-create and so not atomic — two mints racing at nine both pass and the account lands eleven. Now said out loud, along with the two things a reader cannot see from this file: the overshoot is bounded because the rate limit above is a single atomic upsert, and the house pattern for making it exact is an advisory lock, named with call sites. Left unserialised on purpose — this catches a runaway loop rather than metering a quota, and a lock on a credential mint buys nothing for what it costs.
src/
Application source. HealthLog is a Next.js 16 App Router project (output: "standalone", React 19, TypeScript strict). The path alias @/* resolves to this directory. Everything a request touches lives under here; the layout below follows the request flow rather than alphabetical order.
Request flow
client → src/proxy.ts → src/app/<route>/route.ts → src/lib/api-handler.ts → handler body → src/lib/api-response.ts → client
proxy.ts— the HTTP edge (Next.js 16's renamedmiddleware). Public-path allowlist, demo-mode mutation block, server-side onboarding redirect, worker-only refusal,x-request-id+ CSP nonce generation, every security header.app/— App Router pages (RSC by default) and API routes. Every API route wraps its handler inapiHandler. Seeapp/README.md.lib/— the server/runtime toolkit:apiHandler, auth, crypto, rollups, AI, notifications, pg-boss jobs, integrations, rate limiting. Seelib/README.md.components/— React components (shadcn/ui new-york, kebab-case files). Seecomponents/README.md.
Other directories
hooks/— shared React hooks (use-prefix, kebab-case).types/— shared TypeScript declarations.generated/prisma/— the generated Prisma client (do not edit; regenerated byprisma generate). Imported as@/generated/prisma.instrumentation.ts— Next.js startup hook; boots the pg-boss worker registry and boot-time backfill queues.__tests__/— cross-cutting unit tests; most tests live in__tests__/folders next to the code they cover.
Conventions
See ../CLAUDE.md for the full set. The load-bearing ones: RSC by default ("use client" only when a hook/state/browser API needs it); every API route wraps apiHandler and parses its body with Zod safeParse; userId is always narrowed from session or Bearer, never accepted as a body field; TanStack Query keys come only from src/lib/query-keys/; outbound HTTP goes through src/lib/safe-fetch.ts.