mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 07:13:29 +00:00
The hint shown when a text-only provider needs on-device text recognition sent people to the AI settings, where no such switch exists. It now names the switch by its label under Settings → Modules → Labs in every locale and links straight to that card. Inside somebody else's record the link is withheld, since Settings there is the caller's own and closed; the sentence stays.
245 lines
7.9 KiB
TypeScript
245 lines
7.9 KiB
TypeScript
import { describe, expect, it, vi } from "vitest";
|
|
import { renderToStaticMarkup } from "react-dom/server";
|
|
|
|
import { I18nProvider } from "@/lib/i18n/context";
|
|
|
|
const record = vi.hoisted(() => ({ inSharedRecord: false }));
|
|
vi.mock("@/hooks/use-record-capabilities", () => ({
|
|
useRecordCapabilities: () => ({ inSharedRecord: record.inSharedRecord }),
|
|
}));
|
|
import type { DocumentSuggestionDto } from "@/lib/validations/inbound-documents";
|
|
import {
|
|
AiUnavailableHint,
|
|
AssistSuggestionReview,
|
|
DocumentSummaryPanel,
|
|
} from "../document-ai-panels";
|
|
|
|
/**
|
|
* The AI panels' render contract:
|
|
* - the unavailable state is a CALM pointer to the AI settings, never an
|
|
* error, and adapts its copy to the actionable reason;
|
|
* - the suggestion card is review-first: it applies nothing on its own —
|
|
* every value has its own explicit apply tap, and a dismiss control;
|
|
* - the summary panel ALWAYS carries the "not saved · not a diagnosis" note,
|
|
* even while loading, so the session-only contract is never off-screen.
|
|
*/
|
|
|
|
function render(node: React.ReactNode) {
|
|
return renderToStaticMarkup(
|
|
<I18nProvider initialLocale="en">{node}</I18nProvider>,
|
|
);
|
|
}
|
|
|
|
const noop = () => {};
|
|
|
|
function buttonMarkupByName(html: string, name: string): string {
|
|
const escapedName = name.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
|
|
const markup = html.match(
|
|
new RegExp(
|
|
`<button(?=[^>]*aria-label="${escapedName}")[^>]*>[\\s\\S]*?</button>`,
|
|
),
|
|
)?.[0];
|
|
expect(markup).toBeDefined();
|
|
return markup ?? "";
|
|
}
|
|
|
|
const suggestion = (
|
|
overrides: Partial<DocumentSuggestionDto> = {},
|
|
): DocumentSuggestionDto => ({
|
|
title: "Blood panel — March 2026",
|
|
kind: "LAB_RESULT",
|
|
documentDate: "2026-03-01",
|
|
...overrides,
|
|
});
|
|
|
|
describe("<AiUnavailableHint>", () => {
|
|
it("points calmly at the AI settings when no provider is configured", () => {
|
|
const html = render(<AiUnavailableHint reason="no-provider" />);
|
|
expect(html).toContain('data-slot="assist-unavailable"');
|
|
expect(html).toContain('href="/settings/ai"');
|
|
expect(html).toContain("Set up an AI provider");
|
|
// Never an error affordance.
|
|
expect(html).not.toContain('role="alert"');
|
|
});
|
|
|
|
it("points at the on-device scan switch when a text-only provider needs it", () => {
|
|
const html = render(<AiUnavailableHint reason="enable-local-ocr" />);
|
|
// The switch lives on the Labs module page, under its own label.
|
|
expect(html).toContain("Read scans on this device");
|
|
expect(html).toContain("Settings → Modules → Labs");
|
|
expect(html).toContain('href="/settings/modules/labs#labs-local-ocr"');
|
|
expect(html).toContain("Open lab settings");
|
|
expect(html).not.toContain('href="/settings/ai"');
|
|
});
|
|
|
|
it("keeps the sentence but withholds the Settings link inside somebody else's record", () => {
|
|
record.inSharedRecord = true;
|
|
try {
|
|
const html = render(<AiUnavailableHint reason="enable-local-ocr" />);
|
|
expect(html).toContain("Read scans on this device");
|
|
expect(html).not.toContain('data-slot="assist-settings-link"');
|
|
expect(html).not.toContain('href="/settings');
|
|
} finally {
|
|
record.inSharedRecord = false;
|
|
}
|
|
});
|
|
});
|
|
|
|
describe("<AssistSuggestionReview>", () => {
|
|
it("presents drafts as reviewable fields with explicit apply controls", () => {
|
|
const html = render(
|
|
<AssistSuggestionReview
|
|
suggestion={suggestion()}
|
|
kindLabel="Lab result"
|
|
dateLabel="1 Mar 2026"
|
|
applied={{ title: false, kind: false, date: false }}
|
|
onUseTitle={noop}
|
|
onUseKind={noop}
|
|
onUseDate={noop}
|
|
onDismiss={noop}
|
|
/>,
|
|
);
|
|
expect(html).toContain('data-slot="assist-suggestion-review"');
|
|
// The heading + grey sub-caption were retired — the panel leads straight
|
|
// with the reviewable draft fields.
|
|
expect(html).not.toContain("review before saving");
|
|
expect(html).not.toContain("Nothing is saved until you apply it");
|
|
// The suggested values are shown as reviewable drafts.
|
|
expect(html).toContain("Blood panel — March 2026");
|
|
expect(html).toContain("Lab result");
|
|
expect(html).toContain("1 Mar 2026");
|
|
// Each field has an explicit apply control.
|
|
expect(html).toContain("Use title");
|
|
expect(html).toContain("Apply");
|
|
});
|
|
|
|
it("marks an applied field instead of re-offering it", () => {
|
|
const html = render(
|
|
<AssistSuggestionReview
|
|
suggestion={suggestion()}
|
|
kindLabel="Lab result"
|
|
dateLabel="1 Mar 2026"
|
|
applied={{ title: true, kind: false, date: false }}
|
|
onUseTitle={noop}
|
|
onUseKind={noop}
|
|
onUseDate={noop}
|
|
onDismiss={noop}
|
|
/>,
|
|
);
|
|
expect(html).toContain("Applied");
|
|
});
|
|
|
|
it("shows an empty state when nothing could be read", () => {
|
|
const html = render(
|
|
<AssistSuggestionReview
|
|
suggestion={suggestion({ title: null, kind: null, documentDate: null })}
|
|
kindLabel={null}
|
|
dateLabel={null}
|
|
applied={{ title: false, kind: false, date: false }}
|
|
onUseTitle={noop}
|
|
onUseKind={noop}
|
|
onUseDate={noop}
|
|
onDismiss={noop}
|
|
/>,
|
|
);
|
|
expect(html).toContain("Nothing could be read from this document");
|
|
});
|
|
|
|
it("keeps dismiss compact while providing a 44px mobile target", () => {
|
|
const html = render(
|
|
<AssistSuggestionReview
|
|
suggestion={suggestion()}
|
|
kindLabel="Lab result"
|
|
dateLabel="1 Mar 2026"
|
|
applied={{ title: false, kind: false, date: false }}
|
|
onUseTitle={noop}
|
|
onUseKind={noop}
|
|
onUseDate={noop}
|
|
onDismiss={noop}
|
|
/>,
|
|
);
|
|
const dismiss = buttonMarkupByName(html, "Dismiss");
|
|
expect(dismiss).toContain("size-11");
|
|
expect(dismiss).toContain("sm:size-7");
|
|
expect(dismiss).toContain('aria-label="Dismiss"');
|
|
expect(dismiss).toContain("<svg");
|
|
expect(dismiss).toContain("size-4");
|
|
});
|
|
});
|
|
|
|
describe("<DocumentSummaryPanel>", () => {
|
|
it("keeps the not-saved / not-a-diagnosis note on screen while loading", () => {
|
|
const html = render(
|
|
<DocumentSummaryPanel
|
|
output="summary"
|
|
result={null}
|
|
isPending
|
|
errorText={null}
|
|
onClose={noop}
|
|
/>,
|
|
);
|
|
expect(html).toContain('data-slot="document-summary-panel"');
|
|
expect(html).toContain('data-slot="document-summary-loading"');
|
|
});
|
|
|
|
it("renders the summary body", () => {
|
|
const html = render(
|
|
<DocumentSummaryPanel
|
|
output="summary"
|
|
result={{ summary: "A lipid panel dated 1 March 2026." }}
|
|
isPending={false}
|
|
errorText={null}
|
|
onClose={noop}
|
|
/>,
|
|
);
|
|
expect(html).toContain("A lipid panel dated 1 March 2026.");
|
|
});
|
|
|
|
it("renders extracted text in a monospace block", () => {
|
|
const html = render(
|
|
<DocumentSummaryPanel
|
|
output="text"
|
|
result={{ text: "LDL 3.1 mmol/L" }}
|
|
isPending={false}
|
|
errorText={null}
|
|
onClose={noop}
|
|
/>,
|
|
);
|
|
expect(html).toContain("LDL 3.1 mmol/L");
|
|
expect(html).toContain("Extracted text");
|
|
expect(html).toContain("font-mono");
|
|
});
|
|
|
|
it("surfaces an error via role=alert", () => {
|
|
const html = render(
|
|
<DocumentSummaryPanel
|
|
output="summary"
|
|
result={null}
|
|
isPending={false}
|
|
errorText="Couldn't read the document. Try again."
|
|
onClose={noop}
|
|
/>,
|
|
);
|
|
expect(html).toContain('role="alert"');
|
|
expect(html).toContain("read the document");
|
|
});
|
|
|
|
it("keeps close compact while providing a 44px mobile target", () => {
|
|
const html = render(
|
|
<DocumentSummaryPanel
|
|
output="summary"
|
|
result={{ summary: "A lipid panel dated 1 March 2026." }}
|
|
isPending={false}
|
|
errorText={null}
|
|
onClose={noop}
|
|
/>,
|
|
);
|
|
const close = buttonMarkupByName(html, "Hide");
|
|
expect(close).toContain("size-11");
|
|
expect(close).toContain("sm:size-7");
|
|
expect(close).toContain('aria-label="Hide"');
|
|
expect(close).toContain("<svg");
|
|
expect(close).toContain("size-4");
|
|
});
|
|
});
|