mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 23:33:29 +00:00
The compose file runs Postgres 18. An install from v1.45 or earlier keeps its Postgres 16 data in `pgdata`, which 18 cannot open, so a one-shot `db-upgrade` service moves it on the first start: it starts Postgres 16 on the old volume inside its own container, streams a dump into 18 in one transaction, compares every table's row count, gathers planner statistics and marks the old volume as moved. The app waits for it to succeed. The old volume is never changed apart from the marker, so the way back is the previous image and volume lines. A move cut short leaves a "moving" marker and runs again from scratch; an emptied new volume after a finished move is refused rather than refilled with the old state. scripts/compose-db-upgrade-check.sh plays all of it against real containers from the v1.45.0 compose file, and runs in CI on every change to the compose file. Pull requests run the integration suite and e2e on Postgres 18; the nightly integration run keeps 16 covered for installs that bring their own database.
64 lines
2.5 KiB
TypeScript
64 lines
2.5 KiB
TypeScript
import { readFileSync } from "node:fs";
|
|
import { resolve } from "node:path";
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
/**
|
|
* The bundled database is pinned to an exact minor, AND something watches it.
|
|
*
|
|
* Both halves matter and only together. The pin exists so a database change is
|
|
* a deliberate, reviewable one rather than whatever the registry happens to
|
|
* serve on the day an operator pulls. But PostgreSQL ships security and
|
|
* data-corruption fixes in minor releases and recommends running the current
|
|
* one, so a pin nobody moves ships a knowingly outdated database: this line
|
|
* sat on 16.14 for five weeks after 16.15 was published, because the
|
|
* `docker` ecosystem Dependabot was configured with reads the Dockerfile and
|
|
* never looks at a compose file.
|
|
*
|
|
* So: drop the pin and the deliberate-update model goes; drop the watch and
|
|
* the pin ages in silence. This test fails on either.
|
|
*/
|
|
|
|
const ROOT = resolve(__dirname, "../..");
|
|
|
|
function read(relative: string): string {
|
|
return readFileSync(resolve(ROOT, relative), "utf8");
|
|
}
|
|
|
|
describe("the bundled database pin", () => {
|
|
it("names an exact minor version, not a floating major alias", () => {
|
|
const images = [
|
|
...read("docker-compose.yml").matchAll(/^\s*image:\s*(postgres:\S+)/gm),
|
|
].map((match) => match[1]);
|
|
|
|
// The database itself and `db-upgrade`, which reads the Postgres 16 data
|
|
// of an install from v1.45 or earlier.
|
|
expect(images.length).toBe(2);
|
|
for (const image of images) {
|
|
// `postgres:18-alpine` or `postgres:18` would match a moving target.
|
|
expect(image).toMatch(/^postgres:\d+\.\d+-alpine$/);
|
|
}
|
|
});
|
|
|
|
it("lets a major version through only as a decision, never as an update PR", () => {
|
|
const dependabot = read(".github/dependabot.yml");
|
|
// The first run of the compose ecosystem proposed 16.15 -> 18.6. A
|
|
// PostgreSQL major changes the on-disk format, so it is a migration the
|
|
// project schedules, not an update an operator merges on a Tuesday.
|
|
expect(dependabot).toMatch(
|
|
/dependency-name:\s*"postgres"[\s\S]{0,200}version-update:semver-major/,
|
|
);
|
|
});
|
|
|
|
it("is watched by the compose ecosystem, which is not the Dockerfile one", () => {
|
|
const dependabot = read(".github/dependabot.yml");
|
|
const ecosystems = [
|
|
...dependabot.matchAll(/package-ecosystem:\s*"([^"]+)"/g),
|
|
].map((match) => match[1]);
|
|
|
|
expect(ecosystems).toContain("docker-compose");
|
|
// The Dockerfile watch is a separate entry and does not stand in for it.
|
|
expect(ecosystems).toContain("docker");
|
|
});
|
|
});
|