mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-08 12:32:43 +00:00
Eleven touch-disjoint waves landed on develop plus a six-axis QA reconcile round before tagging. See CHANGELOG.md for the user-facing prose; this commit message documents the wave + report inventory for release-management traceability. Waves shipped (each with a phase report under .planning/): - phase-W-POOL-v1440-report.md — p-limit(4) wrapper around the analytics 15-way fan-out + pg.Pool max raised 10 -> 20. Closes the v1.4.39 empirical-trace finding #1 (Prisma pool starvation). - phase-W-DELETED-v1440-report.md — 11 reader-tier helpers + 3 integration contracts close audit Critical Finding #3 (soft-delete invisibility) across dashboard, analytics, summaries, rollup tiers, and the Coach snapshot path. - phase-W-INSIGHTS-v1440-report.md — mood-rollup swap on the three /api/insights/{features,targets,cards} routes plus the compliance-rollup hook gap closure for bulk-projection mints; the post-QA reconcile patch closes the six remaining measurement.findMany sites in the cluster that still leaked tombstoned rows. - phase-W-INFRA-v1440-report.md — rollup helper umbrella consolidation under src/lib/rollups/* with zero orphan re-exports; lint, typecheck, knip, and 93/93 rollup tests green post-restructure. - phase-W-RSC-v1440-report.md — per-tile Suspense boundaries plus the queryKey factory-bypass walker test (extended to comparison/ in the reconcile pass). - phase-W-PRIVACY-v1440-report.md — bilingual /privacy page with 17 paired-section tests pinning the 9 SB-3 disclosure requirements. - phase-W-AASA-v1440-report.md — /.well-known/apple-app-site-association endpoint pinned to S8WDX4W5KX.dev.healthlog.app with app-ID parity assertions guarding against split rotation. - phase-W-APNS-NOTIFY-v1440-report.md — MEDICATION_REMINDER time-sensitive APNs payload (priority 10 + interruption-level) scoped via a parameterised test that pins all 6 other event-types do not bypass Focus. AP-2 .p8 install gates real delivery. - phase-W-CONSENT-v1440-report.md — AI consent receipts CRUD with append-only invariant pinned in test; revoke-then-regrant leaves both rows; idempotent DELETE returns 200 + receipt: null. - phase-W-WMY-WIRE-v1440-report.md — three previously-dead WMY readers (week/month/year) wired through summaries-slice and health-score-fast-path with a linear-composability parity test pinning the cross-consumer routing contract. - phase-W-GHOSTS-v1440-report.md — ~1 177 lines of dead code removed across 9 atomic commits; startOfUtcDay + wallClockInTz consolidation eliminates a sibling-drift risk; knip whitelist trimmed to three files pending follow-up. QA reconcile patches applied per the v1.4.40 QA round (six reports under .planning/round-v1440-QA-*-findings.md): - senior C1 — dashboard-suspense-boundaries regex aligned with the post-W-INFRA Thread 2 userTimezone-local lift. - senior H1 — soft-delete filter added to the six remaining insights measurement.findMany sites. - specialist H1 — Promise.allSettled around bulk-projection compliance recompute on both /api/medications/intake and /api/dashboard/summary. - ux H1 — compare-toggle migrated to queryKeys.dashboardWidgets factory; walker test extended to src/components/comparison/. - security M1 — consent artefact 64 KB cap enforced via Buffer.byteLength (UTF-8 bytes, not UTF-16 code units). Quality gates green at tag: pnpm typecheck, pnpm lint, pnpm knip --include files,dependencies,binaries,unlisted, pnpm test --run (4726 passing / 1 skipped). Tests 4525 -> 4726 unit + 1 skipped over the v1.4.39 -> v1.4.40 span. User-facing prose: see CHANGELOG.md.
65 lines
2.2 KiB
TypeScript
65 lines
2.2 KiB
TypeScript
/**
|
|
* v1.4.40 W-POOL — pool-config contract for `src/lib/db.ts`.
|
|
*
|
|
* The v1.4.39 empirical cold-mount trace
|
|
* (`.planning/round-v1439-empirical-trace.md` § B2) traced the
|
|
* Wave-B/C dashboard-query stall to the Prisma `pg.Pool` falling
|
|
* back to the library default ceiling of 10 connections. W-POOL
|
|
* pinned the ceiling to 20 via `getPoolMax()`; this test prevents a
|
|
* future refactor from silently dropping the override and re-introducing
|
|
* the saturation regression on a power-user cold mount.
|
|
*
|
|
* The test only exercises the `getPoolMax()` env-resolver. Constructing
|
|
* a real `PrismaClient` requires a live `DATABASE_URL`, which would
|
|
* make this an integration test instead of a unit test — the helper
|
|
* isolation is intentional.
|
|
*/
|
|
import { afterEach, beforeEach, describe, expect, it } from "vitest";
|
|
|
|
import { getPoolMax } from "../db";
|
|
|
|
describe("getPoolMax", () => {
|
|
const originalEnv = process.env.DATABASE_POOL_MAX;
|
|
|
|
beforeEach(() => {
|
|
delete process.env.DATABASE_POOL_MAX;
|
|
});
|
|
|
|
afterEach(() => {
|
|
if (originalEnv === undefined) {
|
|
delete process.env.DATABASE_POOL_MAX;
|
|
} else {
|
|
process.env.DATABASE_POOL_MAX = originalEnv;
|
|
}
|
|
});
|
|
|
|
it("defaults to 20 when DATABASE_POOL_MAX is unset", () => {
|
|
expect(getPoolMax()).toBe(20);
|
|
});
|
|
|
|
it("honours DATABASE_POOL_MAX when it parses to a positive int", () => {
|
|
process.env.DATABASE_POOL_MAX = "30";
|
|
expect(getPoolMax()).toBe(30);
|
|
});
|
|
|
|
it("falls back to 20 on a malformed DATABASE_POOL_MAX", () => {
|
|
process.env.DATABASE_POOL_MAX = "not-a-number";
|
|
expect(getPoolMax()).toBe(20);
|
|
});
|
|
|
|
it("falls back to 20 on a non-positive DATABASE_POOL_MAX", () => {
|
|
process.env.DATABASE_POOL_MAX = "0";
|
|
expect(getPoolMax()).toBe(20);
|
|
process.env.DATABASE_POOL_MAX = "-5";
|
|
expect(getPoolMax()).toBe(20);
|
|
});
|
|
|
|
it("never returns the library default of 10 on the happy path", () => {
|
|
// The whole point of the W-POOL change. If anybody removes the
|
|
// `max:` config from `createPrismaClient` and reverts to the
|
|
// library default, this assertion stops the regression before the
|
|
// next saturated cold mount.
|
|
expect(getPoolMax()).toBeGreaterThanOrEqual(20);
|
|
});
|
|
});
|