Commit Graph
2 Commits
Author SHA1 Message Date
Marc-André Bombeck 8f1af43891 fix(measurements): keep per-type reads on the live index whatever the statistics say
The per-type reads descend measurements_live_covering_idx once per type and
stop at their cap, but the planner chose that descent only when its row
estimates favoured it. The type is a lateral parameter, so one generic
estimate covered every type; an account whose rows arrived after the last
ANALYZE was expected to hold about one row; and statistics taken while the
table held one type made the type condition look free. In those states the
planner walked the type-less (user_id, measured_at) index through every row
of the account once per type, or read every row of each type into a sort.
On a 9,300-row account that was 33,900 row visits for 6,300 rows returned,
1.66 million for the span probe and 845,000 for the dashboard's latest
reading per type.

One shared fragment now holds the descent: the account and the cap reach
the planner through scalar subqueries, and the type is matched as a closed
range it is also ordered on, so only an index leading (user_id, type,
measured_at) can return the rows without a sort. readNewestRowsPerType,
readLiveMeasurementSpan, the dashboard's readLatestEver and the latest-instant
probe of readLatestCanonical use it, and readLatestReadingsPerType reads
through readNewestRowsPerType.

The plan guard moves to its own file, which builds four statistics states on
purpose (none, predating the account over many types and over one type, and
analysed with other accounts) with autovacuum off, and holds every read to
its bound in each. The previous guard depended on statistics another file
had left behind, so it failed in the full suite and passed alone.

Refs #1398
2026-11-17 20:51:39 +01:00
Marc-André Bombeck 9c29fd1121 fix(insights): cap bulk measurement reads per type so a dense stream cannot starve sparse ones
The bulk measurement reads behind the insight features, the Coach snapshot
timelines, the mood cross-metric pairing, the correlation windows and the
weight and blood pressure status cards read newest-first across all their
types under a single row cap. On an account with a wearable heart rate
stream the cap filled within hours, and every weight, blood pressure or
other sparse reading fell out of the read, so blocks reported no data for
metrics with years of it.

All of them now go through one read that descends the live partial index
once per type, each type stopping at its own cap. The feature extraction
and the Coach snapshot cap each type at 6000, so a block built from one
type's read equals the block the full read builds (worst case 72,000 rows
for the twelve feature types). The mood, correlation and status reads keep
their old totals and share them fairly: each type keeps at least its share,
a sparse one all of its window.

The feature context's data span now comes from index probes over every
type in the window rather than from the capped rows, and its measurement
count is the readings the blocks were built from.

Refs #1398
2026-11-16 08:05:00 +01:00