From fd92e9fd23311743d9129718b5ce2c66b0a3a2b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Bombeck?= Date: Thu, 12 Nov 2026 14:05:13 +0100 Subject: [PATCH] fix(i18n): say "back online" once in the offline strip The offline strip joins two sentences, and both ended on "once you're back online"; in French it ran to four lines on a phone, and the Russian one was ungrammatical. The first sentence now only says that changes can't be saved. --- messages/de.json | 2 +- messages/en.json | 2 +- messages/es.json | 2 +- messages/fr.json | 2 +- messages/it.json | 2 +- messages/ko.json | 2 +- messages/nl.json | 2 +- messages/pl.json | 2 +- messages/pt-BR.json | 2 +- messages/ru.json | 2 +- src/components/layout/__tests__/offline-banner.test.tsx | 7 ++++--- 11 files changed, 14 insertions(+), 13 deletions(-) diff --git a/messages/de.json b/messages/de.json index 931181e15..eac4854a7 100644 --- a/messages/de.json +++ b/messages/de.json @@ -521,7 +521,7 @@ "backToDashboard": "Zurück zum Dashboard" }, "offlineBanner": { - "message": "Keine Verbindung: Änderungen können erst gespeichert werden, wenn du wieder online bist.", + "message": "Keine Verbindung: Änderungen können nicht gespeichert werden.", "saveFailed": "Speichern fehlgeschlagen, du bist offline. Bitte versuche es erneut, sobald du wieder online bist.", "stayOnPage": "Diese Seite bleibt lesbar, andere Seiten öffnen sich, sobald du wieder online bist." }, diff --git a/messages/en.json b/messages/en.json index 42f9d12f2..0620047e6 100644 --- a/messages/en.json +++ b/messages/en.json @@ -521,7 +521,7 @@ "backToDashboard": "Back to dashboard" }, "offlineBanner": { - "message": "No connection: changes can't be saved until you're back online.", + "message": "No connection: changes can't be saved.", "saveFailed": "Couldn't save, you're offline. Please try again once you're back online.", "stayOnPage": "This page stays readable; other pages open once you're back online." }, diff --git a/messages/es.json b/messages/es.json index f40f0d6cf..cb7f46cd3 100644 --- a/messages/es.json +++ b/messages/es.json @@ -521,7 +521,7 @@ "backToDashboard": "Volver al panel" }, "offlineBanner": { - "message": "Sin conexión: los cambios no se pueden guardar hasta que vuelvas a estar en línea.", + "message": "Sin conexión: los cambios no se pueden guardar.", "saveFailed": "No se pudo guardar porque estás sin conexión. Inténtalo de nuevo cuando vuelvas a estar en línea.", "stayOnPage": "Esta página se puede seguir leyendo; las demás se abrirán cuando vuelvas a estar en línea." }, diff --git a/messages/fr.json b/messages/fr.json index ed1e2d7d8..005668df3 100644 --- a/messages/fr.json +++ b/messages/fr.json @@ -521,7 +521,7 @@ "backToDashboard": "Retour au tableau de bord" }, "offlineBanner": { - "message": "Pas de connexion : les modifications ne peuvent pas être enregistrées tant que vous n'êtes pas de nouveau en ligne.", + "message": "Pas de connexion : les modifications ne peuvent pas être enregistrées.", "saveFailed": "Enregistrement impossible : vous êtes hors ligne. Réessayez une fois de nouveau en ligne.", "stayOnPage": "Cette page reste lisible ; les autres s'ouvriront dès que vous serez de nouveau en ligne." }, diff --git a/messages/it.json b/messages/it.json index a4497e6bd..e360f8ab8 100644 --- a/messages/it.json +++ b/messages/it.json @@ -521,7 +521,7 @@ "backToDashboard": "Torna alla dashboard" }, "offlineBanner": { - "message": "Nessuna connessione: le modifiche non possono essere salvate finché non torni online.", + "message": "Nessuna connessione: le modifiche non possono essere salvate.", "saveFailed": "Impossibile salvare: sei offline. Riprova quando torni online.", "stayOnPage": "Questa pagina resta leggibile; le altre si aprono quando torni online." }, diff --git a/messages/ko.json b/messages/ko.json index d55264a31..6c4556e6d 100644 --- a/messages/ko.json +++ b/messages/ko.json @@ -521,7 +521,7 @@ "backToDashboard": "대시보드로 돌아가기" }, "offlineBanner": { - "message": "연결이 없어요. 온라인으로 돌아올 때까지 저장할 수 없어요.", + "message": "연결이 없어요. 지금은 저장할 수 없어요.", "saveFailed": "저장하지 못했어요. 오프라인 상태예요. 온라인으로 돌아온 뒤 다시 시도해 주세요.", "stayOnPage": "이 페이지는 계속 볼 수 있어요. 다른 페이지는 온라인으로 돌아오면 열려요." }, diff --git a/messages/nl.json b/messages/nl.json index 720ef174f..f83498a75 100644 --- a/messages/nl.json +++ b/messages/nl.json @@ -521,7 +521,7 @@ "backToDashboard": "Terug naar het dashboard" }, "offlineBanner": { - "message": "Geen verbinding: wijzigingen kunnen pas worden opgeslagen als je weer online bent.", + "message": "Geen verbinding: wijzigingen kunnen niet worden opgeslagen.", "saveFailed": "Opslaan is mislukt, je bent offline. Probeer het opnieuw zodra je weer online bent.", "stayOnPage": "Deze pagina blijft leesbaar; andere pagina's openen zodra je weer online bent." }, diff --git a/messages/pl.json b/messages/pl.json index 45f83ad43..b4431ac15 100644 --- a/messages/pl.json +++ b/messages/pl.json @@ -521,7 +521,7 @@ "backToDashboard": "Powrót do panelu" }, "offlineBanner": { - "message": "Brak połączenia: zmian nie można zapisać, dopóki nie wrócisz online.", + "message": "Brak połączenia: nie można zapisać zmian.", "saveFailed": "Nie udało się zapisać, jesteś offline. Spróbuj ponownie, gdy wrócisz online.", "stayOnPage": "Ta strona pozostaje czytelna, inne otworzą się, gdy wrócisz online." }, diff --git a/messages/pt-BR.json b/messages/pt-BR.json index 14a6ef2b7..d815c9815 100644 --- a/messages/pt-BR.json +++ b/messages/pt-BR.json @@ -521,7 +521,7 @@ "backToDashboard": "Voltar ao painel" }, "offlineBanner": { - "message": "Sem conexão: as alterações não podem ser salvas até você voltar a ficar online.", + "message": "Sem conexão: as alterações não podem ser salvas.", "saveFailed": "Não foi possível salvar, você está offline. Tente novamente quando voltar a ficar online.", "stayOnPage": "Esta página continua legível; as outras abrem quando você voltar a ficar online." }, diff --git a/messages/ru.json b/messages/ru.json index 37f833beb..8b4c02cf2 100644 --- a/messages/ru.json +++ b/messages/ru.json @@ -521,7 +521,7 @@ "backToDashboard": "Назад к сводке" }, "offlineBanner": { - "message": "Нет подключения: изменения нельзя сохранить, пока вы снова не в сети.", + "message": "Нет подключения: изменения нельзя сохранить.", "saveFailed": "Не удалось сохранить, вы не в сети. Попробуйте снова, когда подключение вернётся.", "stayOnPage": "Эту страницу можно читать дальше, другие откроются, когда вы снова будете в сети." }, diff --git a/src/components/layout/__tests__/offline-banner.test.tsx b/src/components/layout/__tests__/offline-banner.test.tsx index cf7e225ac..8d90b48e8 100644 --- a/src/components/layout/__tests__/offline-banner.test.tsx +++ b/src/components/layout/__tests__/offline-banner.test.tsx @@ -46,17 +46,18 @@ describe("", () => { it("ships the EN copy for `offlineBanner.message`", () => { // The copy must not over-promise auto-save: offline mutations now // fail fast (networkMode "always") rather than queue, so the banner states - // the honest thing. + // the honest thing. "Once you're back online" is said by the sentence + // after it, once. const en = loadMessages("en"); expect(en.offlineBanner.message).toBe( - "No connection: changes can't be saved until you're back online.", + "No connection: changes can't be saved.", ); }); it("ships the DE copy for `offlineBanner.message`", () => { const de = loadMessages("de"); expect(de.offlineBanner.message).toBe( - "Keine Verbindung: Änderungen können erst gespeichert werden, wenn du wieder online bist.", + "Keine Verbindung: Änderungen können nicht gespeichert werden.", ); });