mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 07:13:29 +00:00
feat: gate a switched browser on the record's modules, not the actor's
Turning a module off for a profile you look after wrote a column nothing on screen was reading. GET /api/auth/me published the ACTOR's module map while switched, and the navigation, the dashboard tiles and the insights sections all gate on it — so a guardian who turned Cycle off for the child kept seeing a Cycle destination inside the child's record, and a guardian who tracks it saw one there whether or not the child did (#939). The map and the resolved cycle flag now answer for the record the session is inside. They are not display preferences: every surface they gate shows the record's data, so the record is what decides. Locale, theme and layout stay the actor's. The record is taken from the grant-validated active entry rather than the session's own selector, so a revoked switch cannot publish somebody's configuration, and with no switch the payload is what it was. Cycle also gets a row on the guardian's Modules surface, which it never had. It is a delegated module, so its state is the record's own cycle profile and modulePreferences.cycle is refused — which left a guardian no way to turn it off for a record whose sex says it should be on. The family names the real column instead of a blob entry the gate ignores. Refs #939
This commit is contained in:
1 parent
f521b03c35
commit
fb1cb4e3ed
9 files changed
+556
-46
No files matched your search
@@ -23,7 +23,7 @@ describe("managed record settings configuration contract", () => {
|
||||
"timeFormat",
|
||||
"dateFormat",
|
||||
],
|
||||
modules: ["modulePreferences"],
|
||||
modules: ["modulePreferences", "cycleTrackingEnabled"],
|
||||
notifications: ["moodReminderEnabled", "notificationPreferences"],
|
||||
thresholds: ["overrides"],
|
||||
coach: ["disableCoach", "preferences"],
|
||||
@@ -34,6 +34,13 @@ describe("managed record settings configuration contract", () => {
|
||||
it.each([
|
||||
["profile", { email: "not-allowed@example.test" }],
|
||||
["modules", { role: "ADMIN" }],
|
||||
// The delegated key by its module name, which is the mistake a stale
|
||||
// client makes. It has to stay a refusal: accepting it would persist an
|
||||
// inert `false` behind a green "saved" and change nothing.
|
||||
["modules", { modulePreferences: { cycle: false } }],
|
||||
// An empty patch. It parses as a strict object and would audit a change
|
||||
// nobody made.
|
||||
["modules", {}],
|
||||
[
|
||||
"notifications",
|
||||
{
|
||||
@@ -63,6 +70,11 @@ describe("managed record settings configuration contract", () => {
|
||||
},
|
||||
],
|
||||
["modules", { modulePreferences: { mood: false } }],
|
||||
// v1.38.14 (#939) — the delegated key, sent on its own. `cycle` is not a
|
||||
// writable module preference and never will be: its user-layer state is
|
||||
// the record's own cycle profile, so the family names the real column
|
||||
// rather than a blob entry the gate ignores.
|
||||
["modules", { cycleTrackingEnabled: false }],
|
||||
[
|
||||
"notifications",
|
||||
{
|
||||
|
||||
Reference in new issue
Block a user